Message ID | 20210927134231.11177-7-srikanth.k@oneconvergence.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40E78A0C46; Mon, 27 Sep 2021 17:01:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0304F411A1; Mon, 27 Sep 2021 16:58:37 +0200 (CEST) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id B8DA640E3C for <dev@dpdk.org>; Mon, 27 Sep 2021 15:43:15 +0200 (CEST) Received: by mail-pj1-f54.google.com with SMTP id lb1-20020a17090b4a4100b001993f863df2so13733262pjb.5 for <dev@dpdk.org>; Mon, 27 Sep 2021 06:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oneconvergence.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z1oO9hmfz/nQz44rL3kBXq6YVMX+k7y7RSyHhViHvzQ=; b=dMM61kUsjseWam0N6eRdPS3BpO5eXyUw4d1+SArcUzSEWXqPf0Rqo2GgUDkMx7S0ZJ 9D+ZNuC4tq/bWk7d4Y9cG51zyj3NjAsYv2x3Xc4JDAHvy/9wEKIwMq/3NoE+0TxzrF/O U2E5sCpZ/bpQaaNbPdGU65tl5NaGaIXSKKnO4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z1oO9hmfz/nQz44rL3kBXq6YVMX+k7y7RSyHhViHvzQ=; b=hUj4G62EeqR9bezt5F8ZMq2zemIuMjUrMmlzKIhZS5r0zJTEvbiRPy3KSvQgcwI74b GuWMows9tCpeTkwSYD/51LdGnrI1x9HB0lpjQCTNokuJsqEqsW3D9Q8kmaiLX+J/LY1i kCkrT6PVuD/vUM30UPEZ27tl9RWUAV3WfOefFK4OpFJHwLlBAAatF2/cPctIvnW841qo hlqP3glmEqsGCQH2aHWhzB2jAb5ZKIqaeWTmzXR5JilI4WyynjuEWgcXMC1PIXAraWaK jgFXFVtFn8g5XYpThajgsNuuJkjJyS5PVYNOaAb0Bo+YPJd3P3y22kB6CJ5qMZtGrqvf jR3Q== X-Gm-Message-State: AOAM531OG52wflqy+gWG+IJE169Gz3TXdXO9GYqQeigrHTKjCLKBGYEW lK4CyHPHhZSHmGM0FsQlhL0jYg== X-Google-Smtp-Source: ABdhPJxRwJHeo8UEDhptcywuJaJkaohNsfmHz0zBLXi34TW0ZE842eo3gYZJwJ5QOIb3a5oIINyDAg== X-Received: by 2002:a17:902:b102:b0:134:a329:c2f8 with SMTP id q2-20020a170902b10200b00134a329c2f8mr54701plr.71.1632750195021; Mon, 27 Sep 2021 06:43:15 -0700 (PDT) Received: from srikanth-ThinkPad-T450.domain.name ([223.178.22.200]) by smtp.gmail.com with ESMTPSA id b3sm16960665pfo.23.2021.09.27.06.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 06:43:14 -0700 (PDT) From: Srikanth Kaka <srikanth.k@oneconvergence.com> To: Stephen Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com> Cc: dev@dpdk.org, Vag Singh <vag.singh@oneconvergence.com>, Anand Thulasiram <avelu@juniper.net>, Srikanth Kaka <srikanth.k@oneconvergence.com> Date: Mon, 27 Sep 2021 19:12:26 +0530 Message-Id: <20210927134231.11177-7-srikanth.k@oneconvergence.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210927134231.11177-1-srikanth.k@oneconvergence.com> References: <20210927134231.11177-1-srikanth.k@oneconvergence.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 27 Sep 2021 16:58:07 +0200 Subject: [dpdk-dev] [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
add FreeBSD support to VMBUS & NetVSC PMDs
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Srikanth Kaka
Sept. 27, 2021, 1:42 p.m. UTC
On Linux, the request does nothing, while on FreeBSD the HV_UIO kernel driver receives the request and opens the subchannels on PMDs behalf. Signed-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com> Signed-off-by: Vag Singh <vag.singh@oneconvergence.com> Signed-off-by: Anand Thulasiram <avelu@juniper.net> --- drivers/net/netvsc/hn_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+)
Comments
> Subject: [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels > > [You don't often get email from srikanth.k@oneconvergence.com. Learn > why this is important at http://aka.ms/LearnAboutSenderIdentification.] > > On Linux, the request does nothing, while on FreeBSD the HV_UIO kernel > driver receives the request and opens the subchannels on PMDs behalf. > > Signed-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com> > Signed-off-by: Vag Singh <vag.singh@oneconvergence.com> > Signed-off-by: Anand Thulasiram <avelu@juniper.net> > --- > drivers/net/netvsc/hn_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/netvsc/hn_ethdev.c > b/drivers/net/netvsc/hn_ethdev.c index 9e2a405973..6f9053c4d5 100644 > --- a/drivers/net/netvsc/hn_ethdev.c > +++ b/drivers/net/netvsc/hn_ethdev.c > @@ -515,6 +515,10 @@ static int hn_subchan_configure(struct hn_data *hv, > if (err) > return err; > > + err = rte_vmbus_ioctl(hv->vmbus, subchan); > + if (err) > + return err; > + Now I see why you return 0 for Linux. Can you add a comment to say this function is not used and should always succeed in Linux? > while (subchan > 0) { > struct vmbus_channel *new_sc; > uint16_t chn_index; > -- > 2.30.2
Sure. I will add the comment in v2. Regards, Srikanth On Fri, Oct 1, 2021 at 4:49 AM Long Li <longli@microsoft.com> wrote: > > Subject: [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels > > > > [You don't often get email from srikanth.k@oneconvergence.com. Learn > > why this is important at http://aka.ms/LearnAboutSenderIdentification.] > > > > On Linux, the request does nothing, while on FreeBSD the HV_UIO kernel > > driver receives the request and opens the subchannels on PMDs behalf. > > > > Signed-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com> > > Signed-off-by: Vag Singh <vag.singh@oneconvergence.com> > > Signed-off-by: Anand Thulasiram <avelu@juniper.net> > > --- > > drivers/net/netvsc/hn_ethdev.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/net/netvsc/hn_ethdev.c > > b/drivers/net/netvsc/hn_ethdev.c index 9e2a405973..6f9053c4d5 100644 > > --- a/drivers/net/netvsc/hn_ethdev.c > > +++ b/drivers/net/netvsc/hn_ethdev.c > > @@ -515,6 +515,10 @@ static int hn_subchan_configure(struct hn_data *hv, > > if (err) > > return err; > > > > + err = rte_vmbus_ioctl(hv->vmbus, subchan); > > + if (err) > > + return err; > > + > > Now I see why you return 0 for Linux. Can you add a comment to say this > function is not used and should always succeed in Linux? > > > while (subchan > 0) { > > struct vmbus_channel *new_sc; > > uint16_t chn_index; > > -- > > 2.30.2 > >
diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 9e2a405973..6f9053c4d5 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -515,6 +515,10 @@ static int hn_subchan_configure(struct hn_data *hv, if (err) return err; + err = rte_vmbus_ioctl(hv->vmbus, subchan); + if (err) + return err; + while (subchan > 0) { struct vmbus_channel *new_sc; uint16_t chn_index;