[v2] examples/ipsec-secgw: accept inline proto pkts in single sa
Checks
Commit Message
In inline protocol inbound SA's, plain ipv4 and ipv6 packets are
delivered to application unlike inline crypto or lookaside.
Hence fix the application to not drop them when working in
single SA mode.
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
v2:
- Fixed commit message.
examples/ipsec-secgw/ipsec-secgw.c | 10 ----------
1 file changed, 10 deletions(-)
Comments
> Subject: [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single
> sa
>
> In inline protocol inbound SA's, plain ipv4 and ipv6 packets are
> delivered to application unlike inline crypto or lookaside.
> Hence fix the application to not drop them when working in
> single SA mode.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
>
Acked-by: Akhil Goyal <gakhil@marvell.com>
@Konstantin/Bernard: Any objections?
> > Subject: [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single
> > sa
> >
> > In inline protocol inbound SA's, plain ipv4 and ipv6 packets are
> > delivered to application unlike inline crypto or lookaside.
> > Hence fix the application to not drop them when working in
> > single SA mode.
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > ---
> >
> Acked-by: Akhil Goyal <gakhil@marvell.com>
>
> @Konstantin/Bernard: Any objections?
None from me.
>
> > > Subject: [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in
> single
> > > sa
> > >
> > > In inline protocol inbound SA's, plain ipv4 and ipv6 packets are
> > > delivered to application unlike inline crypto or lookaside.
> > > Hence fix the application to not drop them when working in
> > > single SA mode.
> > >
> > > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > > ---
> > >
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> >
> > @Konstantin/Bernard: Any objections?
>
> None from me.
Applied to dpdk-next-crypto
@@ -848,16 +848,6 @@ process_pkts_inbound_nosp(struct ipsec_ctx *ipsec_ctx,
struct rte_mbuf *m;
uint32_t nb_pkts_in, i, idx;
- /* Drop any IPv4 traffic from unprotected ports */
- free_pkts(traffic->ip4.pkts, traffic->ip4.num);
-
- traffic->ip4.num = 0;
-
- /* Drop any IPv6 traffic from unprotected ports */
- free_pkts(traffic->ip6.pkts, traffic->ip6.num);
-
- traffic->ip6.num = 0;
-
if (app_sa_prm.enable == 0) {
nb_pkts_in = ipsec_inbound(ipsec_ctx, traffic->ipsec.pkts,