From patchwork Thu Oct 7 03:23:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 100677 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6F45A0C4D; Thu, 7 Oct 2021 05:24:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6D59411A9; Thu, 7 Oct 2021 05:24:02 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 04EBB41170 for ; Thu, 7 Oct 2021 05:24:01 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id y5so3012473pll.3 for ; Wed, 06 Oct 2021 20:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=u208CC6NZxYxtjG/1l6ZQiBCCNJ491TTxTVYFmRoeTg=; b=PhKpShhmPLBj4RnHetCEtp8bCVsKS+RDcFBCMA6x1LI3BqW+XbCKNchLehBkjAwr8/ /mUXFBOX82mOZVPaEFZnP8z9GNT5U9lOc6Qzm0eMJSqyQ2YapkYyae2j4w1eSLGACFg1 tp8DlIlaSfHcHegZAdp5DLBGXcvZalaj4WM6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=u208CC6NZxYxtjG/1l6ZQiBCCNJ491TTxTVYFmRoeTg=; b=tZcKenibIf5OfFjxj9i67DaGtyIs9/wSzLUvILAdFOYBkbIdc5siqObvryWfwB4yea LonxX0DXqImrTVFpFIAfmU7UvYpru5/5p6oGvof/WWYv2MFKzs68mAZ2uXli0K4ygtG3 /qQxHZqykgl0f1j9kzcyLbGV1h71w16kwCR0Vw8j7H4EG+iM9EJOnUeEx+BUfTV4Hkt7 xUcpQ5juLvH9pUVNUcd7yA/CoGMJvdGYZUrqWpHurc6daY0Z6XWgxeWNdFQyx9uxKeQS Rl6T5qy1ljnDgIrIH6h8Iro+Pzs1cL8/VbGXDiGPqZW73ssmFDwzkYzzHkrVoOfLlnJS mOKQ== X-Gm-Message-State: AOAM531ZaeFkecA8jM5y/ZQN3godgII1JoKIPrpnrlXm4CfzXLozrBcW jAhC24IW86rpogYjMRVvq2Xzb+YYne6A62jJ6V/iVBnWzMFTJUB02h+aUZq5e0bKp7PJqvB/1Ig DIKA0/777VyHY2moaWHc69PUaKslgCt3ToTBv6900jVlXQHn3WIYrPIE+pXB+/Os= X-Google-Smtp-Source: ABdhPJwJG3lUQuA7gb7ouVJ3RGPuEURrmKQIvQNo/uXm8+fzeKk45as2a/iyv5hk7FYpgFd/o1qzXw== X-Received: by 2002:a17:90a:62ca:: with SMTP id k10mr2081148pjs.38.1633577039663; Wed, 06 Oct 2021 20:23:59 -0700 (PDT) Received: from localhost.localdomain ([2600:8802:3300:145:493f:a3ef:de16:5144]) by smtp.gmail.com with ESMTPSA id y15sm16807320pfa.64.2021.10.06.20.23.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Oct 2021 20:23:59 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: stable@dpdk.org, Lance Richardson Date: Wed, 6 Oct 2021 20:23:52 -0700 Message-Id: <20211007032353.93579-3-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20211007032353.93579-1-ajit.khaparde@broadcom.com> References: <20211007032353.93579-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH 2/3] net/bnxt: fix Rx queue state on start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix Rx queue state on device start. The state of Rx queues could be incorrect in some cases because instead of updating the state for all the Rx queues, we are updating it for queues in a VNIC. Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index aa7e7fdc85..a98f93ab29 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -482,12 +482,6 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id) rxq->vnic->fw_grp_ids[j] = INVALID_HW_RING_ID; else vnic->rx_queue_cnt++; - - if (!rxq->rx_deferred_start) { - bp->eth_dev->data->rx_queue_state[j] = - RTE_ETH_QUEUE_STATE_STARTED; - rxq->rx_started = true; - } } PMD_DRV_LOG(DEBUG, "vnic->rx_queue_cnt = %d\n", vnic->rx_queue_cnt); @@ -824,6 +818,16 @@ static int bnxt_start_nic(struct bnxt *bp) } } + for (j = 0; j < bp->rx_nr_rings; j++) { + struct bnxt_rx_queue *rxq = bp->rx_queues[j]; + + if (!rxq->rx_deferred_start) { + bp->eth_dev->data->rx_queue_state[j] = + RTE_ETH_QUEUE_STATE_STARTED; + rxq->rx_started = true; + } + } + rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL); if (rc) { PMD_DRV_LOG(ERR,