net/ice: fix deadlock on flow redirect
Checks
Commit Message
From: Dapeng Yu <dapengx.yu@intel.com>
If flow redirect failed, the spinlock will not be unlocked.
This patch fixes it.
Fixes: bc9201388d56 ("net/ice: support flow redirect")
Cc: stable@dpdk.org
Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
---
drivers/net/ice/ice_generic_flow.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
> -----Original Message-----
> From: Yu, DapengX <dapengx.yu@intel.com>
> Sent: Monday, October 11, 2021 3:39 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ice: fix deadlock on flow redirect
>
> From: Dapeng Yu <dapengx.yu@intel.com>
>
> If flow redirect failed, the spinlock will not be unlocked.
> This patch fixes it.
>
> Fixes: bc9201388d56 ("net/ice: support flow redirect")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -2542,7 +2542,7 @@ ice_flow_redirect(struct ice_adapter *ad,
struct ice_pf *pf = &ad->pf;
struct rte_flow *p_flow;
void *temp;
- int ret;
+ int ret = 0;
rte_spinlock_lock(&pf->flow_ops_lock);
@@ -2552,11 +2552,11 @@ ice_flow_redirect(struct ice_adapter *ad,
ret = p_flow->engine->redirect(ad, p_flow, rd);
if (ret) {
PMD_DRV_LOG(ERR, "Failed to redirect flows");
- return ret;
+ break;
}
}
rte_spinlock_unlock(&pf->flow_ops_lock);
- return 0;
+ return ret;
}