[kmods,v1] windows/netuio: add Intel e1000 device IDs

Message ID 20211011184902.1442-1-u9012063@gmail.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [kmods,v1] windows/netuio: add Intel e1000 device IDs |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing warning apply patch failure
ci/Intel-compilation warning apply issues

Commit Message

William Tu Oct. 11, 2021, 6:49 p.m. UTC
  Add Intel Ethernet e1000 device IDs to netuio inf file.

Signed-off-by: William Tu <u9012063@gmail.com>
--
DPDK patch at:
http://inbox.dpdk.org/dev/20211007202451.90271-1-u9012063@gmail.com/T/#t
---
 windows/netuio/netuio.inf | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Dmitry Kozlyuk Oct. 12, 2021, 1:54 a.m. UTC | #1
2021-10-11 11:49 (UTC-0700), William Tu:
> Add Intel Ethernet e1000 device IDs to netuio inf file.
> 
> Signed-off-by: William Tu <u9012063@gmail.com>

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
  
Kadam, Pallavi Oct. 12, 2021, 3:31 a.m. UTC | #2
Hi William,

On 10/11/2021 11:49 AM, William Tu wrote:
> Add Intel Ethernet e1000 device IDs to netuio inf file.
>
> Signed-off-by: William Tu <u9012063@gmail.com>
> --
> DPDK patch at:
> http://inbox.dpdk.org/dev/20211007202451.90271-1-u9012063@gmail.com/T/#t
> ---
>   windows/netuio/netuio.inf | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
> index 816ff17c7936..28cd0be9de81 100644
> --- a/windows/netuio/netuio.inf
> +++ b/windows/netuio/netuio.inf
> @@ -29,6 +29,7 @@ HKR,,Icon,,-5
>   [Standard.NT$ARCH$]
>   %netuio.DeviceDesc%=netuio_Device, Root\netuio
>   %netuio.nvme.DeviceDesc%=netuio_Device, PCI\CC_010802
> +%Intel.F1521.Description%=netuio_Device, PCI\VEN_8086&DEV_1521
>   %Intel.F1572.Description%=netuio_Device, PCI\VEN_8086&DEV_1572
>   %Intel.F1580.Description%=netuio_Device, PCI\VEN_8086&DEV_1580
>   %Intel.F1581.Description%=netuio_Device, PCI\VEN_8086&DEV_1581
> @@ -43,6 +44,7 @@ HKR,,Icon,,-5
>   %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
>   %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
>   %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
> +%Intel.F10D3.Description%=netuio_Device, PCI\VEN_8086&DEV_10D3
>   %Intel.F1591.Description%=netuio_Device, PCI\VEN_8086&DEV_1591
>   %Intel.F1592.Description%=netuio_Device, PCI\VEN_8086&DEV_1592
>   %Intel.F1593.Description%=netuio_Device, PCI\VEN_8086&DEV_1593
> @@ -100,6 +102,7 @@ ClassName = "Windows UIO"
>   DiskName = "DPDK netUIO Installation Disk"
>   netuio.DeviceDesc = "netuio Device"
>   netuio.nvme.DeviceDesc = "netuio NVM Express Controller"
> +Intel.F1521.Description = "Intel(R) I350 Gigabit Network Connection"
>   Intel.F1572.Description = "Intel(R) Ethernet Controller X710 for 10GbE SFP+"
>   Intel.F1580.Description = "Intel(R) Ethernet Controller XL710 for 40GbE backplane"
>   Intel.F1581.Description = "Intel(R) Ethernet Controller X710 for 10GbE backplane"
> @@ -114,6 +117,7 @@ Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
>   Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
>   Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
>   Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
> +Intel.F10D3.Description = "Intel(R) 82574L Gigabit Ethernet Controller"

As per NDIS inf, the string should be as below:

Intel (R) 82574L Gigabit Network Connection

Thanks,

Pallavi

>   Intel.F1591.Description = "Intel(R) Ethernet Controller E810-C for backplane"
>   Intel.F1592.Description = "Intel(R) Ethernet Controller E810-C for QSFP"
>   Intel.F1593.Description = "Intel(R) Ethernet Controller E810-C for SFP"
  

Patch

diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
index 816ff17c7936..28cd0be9de81 100644
--- a/windows/netuio/netuio.inf
+++ b/windows/netuio/netuio.inf
@@ -29,6 +29,7 @@  HKR,,Icon,,-5
 [Standard.NT$ARCH$]
 %netuio.DeviceDesc%=netuio_Device, Root\netuio
 %netuio.nvme.DeviceDesc%=netuio_Device, PCI\CC_010802
+%Intel.F1521.Description%=netuio_Device, PCI\VEN_8086&DEV_1521
 %Intel.F1572.Description%=netuio_Device, PCI\VEN_8086&DEV_1572
 %Intel.F1580.Description%=netuio_Device, PCI\VEN_8086&DEV_1580
 %Intel.F1581.Description%=netuio_Device, PCI\VEN_8086&DEV_1581
@@ -43,6 +44,7 @@  HKR,,Icon,,-5
 %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
 %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
 %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
+%Intel.F10D3.Description%=netuio_Device, PCI\VEN_8086&DEV_10D3
 %Intel.F1591.Description%=netuio_Device, PCI\VEN_8086&DEV_1591
 %Intel.F1592.Description%=netuio_Device, PCI\VEN_8086&DEV_1592
 %Intel.F1593.Description%=netuio_Device, PCI\VEN_8086&DEV_1593
@@ -100,6 +102,7 @@  ClassName = "Windows UIO"
 DiskName = "DPDK netUIO Installation Disk"
 netuio.DeviceDesc = "netuio Device"
 netuio.nvme.DeviceDesc = "netuio NVM Express Controller"
+Intel.F1521.Description = "Intel(R) I350 Gigabit Network Connection"
 Intel.F1572.Description = "Intel(R) Ethernet Controller X710 for 10GbE SFP+"
 Intel.F1580.Description = "Intel(R) Ethernet Controller XL710 for 40GbE backplane"
 Intel.F1581.Description = "Intel(R) Ethernet Controller X710 for 10GbE backplane"
@@ -114,6 +117,7 @@  Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
 Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
 Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
 Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
+Intel.F10D3.Description = "Intel(R) 82574L Gigabit Ethernet Controller"
 Intel.F1591.Description = "Intel(R) Ethernet Controller E810-C for backplane"
 Intel.F1592.Description = "Intel(R) Ethernet Controller E810-C for QSFP"
 Intel.F1593.Description = "Intel(R) Ethernet Controller E810-C for SFP"