From patchwork Tue Oct 19 20:55:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 102306 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9CEAA0C43; Tue, 19 Oct 2021 22:56:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D19B941100; Tue, 19 Oct 2021 22:56:34 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2070.outbound.protection.outlook.com [40.107.96.70]) by mails.dpdk.org (Postfix) with ESMTP id 915C24003E; Tue, 19 Oct 2021 22:56:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KZwCCWd3XrlFvy4OQOXXqTN6BMOcQk/EPv3gaFBXMPgbC6nuizK66ZcUQp7Cf5fTekvjj17kCxgMK1sL6DL7karfIkMpCPRuvpvgxuMGsFIZmlAtS5kheh+ZBn9Web9iLLACZp/f7gCbWsXNLQKpTL5wheqn/Kgc+8whGxt0wILT6ul6e3PWgl5tkeHY1vSQsvbo/H1QufqevIXE2Ipc87VeIl0tu6VVDI0dtpOb/diu5Mo/59RRch3sRtMjh0zpjxlUPbgqTNWx6nIlIUjrE6LrUNnAWV5vlZbOgRkbuAPFRu1IfM0eaGHpW102w2R7AgfdtmfIOabbrfKuaTXUvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JTFX3lSI9yoy35hHZ/ittCrShuad8icPBzu/iw1sVtk=; b=lFOHnUlHWr8O/Q8HcOsT6BtO3S023EmUwtdLhCNrIwzVX0e7enZ2Bos3iBxcaCr5K89Ao4BnSakv1jviAEkZOk2GTvuEVeVBLatJCvjq1ukTfUdHN+58D2vfR/4JZI6lpTmQgZ3z8tqvrUoESg+bxbzqNXHgUBStv/zGw2JHWxWOQEp3VTjB64LjFJaUuOepnTXiltX0qNvlYe5kypuetOtrEUYlLGL378f/tHyLOTz+pcBtc9l3pDps92rDMHjazlBBJDF6FqyRqqfofTN66HdHGYasM5tc4JekWBv2GlChCibTH49rI/N3Xqtn8+yBH5OxyffEJQ4pUZKrSBj5LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JTFX3lSI9yoy35hHZ/ittCrShuad8icPBzu/iw1sVtk=; b=O2gEh1PyJZsvfgl7Hp5oq+23QnVQdTPdZU0S4cNC4FXCBQZhGi6HkGPUNedfs4tdAOFRAESk5G8lqnT6bSpSmGKmAPeNXqr+DbNdELSd7kkLDMUDu0aMNPP928EcKNYb4cRPyLNRq/oeibap+wuvL4QU8zJ2S9CHPvSPmdUlwjtEGQoxbc9pxLUzGGvRXB2YwTv8bdxBvyeov62NA+S0b5RDN88sUfXLHjY5UyHo8q247YkPeifbl0SrZlsVpHlSh7ygGHxEi0odXIvR2Io/KM946lKVVYz8T25sXN5m00zcelOtXqnpIDIXHpmgtoRrQVHFrusiyQYP9dBEswof4w== Received: from BN9PR03CA0808.namprd03.prod.outlook.com (2603:10b6:408:13f::33) by BL0PR12MB4865.namprd12.prod.outlook.com (2603:10b6:208:17c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct 2021 20:56:29 +0000 Received: from BN8NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13f:cafe::c) by BN9PR03CA0808.outlook.office365.com (2603:10b6:408:13f::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18 via Frontend Transport; Tue, 19 Oct 2021 20:56:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT012.mail.protection.outlook.com (10.13.177.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 20:56:27 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 19 Oct 2021 20:56:22 +0000 From: To: CC: Matan Azrad , Thomas Monjalon , Michael Baum , Date: Tue, 19 Oct 2021 23:55:45 +0300 Message-ID: <20211019205602.3188203-2-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211019205602.3188203-1-michaelba@nvidia.com> References: <20211006220350.2357487-1-michaelba@nvidia.com> <20211019205602.3188203-1-michaelba@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3812ea0d-674c-40ad-cd19-08d99342ebfa X-MS-TrafficTypeDiagnostic: BL0PR12MB4865: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Klo1Xc56+UASepZ7XFTeTWf1Fm85Z5nyGzoRWR99YrKOrj78V8XWVKjRvW3f6PFuiPgMrjU+NiikhNdF7FQwLZdz05GYDx2RjFpxVBgeVB6ecqP2o6I80um2BSituPBmYHAXyyeSClseTxMp/pJhTb/HDa1rJg3QVUzg2VtQCoOXGtUjAYqLOOFJpiN9sF3GOlJnHijpPfCHdBQe5fdC5Ly6Bc5J7Ph80BcRjPzlqsHr/MR5aNEa6+7B1q6nAysmaznVqDFnI0/WPrIm5/842bIRocqezEK6UtXe33sihyg8oDMsTLX0xNX7bJq/A+4I+xliFp7uY2ggbmm5rXxV6V3MEc3aCLEKrt0APztnvK0QrW1M/zk8Zw/MsWlER5zc2+QhrVPoFbY/2PqDeMGiOFLLaZhexy9LcP0QmRFdJ3/pvDQ2OkvFmL/4UZbveILo0goHOmHYuResT4lXoLGJoPbS7czTMX3g5f4dqD+gI08liMmlaNpH5WPbUPEHpf0i7gda3INZTg3z1OnsDUHloSHN/NGUSz1kcAEpM25dMuBvjLKbLJ54eHe8vgf8sx/QItGnr4+m/zxpSTDpimsVz3yjp1DayfT8y6zUliOLCxq4bHd3DZuQ/ckrVwVEOj8D0mphYjTplAMyndpuTD8ETcidTMvcbI1CK5HS5hyMB8yt6/hV7j+WzGxc43wa4E3oEyJenFRPGtObIgBx0Wjw5Q== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(5660300002)(36860700001)(47076005)(8676002)(4326008)(186003)(16526019)(70586007)(70206006)(83380400001)(6286002)(2906002)(7696005)(336012)(26005)(2876002)(8936002)(82310400003)(316002)(2616005)(55016002)(426003)(86362001)(54906003)(1076003)(36756003)(356005)(6916009)(7636003)(508600001)(6666004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 20:56:27.9266 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3812ea0d-674c-40ad-cd19-08d99342ebfa X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4865 Subject: [dpdk-dev] [PATCH v3 01/18] net/mlx5/windows: fix miss callback register for mem event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Michael Baum In device initialization, the driver registers to free hugepages events. When husepage is released, this callback frees all its related MRs. In Windows initialization, this callback is not registered what may cause to use invalid memory. This patch adds memory event callback registration in Windows initialization. Fixes: 980826dc6f0f ("net/mlx5: probe on Windows") Cc: stable@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/windows/mlx5_os.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c index 149253d174..459414d5c2 100644 --- a/drivers/net/mlx5/windows/mlx5_os.c +++ b/drivers/net/mlx5/windows/mlx5_os.c @@ -122,8 +122,21 @@ mlx5_init_shared_data(void) static int mlx5_init_once(void) { + struct mlx5_shared_data *sd; + if (mlx5_init_shared_data()) return -rte_errno; + sd = mlx5_shared_data; + rte_spinlock_lock(&sd->lock); + MLX5_ASSERT(sd); + if (!sd->init_done) { + LIST_INIT(&sd->mem_event_cb_list); + rte_rwlock_init(&sd->mem_event_rwlock); + rte_mem_event_callback_register("MLX5_MEM_EVENT_CB", + mlx5_mr_mem_event_cb, NULL); + sd->init_done = true; + } + rte_spinlock_unlock(&sd->lock); return 0; }