[2/2] dmadev: remove symbol versioning for inline helpers

Message ID 20211020065944.19617-2-david.marchand@redhat.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series [1/2] dmadev: hide devices array |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

David Marchand Oct. 20, 2021, 6:59 a.m. UTC
  Inline helpers have no global symbols in shared libraries.
There is no reason to ask for versioning (plus this library would not
build on Windows).

Fixes: 91e581e5c924 ("dmadev: add data plane API")
Fixes: ea8cf0f8536d ("dmadev: add burst capacity API")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/dmadev/version.map | 7 -------
 1 file changed, 7 deletions(-)
  

Comments

Bruce Richardson Oct. 20, 2021, 9:40 a.m. UTC | #1
On Wed, Oct 20, 2021 at 08:59:44AM +0200, David Marchand wrote:
> Inline helpers have no global symbols in shared libraries.
> There is no reason to ask for versioning (plus this library would not
> build on Windows).
> 
> Fixes: 91e581e5c924 ("dmadev: add data plane API")
> Fixes: ea8cf0f8536d ("dmadev: add burst capacity API")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
  

Patch

diff --git a/lib/dmadev/version.map b/lib/dmadev/version.map
index 89f7a5b1d3..7031d6b335 100644
--- a/lib/dmadev/version.map
+++ b/lib/dmadev/version.map
@@ -1,17 +1,11 @@ 
 EXPERIMENTAL {
 	global:
 
-	rte_dma_burst_capacity;
 	rte_dma_close;
-	rte_dma_completed;
-	rte_dma_completed_status;
 	rte_dma_configure;
-	rte_dma_copy;
-	rte_dma_copy_sg;
 	rte_dma_count_avail;
 	rte_dma_dev_max;
 	rte_dma_dump;
-	rte_dma_fill;
 	rte_dma_get_dev_id_by_name;
 	rte_dma_info_get;
 	rte_dma_is_valid;
@@ -20,7 +14,6 @@  EXPERIMENTAL {
 	rte_dma_stats_get;
 	rte_dma_stats_reset;
 	rte_dma_stop;
-	rte_dma_submit;
 	rte_dma_vchan_setup;
 	rte_dma_vchan_status;