From patchwork Wed Oct 20 08:21:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xueming Li X-Patchwork-Id: 102387 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BC8AA0547; Wed, 20 Oct 2021 10:22:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C9A7411A6; Wed, 20 Oct 2021 10:22:25 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2089.outbound.protection.outlook.com [40.107.220.89]) by mails.dpdk.org (Postfix) with ESMTP id AEA1240683 for ; Wed, 20 Oct 2021 10:22:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTdXgmy4pVxQtHSoGuhZRSIPmq5U/i0DjQfT5OeP2dQGKQ8WjM7cJ2n5nQuiiHVjzqJsOA5rpmFNKFOqycMsC54Oog+hs0oG/j2Q5f8/aEFE8KFl0CwnFAW+0PwZ1n2fRyTQwABo0Uq0Wet8cqzeNgWEMc+26c3ymscFuvV8HDePTohN92tjJrGMY2sc2K2Jo4/lnGhiccbCTyqaJy605Nf/1Kk/0mPf5PhoHnCu3kGt71TlZSV/4D6md5Mo0Ze7Q2aSFT++xW8JQ+AW01/euRWFiYfhXilqXC4DzUYVpeq4Vm+IMt4GxSXZ8QumuiBPwmItHl6tXl2shqTCEk/HDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4KAr2LwsyxrUUvrTws8k1F5IP+hGZvUFWm83+R5viwk=; b=YbsFn4WtmCbjcsTj22jbJZIroA6Q1s8EIs2qdWEi9VFdCRiy6b9ZUyDbq7KXrCgnS4/9LaMjyZ+QH6B0n+FrRtReEGFgB3U4eDu4Au9CBhaAxsIt58VxT7hFgYLWqTGMIEckaW/VlSL2irnCbHbHTO03Ae9wkQFA6ep6t2mn1pHNDcGiDxJKGKMroa1q1bz10qLFBEqBzdRSjHTdqpuF5PlEBeALnDbD4eyiSFF4dquK18stJMn3oCDAJij6pDaG/3ZpYgk+91OvhLV6pc0Jg04syZgdEXBMtWLuF1zuKFhl8oYca+b3q5daUKqiL2HlsI6kNrigvtaGltSOY+/s0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4KAr2LwsyxrUUvrTws8k1F5IP+hGZvUFWm83+R5viwk=; b=JHcX3lEJneELXMe0T1LqmDJB8RnFFmyGDtwx1jOr33F3euHQD4WRVoyane63Le8WNYTJScxw0ZmCGlyTQoUuzwhBxrYPaNbXlL+JgBMRltsavzorWRZXu1M4sHxpV66Q7ZExIl52NJYB4f6qzVDhnmIX4PHDDlpYQOeD6vOOkvV01f7dvX0O/2csfYXuq9+MXPeO+UJrK42/GWrZ8M0DiiEIp37IqeDCx4QUMpZzjlyALilMUb3y4dVdhaQM+mmwcdYCJxnUQ0JjOCcPucg9SVGpJtQ4qpQbW0aZCrlBaUJ7nmTPNcdHwzIcEOt3ahFQEV1h1YwUrARInl0cw0HBxQ== Received: from DM5PR07CA0101.namprd07.prod.outlook.com (2603:10b6:4:ae::30) by SN1PR12MB2478.namprd12.prod.outlook.com (2603:10b6:802:23::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Wed, 20 Oct 2021 08:22:19 +0000 Received: from DM6NAM11FT014.eop-nam11.prod.protection.outlook.com (2603:10b6:4:ae:cafe::af) by DM5PR07CA0101.outlook.office365.com (2603:10b6:4:ae::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15 via Frontend Transport; Wed, 20 Oct 2021 08:22:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT014.mail.protection.outlook.com (10.13.173.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 08:22:19 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 20 Oct 2021 08:22:15 +0000 From: Xueming Li To: , Gaetan Rivet CC: , Thomas Monjalon , "Lior Margalit" Date: Wed, 20 Oct 2021 16:21:59 +0800 Message-ID: <20211020082200.2412189-3-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211020082200.2412189-1-xuemingl@nvidia.com> References: <20211005123012.264727-1-xuemingl@nvidia.com> <20211020082200.2412189-1-xuemingl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9ddd884-0b79-4b53-52ed-08d993a2bc08 X-MS-TrafficTypeDiagnostic: SN1PR12MB2478: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1443; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WYK3kGQv960Q2A1SQMB5ni2VmmUf9RJpQna/jiahhFMhgPm4BPxzp0HKhY2dJILL5EspwM2MUBEvXIxGoJm/xqAPw+CX68zKqUnisz5BHEQSFi9R2aQj2/w+dZJZoJBBBdfnOZtBuuolYZQWFLaEAeM6CmjL4TlVMVcFot0ycl/XksaMMtf49iXc+b5G+7f+GHpxWd0XzD8hxk8+CcGKBshWuE4NTV8SRU+apAGI8Az+YkzJa28o3OyuIsHLuvR1SlFYuy+05UEM0i0ajwMamSSCZp87U+HrH4uth3+Oe8//5QQODA+tBs3atY5SzK4Xf3fQTU+z0Sk+tn1vjmnfw5Js7Llxwc0UsZo1Z/2Pn23jQU72dhNCihLFSdUukPOtwX0zplrZSSJX+qj0amSPS+tjzwcEvIxpv4hD/30ZG1rOqU/ZAAHfyRxUradjryTCqob7QXfBbzW19qydJrwdNdvwLA+debWmUoZTlrFBHBZVq6Fk4BpaCUa1S4eBqgu4UkWNEl5cBhmlj0TGe/45B6SswZTYfCOrjAFk6mZ7q4lyr+lkFPccwDohXXDrE/bDBC3OoVY0r2SavEdOzn+Tm0i+Fe4DF2kaIR2ISbEcNg5M+/6Inj5VAPoqzguWbNjPI7mTI47tSAK7TfhjBGfIOzOGdryAkl19MmtFjOe/S/ZLIJfQ1xOHPIce8qU8dPXt5pimY7cR3LHkmQVCTDIeqw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(47076005)(336012)(7696005)(26005)(186003)(508600001)(1076003)(16526019)(83380400001)(70206006)(6286002)(316002)(36906005)(110136005)(5660300002)(70586007)(86362001)(107886003)(2906002)(8676002)(6666004)(7636003)(8936002)(356005)(82310400003)(4326008)(54906003)(36860700001)(2616005)(55016002)(36756003)(426003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 08:22:19.3346 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9ddd884-0b79-4b53-52ed-08d993a2bc08 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT014.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2478 Subject: [dpdk-dev] [PATCH v3 2/3] devargs: make bus key parsing optional X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Global devargs syntax is used as device iteration filter like "class=vdpa", a devargs without bus args is valid from parsing perspective. This patch makes bus args optional. Fixes: d2a66ad79480 ("bus: add device arguments name parsing") Signed-off-by: Xueming Li Reviewed-by: Gaetan Rivet --- drivers/bus/pci/pci_params.c | 8 +++----- lib/eal/common/eal_common_devargs.c | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/bus/pci/pci_params.c b/drivers/bus/pci/pci_params.c index 21c2e1d0368..60b424b8297 100644 --- a/drivers/bus/pci/pci_params.c +++ b/drivers/bus/pci/pci_params.c @@ -87,11 +87,10 @@ rte_pci_devargs_parse(struct rte_devargs *da) struct rte_kvargs *kvargs; const char *addr_str; struct rte_pci_addr addr; - int ret; + int ret = 0; - if (da == NULL) + if (da == NULL || da->bus_str == NULL) return 0; - RTE_ASSERT(da->bus_str != NULL); kvargs = rte_kvargs_parse(da->bus_str, NULL); if (kvargs == NULL) { @@ -103,9 +102,8 @@ rte_pci_devargs_parse(struct rte_devargs *da) addr_str = rte_kvargs_get(kvargs, pci_params_keys[RTE_PCI_PARAM_ADDR]); if (addr_str == NULL) { - RTE_LOG(ERR, EAL, "No PCI address specified using '%s=' in: %s\n", + RTE_LOG(DEBUG, EAL, "No PCI address specified using '%s=' in: %s\n", pci_params_keys[RTE_PCI_PARAM_ADDR], da->bus_str); - ret = -ENODEV; goto out; } diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index d673598032d..8c7650cf6c2 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -39,7 +39,7 @@ devargs_bus_parse_default(struct rte_devargs *devargs, /* Parse devargs name from bus key-value list. */ name = rte_kvargs_get(bus_args, "name"); if (name == NULL) { - RTE_LOG(INFO, EAL, "devargs name not found: %s\n", + RTE_LOG(DEBUG, EAL, "devargs name not found: %s\n", devargs->data); return 0; }