From patchwork Fri Oct 22 09:20:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "humin (Q)" X-Patchwork-Id: 102647 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2114DA0C43; Fri, 22 Oct 2021 11:22:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69D21411CE; Fri, 22 Oct 2021 11:22:11 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 5741241186 for ; Fri, 22 Oct 2021 11:21:59 +0200 (CEST) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4HbJjj4sHPz8tmr; Fri, 22 Oct 2021 17:20:41 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.15; Fri, 22 Oct 2021 17:21:57 +0800 From: "Min Hu (Connor)" To: CC: , Date: Fri, 22 Oct 2021 17:20:00 +0800 Message-ID: <20211022092006.60959-10-humin29@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211022092006.60959-1-humin29@huawei.com> References: <20211022092006.60959-1-humin29@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH 09/14] net/hns3: use APIs in hns3 HW ops to config MAC features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Huisong Li This patch uses APIs in hns3_hw_ops to configure MAC related features. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 32 +++++++++++++++---------------- drivers/net/hns3/hns3_ethdev_vf.c | 27 +++++++++++++------------- 2 files changed, 30 insertions(+), 29 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index e1099f5df9..dcdbb962eb 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -1656,9 +1656,9 @@ hns3_add_mac_addr(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr, rte_spinlock_unlock(&hw->lock); return -EINVAL; } - ret = hns3_add_mc_mac_addr(hw, mac_addr); + ret = hw->ops.add_mc_mac_addr(hw, mac_addr); } else { - ret = hns3_add_uc_mac_addr(hw, mac_addr); + ret = hw->ops.add_uc_mac_addr(hw, mac_addr); } if (ret) { rte_spinlock_unlock(&hw->lock); @@ -1714,9 +1714,9 @@ hns3_remove_mac_addr(struct rte_eth_dev *dev, uint32_t idx) rte_spinlock_lock(&hw->lock); if (rte_is_multicast_ether_addr(mac_addr)) - ret = hns3_remove_mc_mac_addr(hw, mac_addr); + ret = hw->ops.del_mc_mac_addr(hw, mac_addr); else - ret = hns3_remove_uc_mac_addr(hw, mac_addr); + ret = hw->ops.del_uc_mac_addr(hw, mac_addr); rte_spinlock_unlock(&hw->lock); if (ret) { hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE, @@ -1737,7 +1737,7 @@ hns3_set_default_mac_addr(struct rte_eth_dev *dev, rte_spinlock_lock(&hw->lock); oaddr = (struct rte_ether_addr *)hw->mac.mac_addr; - ret = hns3_remove_uc_mac_addr(hw, oaddr); + ret = hw->ops.del_uc_mac_addr(hw, oaddr); if (ret) { hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE, oaddr); @@ -1748,7 +1748,7 @@ hns3_set_default_mac_addr(struct rte_eth_dev *dev, return ret; } - ret = hns3_add_uc_mac_addr(hw, mac_addr); + ret = hw->ops.add_uc_mac_addr(hw, mac_addr); if (ret) { hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE, mac_addr); @@ -1769,7 +1769,7 @@ hns3_set_default_mac_addr(struct rte_eth_dev *dev, return 0; err_pause_addr_cfg: - ret_val = hns3_remove_uc_mac_addr(hw, mac_addr); + ret_val = hw->ops.del_uc_mac_addr(hw, mac_addr); if (ret_val) { hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE, mac_addr); @@ -1779,7 +1779,7 @@ hns3_set_default_mac_addr(struct rte_eth_dev *dev, } err_add_uc_addr: - ret_val = hns3_add_uc_mac_addr(hw, oaddr); + ret_val = hw->ops.add_uc_mac_addr(hw, oaddr); if (ret_val) { hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE, oaddr); hns3_warn(hw, "Failed to restore old uc mac addr(%s): %d", @@ -1805,11 +1805,11 @@ hns3_configure_all_mac_addr(struct hns3_adapter *hns, bool del) if (rte_is_zero_ether_addr(addr)) continue; if (rte_is_multicast_ether_addr(addr)) - ret = del ? hns3_remove_mc_mac_addr(hw, addr) : - hns3_add_mc_mac_addr(hw, addr); + ret = del ? ops->del_mc_mac_addr(hw, addr) : + ops->add_mc_mac_addr(hw, addr); else - ret = del ? hns3_remove_uc_mac_addr(hw, addr) : - hns3_add_uc_mac_addr(hw, addr); + ret = del ? ops->del_uc_mac_addr(hw, addr) : + ops->add_uc_mac_addr(hw, addr); if (ret) { err = ret; @@ -2125,7 +2125,7 @@ hns3_set_mc_mac_addr_list(struct rte_eth_dev *dev, for (i = 0; i < rm_addr_num; i++) { num = rm_addr_num - i - 1; addr = &rm_addr_list[num]; - ret = hns3_remove_mc_mac_addr(hw, addr); + ret = hw->ops.del_mc_mac_addr(hw, addr); if (ret) { rte_spinlock_unlock(&hw->lock); return ret; @@ -2136,7 +2136,7 @@ hns3_set_mc_mac_addr_list(struct rte_eth_dev *dev, /* Add mc mac addresses */ for (i = 0; i < add_addr_num; i++) { addr = &add_addr_list[i]; - ret = hns3_add_mc_mac_addr(hw, addr); + ret = hw->ops.add_mc_mac_addr(hw, addr); if (ret) { rte_spinlock_unlock(&hw->lock); return ret; @@ -2166,9 +2166,9 @@ hns3_configure_all_mc_mac_addr(struct hns3_adapter *hns, bool del) if (!rte_is_multicast_ether_addr(addr)) continue; if (del) - ret = hns3_remove_mc_mac_addr(hw, addr); + ret = hw->ops.del_mc_mac_addr(hw, addr); else - ret = hns3_add_mc_mac_addr(hw, addr); + ret = hw->ops.add_mc_mac_addr(hw, addr); if (ret) { err = ret; hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE, diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c index b5c6a696f3..616b3ed6db 100644 --- a/drivers/net/hns3/hns3_ethdev_vf.c +++ b/drivers/net/hns3/hns3_ethdev_vf.c @@ -229,9 +229,9 @@ hns3vf_add_mac_addr(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr, rte_spinlock_unlock(&hw->lock); return -EINVAL; } - ret = hns3vf_add_mc_mac_addr(hw, mac_addr); + ret = hw->ops.add_mc_mac_addr(hw, mac_addr); } else { - ret = hns3vf_add_uc_mac_addr(hw, mac_addr); + ret = hw->ops.add_uc_mac_addr(hw, mac_addr); } rte_spinlock_unlock(&hw->lock); @@ -257,9 +257,9 @@ hns3vf_remove_mac_addr(struct rte_eth_dev *dev, uint32_t idx) rte_spinlock_lock(&hw->lock); if (rte_is_multicast_ether_addr(mac_addr)) - ret = hns3vf_remove_mc_mac_addr(hw, mac_addr); + ret = hw->ops.del_mc_mac_addr(hw, mac_addr); else - ret = hns3vf_remove_uc_mac_addr(hw, mac_addr); + ret = hw->ops.del_uc_mac_addr(hw, mac_addr); rte_spinlock_unlock(&hw->lock); if (ret) { @@ -326,9 +326,10 @@ hns3vf_set_default_mac_addr(struct rte_eth_dev *dev, static int hns3vf_configure_mac_addr(struct hns3_adapter *hns, bool del) { + char mac_str[RTE_ETHER_ADDR_FMT_SIZE]; struct hns3_hw *hw = &hns->hw; + struct hns3_hw_ops *ops = &hw->ops; struct rte_ether_addr *addr; - char mac_str[RTE_ETHER_ADDR_FMT_SIZE]; int err = 0; int ret; int i; @@ -338,11 +339,11 @@ hns3vf_configure_mac_addr(struct hns3_adapter *hns, bool del) if (rte_is_zero_ether_addr(addr)) continue; if (rte_is_multicast_ether_addr(addr)) - ret = del ? hns3vf_remove_mc_mac_addr(hw, addr) : - hns3vf_add_mc_mac_addr(hw, addr); + ret = del ? ops->del_mc_mac_addr(hw, addr) : + ops->add_mc_mac_addr(hw, addr); else - ret = del ? hns3vf_remove_uc_mac_addr(hw, addr) : - hns3vf_add_uc_mac_addr(hw, addr); + ret = del ? ops->del_uc_mac_addr(hw, addr) : + ops->add_uc_mac_addr(hw, addr); if (ret) { err = ret; @@ -484,7 +485,7 @@ hns3vf_set_mc_mac_addr_list(struct rte_eth_dev *dev, for (i = 0; i < cur_addr_num; i++) { num = cur_addr_num - i - 1; addr = &hw->mc_addrs[num]; - ret = hns3vf_remove_mc_mac_addr(hw, addr); + ret = hw->ops.del_mc_mac_addr(hw, addr); if (ret) { rte_spinlock_unlock(&hw->lock); return ret; @@ -496,7 +497,7 @@ hns3vf_set_mc_mac_addr_list(struct rte_eth_dev *dev, set_addr_num = (int)nb_mc_addr; for (i = 0; i < set_addr_num; i++) { addr = &mc_addr_set[i]; - ret = hns3vf_add_mc_mac_addr(hw, addr); + ret = hw->ops.add_mc_mac_addr(hw, addr); if (ret) { rte_spinlock_unlock(&hw->lock); return ret; @@ -525,9 +526,9 @@ hns3vf_configure_all_mc_mac_addr(struct hns3_adapter *hns, bool del) if (!rte_is_multicast_ether_addr(addr)) continue; if (del) - ret = hns3vf_remove_mc_mac_addr(hw, addr); + ret = hw->ops.del_mc_mac_addr(hw, addr); else - ret = hns3vf_add_mc_mac_addr(hw, addr); + ret = hw->ops.add_mc_mac_addr(hw, addr); if (ret) { err = ret; hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,