diff mbox series

[v8,8/9] interrupts: rename device specific file descriptor

Message ID	20211025142712.1273-9-david.marchand@redhat.com (mailing list archive)
State	Accepted, archived
Delegated to:	David Marchand
Headers	From: David Marchand <david.marchand@redhat.com> To: hkalra@marvell.com, dev@dpdk.org Cc: dmitry.kozliuk@gmail.com, rasland@nvidia.com, thomas@monjalon.net Date: Mon, 25 Oct 2021 16:27:11 +0200 Message-Id: <20211025142712.1273-9-david.marchand@redhat.com> In-Reply-To: <20211025142712.1273-1-david.marchand@redhat.com> References: <20211022204934.132186-1-hkalra@marvell.com> <20211025142712.1273-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH v8 8/9] interrupts: rename device specific file descriptor Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	make rte_intr_handle internal \| [v8,0/9] make rte_intr_handle internal [v8,1/9] interrupts: add allocator and accessors [v8,2/9] interrupts: remove direct access to interrupt handle [v8,3/9] test/interrupts: remove direct access to interrupt handle [v8,4/9] alarm: remove direct access to interrupt handle [v8,5/9] lib: remove direct access to interrupt handle [v8,6/9] drivers: remove direct access to interrupt handle [v8,7/9] interrupts: make interrupt handle structure opaque [v8,8/9] interrupts: rename device specific file descriptor [v8,9/9] interrupts: extend event list

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

David Marchand Oct. 25, 2021, 2:27 p.m. UTC

  From: Harman Kalra <hkalra@marvell.com>

VFIO/UIO are mutually exclusive, storing file descriptor in a single
field is enough.

Signed-off-by: Harman Kalra <hkalra@marvell.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Changes since v5:
- split from patch5,

---
 lib/eal/common/eal_common_interrupts.c | 6 +++---
 lib/eal/common/eal_interrupts.h        | 8 +-------
 lib/eal/include/rte_eal_trace.h        | 8 ++++----
 3 files changed, 8 insertions(+), 14 deletions(-)

diff mbox series

Patch

diff --git a/lib/eal/common/eal_common_interrupts.c b/lib/eal/common/eal_common_interrupts.c
index 5886376d84..2146b933bb 100644
--- a/lib/eal/common/eal_common_interrupts.c
+++ b/lib/eal/common/eal_common_interrupts.c
@@ -72,7 +72,7 @@  struct rte_intr_handle *rte_intr_instance_dup(const struct rte_intr_handle *src)
 	intr_handle = rte_intr_instance_alloc(src->alloc_flags);
 
 	intr_handle->fd = src->fd;
-	intr_handle->vfio_dev_fd = src->vfio_dev_fd;
+	intr_handle->dev_fd = src->dev_fd;
 	intr_handle->type = src->type;
 	intr_handle->max_intr = src->max_intr;
 	intr_handle->nb_efd = src->nb_efd;
@@ -139,7 +139,7 @@  int rte_intr_dev_fd_set(struct rte_intr_handle *intr_handle, int fd)
 {
 	CHECK_VALID_INTR_HANDLE(intr_handle);
 
-	intr_handle->vfio_dev_fd = fd;
+	intr_handle->dev_fd = fd;
 
 	return 0;
 fail:
@@ -150,7 +150,7 @@  int rte_intr_dev_fd_get(const struct rte_intr_handle *intr_handle)
 {
 	CHECK_VALID_INTR_HANDLE(intr_handle);
 
-	return intr_handle->vfio_dev_fd;
+	return intr_handle->dev_fd;
 fail:
 	return -1;
 }
diff --git a/lib/eal/common/eal_interrupts.h b/lib/eal/common/eal_interrupts.h
index beacc04b62..1a4e5573b2 100644
--- a/lib/eal/common/eal_interrupts.h
+++ b/lib/eal/common/eal_interrupts.h
@@ -9,13 +9,7 @@  struct rte_intr_handle {
 	RTE_STD_C11
 	union {
 		struct {
-			RTE_STD_C11
-			union {
-				/** VFIO device file descriptor */
-				int vfio_dev_fd;
-				/** UIO cfg file desc for uio_pci_generic */
-				int uio_cfg_fd;
-			};
+			int dev_fd; /**< VFIO/UIO cfg device file descriptor */
 			int fd;	/**< interrupt event file descriptor */
 		};
 		void *windows_handle; /**< device driver handle */
diff --git a/lib/eal/include/rte_eal_trace.h b/lib/eal/include/rte_eal_trace.h
index af7b2d0bf0..5ef4398230 100644
--- a/lib/eal/include/rte_eal_trace.h
+++ b/lib/eal/include/rte_eal_trace.h
@@ -151,7 +151,7 @@  RTE_TRACE_POINT(
 	RTE_TRACE_POINT_ARGS(const struct rte_intr_handle *handle,
 		rte_intr_callback_fn cb, void *cb_arg, int rc),
 	rte_trace_point_emit_int(rc);
-	rte_trace_point_emit_int(handle->vfio_dev_fd);
+	rte_trace_point_emit_int(handle->dev_fd);
 	rte_trace_point_emit_int(handle->fd);
 	rte_trace_point_emit_int(handle->type);
 	rte_trace_point_emit_u32(handle->max_intr);
@@ -164,7 +164,7 @@  RTE_TRACE_POINT(
 	RTE_TRACE_POINT_ARGS(const struct rte_intr_handle *handle,
 		rte_intr_callback_fn cb, void *cb_arg, int rc),
 	rte_trace_point_emit_int(rc);
-	rte_trace_point_emit_int(handle->vfio_dev_fd);
+	rte_trace_point_emit_int(handle->dev_fd);
 	rte_trace_point_emit_int(handle->fd);
 	rte_trace_point_emit_int(handle->type);
 	rte_trace_point_emit_u32(handle->max_intr);
@@ -176,7 +176,7 @@  RTE_TRACE_POINT(
 	rte_eal_trace_intr_enable,
 	RTE_TRACE_POINT_ARGS(const struct rte_intr_handle *handle, int rc),
 	rte_trace_point_emit_int(rc);
-	rte_trace_point_emit_int(handle->vfio_dev_fd);
+	rte_trace_point_emit_int(handle->dev_fd);
 	rte_trace_point_emit_int(handle->fd);
 	rte_trace_point_emit_int(handle->type);
 	rte_trace_point_emit_u32(handle->max_intr);
@@ -186,7 +186,7 @@  RTE_TRACE_POINT(
 	rte_eal_trace_intr_disable,
 	RTE_TRACE_POINT_ARGS(const struct rte_intr_handle *handle, int rc),
 	rte_trace_point_emit_int(rc);
-	rte_trace_point_emit_int(handle->vfio_dev_fd);
+	rte_trace_point_emit_int(handle->dev_fd);
 	rte_trace_point_emit_int(handle->fd);
 	rte_trace_point_emit_int(handle->type);
 	rte_trace_point_emit_u32(handle->max_intr);