From patchwork Wed Oct 27 08:22:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xueming Li X-Patchwork-Id: 103021 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89DF7A0C45; Wed, 27 Oct 2021 10:22:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15A7C40040; Wed, 27 Oct 2021 10:22:59 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2088.outbound.protection.outlook.com [40.107.223.88]) by mails.dpdk.org (Postfix) with ESMTP id F30CE4003F; Wed, 27 Oct 2021 10:22:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PkiNGqRZN42kRPAaRJc1TGyqnU+NSw0/5o6BBpZuiZu0YyQuslILxUJGW/wGGCyjxGwrsYberts/78dmYrbT5NXOFKz0vUPXLxBvGrD1a4zeuGVgvYEzJNUFiiop3BC/WRZi+oOgj4yjPc1EKVYoxlFJussxJ5N5VP0cYCGQyf73ZDfNCe8ZEDylYoux6xhWL46QJcYqEiJtLZgKLV6GDRE1NFrBIyftvN7IZq5d3qbCFxtPOP0Ip1+KWEombnMiru9pXaYWJPv03XRhajiK22mX2OCkO474UBBbH78uabc649hQNeC1dqgGGkAp3jknSzL7NJKGkOVVIClTQw1tRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3DVlBS1RDF0VeErz9KfLNNmWqkWexACdnO/RVnADKhQ=; b=W8kJH84HEpHX2GuEdwAkACLaiv2mcZLBKZ1Jx/U/Q4Xxj7gsU0//nxDqN5sMbGhGw7LOykQWnCoGAYjDezOAwA1x4aXkNqd0Gsi/5gATRjQV2aGaxT1/pQ1/6sLmGQW0wammB+8UHW8rNeFkB+TRU/3YQ8ew32w2obCZWNzq42u4r+5AekwOTf9EZbnPIFpVioZCFuMkTbG2dxhQmPRbAkjMjo+DyvzgcaT7/tMak7XpcjQlJ/VqlGLm3yT69U3Gv8hkTRVeA74+GhHBaIaAHiwNCW7F+rfDFDBCl7giSslsNwQGgRw7QwlNQQ+leGdJSMhjxwIqYG6P2LB09IP35Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=u256.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3DVlBS1RDF0VeErz9KfLNNmWqkWexACdnO/RVnADKhQ=; b=NMF5rpkkUcTYUyy1pHDG9vOkqGwpJaWi77Zn3KL9rQDzQh7H9PvUl8D59UgskhWoHcc+Ua4F9bRYD/tUenXPTa5t4kic1uVFsDixZjb/VYj4xbUWyttcWskD4xwcXPElwQDncmPOh+7DWqcXGjsb/QYB2zX7a5V9bOsCqRtT6Yg4EUgTPmklnt/ZFOSaxV+aj0hCithyjAodD1QSLpEw/i+TDJS+LvZ98IPZbwi9jGMKr5cGIQQPp1av6SAZ8W8NY2mRUbtrV7Tz+QRKYInTqWp4JwL+FSzZ7rd7tRGzz0E1hQSHIZT6tViYMfwqvFGXaxFGqo0nx1IVpJUEhsx65Q== Received: from BN9PR03CA0173.namprd03.prod.outlook.com (2603:10b6:408:f4::28) by BN6PR12MB1778.namprd12.prod.outlook.com (2603:10b6:404:106::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 27 Oct 2021 08:22:55 +0000 Received: from BN8NAM11FT065.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f4:cafe::b0) by BN9PR03CA0173.outlook.office365.com (2603:10b6:408:f4::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend Transport; Wed, 27 Oct 2021 08:22:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; u256.net; dkim=none (message not signed) header.d=none;u256.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT065.mail.protection.outlook.com (10.13.177.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4649.14 via Frontend Transport; Wed, 27 Oct 2021 08:22:55 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 27 Oct 2021 08:22:53 +0000 From: Xueming Li To: CC: , , Gaetan Rivet , Gaetan Rivet Date: Wed, 27 Oct 2021 16:22:21 +0800 Message-ID: <20211027082221.693957-1-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc0b96a3-5eb8-4c60-f518-08d99922fa53 X-MS-TrafficTypeDiagnostic: BN6PR12MB1778: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2449; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z/uf41xwka1fG6m+W9dYQ6vcX2t0Tpv1SDuwg29G8bxInv/lQco0LARdjL46szjz3FIll0lmDeaeRhisCEUnByRceyJqXfmyxrX8d5Bq+BSnuYGUdGahfQDcG0TDI8FBZTxoNaRi6bmDNW0KpULS0SnvBmnsEUOZ+OW2uzkBnNQT64jCJ4OPJ0KR9zPkNDrE+vQi3QiRIdKDTMywhQk8bRreCopzY6yWTCEgA00r4V58OVeoflj+OpdPxPk72x+0dRHDekvgS0YQ+cKZUaiXGSP4YKlEpCgOnh/UoDw7nIXkFLGJUOiquEFRwVosVwgjssTaAdYsjr4uQOBeF02CzohPo9irowyJMTGAAmzSK4gk8Gn6APV96PhzXsB8HktunFIqXZNS4BcwB0ykNg+4U94KkcudgdCV82kZnyA72dBOQDHGQNSEtOk9THHsdrMrnFg+X0VaeV9HefJKLLt7Et/u1WtqlTp8uPQDEJKcS5DWV3rsohehnpFTsSYmbTe8sZ7BL4ziQ+OIH4naFDp2DQpzrwUdMM7n0mhneCQ8U4OKI8HDqkVwbjIZP4COTzJtSTKEHHwDr1hYSdw/mnZw0KmNRmmj5i9GgGKL3o6Ni2bZms529+JA9ZfUVfu4OANliP8MDg2Ov7+NPyO9QeC1T1keyUYMO353pOZGl3u5QdDdUr61xfqCTuNclV1ud23YzZk2qjmWMZSwvH0MzrxBRw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(356005)(36756003)(8676002)(7696005)(54906003)(186003)(426003)(336012)(6916009)(2616005)(508600001)(16526019)(6666004)(83380400001)(70586007)(70206006)(36906005)(86362001)(26005)(47076005)(316002)(55016002)(2906002)(8936002)(5660300002)(4744005)(4326008)(1076003)(7636003)(36860700001)(82310400003)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 08:22:55.5640 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc0b96a3-5eb8-4c60-f518-08d99922fa53 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT065.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1778 Subject: [dpdk-dev] [PATCH v1] eal: fix random device arguments in device iterator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Devargs used in device iterator initialization wasn't set to zero, random data like bus string lead to invalid address access. This patch initializes devargs. Fixes: c99a2d4c6b7f ("eal: implement device iteration initialization") Cc: stable@dpdk.org Cc: Gaetan Rivet Signed-off-by: Xueming Li --- lib/eal/common/eal_common_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c index 148a23830ab..e1e9976d8dc 100644 --- a/lib/eal/common/eal_common_dev.c +++ b/lib/eal/common/eal_common_dev.c @@ -573,7 +573,7 @@ int rte_dev_iterator_init(struct rte_dev_iterator *it, const char *dev_str) { - struct rte_devargs devargs; + struct rte_devargs devargs = { .bus = NULL }; struct rte_class *cls = NULL; struct rte_bus *bus = NULL;