diff mbox series

[1/2] devtools: remove ugly workaround from get maintainers

Message ID 20211101133533.3402007-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [1/2] devtools: remove ugly workaround from get maintainers |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Ferruh Yigit Nov. 1, 2021, 1:35 p.m. UTC 
  Linux kernel 'get_maintainer.pl' script supports running out of Linux
tree since commit
31bb82c9caa9 ("get_maintainer: allow usage outside of kernel tree")

As commit is a few years old now, integrating it to DPDK and removing
ugly workaround for it.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: antonio.ninodiaz@arm.com
---
 devtools/get-maintainer.sh | 26 +-------------------------
 1 file changed, 1 insertion(+), 25 deletions(-)

Comments

Thomas Monjalon Jan. 13, 2022, 11:35 a.m. UTC | #1 
01/11/2021 14:35, Ferruh Yigit:
> Linux kernel 'get_maintainer.pl' script supports running out of Linux
> tree since commit
> 31bb82c9caa9 ("get_maintainer: allow usage outside of kernel tree")
> 
> As commit is a few years old now, integrating it to DPDK and removing
> ugly workaround for it.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied without patch 2, thanks.
diff mbox series

Patch

diff --git a/devtools/get-maintainer.sh b/devtools/get-maintainer.sh
index 85740f5afd2a..bba4d3f68db8 100755
--- a/devtools/get-maintainer.sh
+++ b/devtools/get-maintainer.sh
@@ -7,7 +7,7 @@ 
 # - DPDK_GETMAINTAINER_PATH
 . $(dirname $(readlink -f $0))/load-devel-config
 
-options="--no-git-fallback"
+options="--no-tree --no-git-fallback"
 options="$options --no-rolestats"
 
 print_usage () {
@@ -31,28 +31,4 @@  if [ ! -f "$DPDK_GETMAINTAINER_PATH" ] ||
 	exit 1
 fi
 
-FILES="COPYING CREDITS Kbuild"
-FOLDERS="Documentation arch include fs init ipc scripts"
-
-# Kernel script checks for some files and folders to run
-workaround () {
-	for f in $FILES; do
-		if [ ! -f $f ]; then touch $f; fi
-	done
-
-	for d in $FOLDERS; do
-		if [ ! -d $d ]; then mkdir $d; fi
-	done
-}
-
-fix_workaround () {
-	for f in $FILES; do if [ -f $f ]; then rm -f $f; fi; done
-	for d in $FOLDERS; do if [ -d $d ]; then rmdir $d; fi; done
-}
-
-# clean workaround on exit
-trap fix_workaround EXIT
-
-workaround
 $DPDK_GETMAINTAINER_PATH $options $@
-# fix_workaround called on exit by trap