diff mbox series

app/testpmd: remove warning on flex flow flush

Message ID 20211102183848.32422-1-david.marchand@redhat.com (mailing list archive)
State Rejected, archived
Headers
Series app/testpmd: remove warning on flex flow flush |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

David Marchand Nov. 2, 2021, 6:38 p.m. UTC 
  Building DPDK without JSON, warnings get displayed when stopping testpmd
without entering any flex flow rule.

Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test-pmd/cmd_flex_item.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Gregory Etelson Nov. 2, 2021, 7:39 p.m. UTC | #1 
Hello,

I posted a patch for that issue in
https://patchwork.dpdk.org/project/dpdk/patch/20211026152000.11665-1-getelson@nvidia.com/

Regards,
Gregory

> -----Original Message-----
> From: David Marchand
> <david.marchand@redhat.com>
> Sent: Tuesday, November 2, 2021 20:39
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>;
> ferruh.yigit@intel.com; NBU-Contact-Thomas
> Monjalon <thomas@monjalon.net>; Xiaoyun Li
> <xiaoyun.li@intel.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Subject: [PATCH] app/testpmd: remove warning
> on flex flow flush
> 
> External email: Use caution opening links or
> attachments
> 
> 
> Building DPDK without JSON, warnings get
> displayed when stopping testpmd
> without entering any flex flow rule.
> 
> Fixes: 59f3a8acbcdb ("app/testpmd: add flex
> item commands")
> 
> Signed-off-by: David Marchand
> <david.marchand@redhat.com>
> ---
>  app/test-pmd/cmd_flex_item.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-pmd/cmd_flex_item.c
> b/app/test-pmd/cmd_flex_item.c
> index 45103e45a8..337dcdd565 100644
> --- a/app/test-pmd/cmd_flex_item.c
> +++ b/app/test-pmd/cmd_flex_item.c
> @@ -415,6 +415,8 @@
> port_flex_item_flush(portid_t port_id)
>         uint16_t i;
> 
>         for (i = 0; i < FLEX_MAX_PARSERS_NUM;
> i++) {
> +               if (flex_items[port_id][i] == NULL)
> +                       continue;
>                 flex_item_destroy(port_id, i);
>                 flex_items[port_id][i] = NULL;
>         }
> --
> 2.23.0
David Marchand Nov. 2, 2021, 7:44 p.m. UTC | #2 
On Tue, Nov 2, 2021 at 8:40 PM Gregory Etelson <getelson@nvidia.com> wrote:
> I posted a patch for that issue in
> https://patchwork.dpdk.org/project/dpdk/patch/20211026152000.11665-1-getelson@nvidia.com/

Ok cool, withdrawing my patch.
diff mbox series

Patch

diff --git a/app/test-pmd/cmd_flex_item.c b/app/test-pmd/cmd_flex_item.c
index 45103e45a8..337dcdd565 100644
--- a/app/test-pmd/cmd_flex_item.c
+++ b/app/test-pmd/cmd_flex_item.c
@@ -415,6 +415,8 @@  port_flex_item_flush(portid_t port_id)
 	uint16_t i;
 
 	for (i = 0; i < FLEX_MAX_PARSERS_NUM; i++) {
+		if (flex_items[port_id][i] == NULL)
+			continue;
 		flex_item_destroy(port_id, i);
 		flex_items[port_id][i] = NULL;
 	}