[v5,14/22] net/bnxt: update log messages in TruFlow path

Message ID 20211104215846.58672-15-ajit.khaparde@broadcom.com (mailing list archive)
State Accepted, archived
Delegated to: Ajit Khaparde
Headers
Series fixes and enhancements to Truflow |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Ajit Khaparde Nov. 4, 2021, 9:58 p.m. UTC
  From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>

Some of the error level log messages are made debug level messages.
When Truflow is not enabled then Truflow init error messages are
moved to debug level instead.

Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
Reviewed-by: Shahaji Bhosle <sbhosle@broadcom.com>
Reviewed-by: Mike Baucom <michael.baucom@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/tf_ulp/bnxt_ulp.c      | 24 ++++++++++++------------
 drivers/net/bnxt/tf_ulp/ulp_def_rules.c |  2 +-
 drivers/net/bnxt/tf_ulp/ulp_flow_db.c   |  2 +-
 drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c  |  2 +-
 4 files changed, 15 insertions(+), 15 deletions(-)
  

Patch

diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c
index 7deacd1f3e..21f71d6445 100644
--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c
+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c
@@ -1396,16 +1396,16 @@  bnxt_ulp_port_init(struct bnxt *bp)
 	uint32_t ulp_flags;
 	int32_t rc = 0;
 
-	if (!BNXT_PF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
-		BNXT_TF_DBG(ERR,
-			    "Skip ulp init for port: %d, not a TVF or PF\n",
+	if (!BNXT_TRUFLOW_EN(bp)) {
+		BNXT_TF_DBG(DEBUG,
+			    "Skip ulp init for port: %d, TF is not enabled\n",
 			    bp->eth_dev->data->port_id);
 		return rc;
 	}
 
-	if (!BNXT_TRUFLOW_EN(bp)) {
-		BNXT_TF_DBG(ERR,
-			    "Skip ulp init for port: %d, truflow is not enabled\n",
+	if (!BNXT_PF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
+		BNXT_TF_DBG(DEBUG,
+			    "Skip ulp init for port: %d, not a TVF or PF\n",
 			    bp->eth_dev->data->port_id);
 		return rc;
 	}
@@ -1520,16 +1520,16 @@  bnxt_ulp_port_deinit(struct bnxt *bp)
 	struct rte_pci_device *pci_dev;
 	struct rte_pci_addr *pci_addr;
 
-	if (!BNXT_PF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
-		BNXT_TF_DBG(ERR,
-			    "Skip ULP deinit port:%d, not a TVF or PF\n",
+	if (!BNXT_TRUFLOW_EN(bp)) {
+		BNXT_TF_DBG(DEBUG,
+			    "Skip ULP deinit for port:%d, TF is not enabled\n",
 			    bp->eth_dev->data->port_id);
 		return;
 	}
 
-	if (!BNXT_TRUFLOW_EN(bp)) {
-		BNXT_TF_DBG(ERR,
-			    "Skip ULP deinit for port:%d, truflow is not enabled\n",
+	if (!BNXT_PF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
+		BNXT_TF_DBG(DEBUG,
+			    "Skip ULP deinit port:%d, not a TVF or PF\n",
 			    bp->eth_dev->data->port_id);
 		return;
 	}
diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
index 01233c0f5e..8790d7ac0d 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
@@ -323,7 +323,7 @@  ulp_default_flow_create(struct rte_eth_dev *eth_dev,
 	ulp_ctx = bnxt_ulp_eth_dev_ptr2_cntxt_get(eth_dev);
 	if (!ulp_ctx) {
 		BNXT_TF_DBG(ERR,
-			    "ULP context is not initialized. Failed to create dflt flow.\n");
+			    "ULP is not init'ed. Fail to create dflt flow.\n");
 		return -EINVAL;
 	}
 
diff --git a/drivers/net/bnxt/tf_ulp/ulp_flow_db.c b/drivers/net/bnxt/tf_ulp/ulp_flow_db.c
index 79dc869e64..9968311c44 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_flow_db.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_flow_db.c
@@ -470,7 +470,7 @@  ulp_flow_db_init(struct bnxt_ulp_context *ulp_ctxt)
 	}
 
 	/* All good so return. */
-	BNXT_TF_DBG(INFO, "FlowDB initialized with %d flows.\n",
+	BNXT_TF_DBG(DEBUG, "FlowDB initialized with %d flows.\n",
 		    flow_tbl->num_flows);
 	return 0;
 error_free:
diff --git a/drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c b/drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c
index 271520e1d3..9dffaef73b 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c
@@ -116,7 +116,7 @@  ulp_mark_db_init(struct bnxt_ulp_context *ctxt)
 	mark_tbl->gfid_mask	= (mark_tbl->gfid_num_entries / 2) - 1;
 	mark_tbl->gfid_type_bit = (mark_tbl->gfid_num_entries / 2);
 
-	BNXT_TF_DBG(DEBUG, "GFID Max = 0x%08x\nGFID MASK = 0x%08x\n",
+	BNXT_TF_DBG(DEBUG, "GFID Max = 0x%08x GFID MASK = 0x%08x\n",
 		    mark_tbl->gfid_num_entries - 1,
 		    mark_tbl->gfid_mask);