diff mbox series

app: fix testpmd dependency on jansson

Message ID 20211105132951.13408-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series app: fix testpmd dependency on jansson |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

David Marchand Nov. 5, 2021, 1:29 p.m. UTC 
  ext_deps is not used in app/meson.build.
testpmd currently can be linked because metrics library is pulling
the dependency on libjansson.

Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gregory Etelson Nov. 7, 2021, 6:32 a.m. UTC | #1 
Hello David,

Thank you for the update.

Regards,
Gregory

> 
> ext_deps is not used in app/meson.build.
> testpmd currently can be linked because metrics
> library is pulling
> the dependency on libjansson.
> 
> Fixes: 59f3a8acbcdb ("app/testpmd: add flex
> item commands")
> 
> Signed-off-by: David Marchand
> <david.marchand@redhat.com>
> ---
>  app/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/meson.build b/app/meson.build
> index e41a2e3902..986c1a4ad4 100644
> --- a/app/meson.build
> +++ b/app/meson.build
> @@ -61,7 +61,7 @@ foreach app:apps
>              c_args: cflags,
>              link_args: ldflags,
>              link_whole: link_libs,
> -            dependencies: dep_objs,
> +            dependencies: ext_deps + dep_objs,

Reviewed-by: Gregory Etelson <getelson@nvidia.com>

>              include_directories: includes,
>              install_rpath:
> join_paths(get_option('prefix'),
> driver_install_path),
>              install: true)
> --
> 2.23.0
Thomas Monjalon Nov. 7, 2021, 4:19 p.m. UTC | #2 
Strictly speaking, the jansson dependency is already described,
so the fix is more about fixing the linking in general.
That's why I chose this title: "app: fix external dependency linking"

> > ext_deps is not used in app/meson.build.
> > testpmd currently can be linked because metrics
> > library is pulling
> > the dependency on libjansson.
> > 
> > Fixes: 59f3a8acbcdb ("app/testpmd: add flex
> > item commands")
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
[...]
> > --- a/app/meson.build
> > +++ b/app/meson.build
> > -            dependencies: dep_objs,
> > +            dependencies: ext_deps + dep_objs,
> 
> Reviewed-by: Gregory Etelson <getelson@nvidia.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/app/meson.build b/app/meson.build
index e41a2e3902..986c1a4ad4 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -61,7 +61,7 @@  foreach app:apps
             c_args: cflags,
             link_args: ldflags,
             link_whole: link_libs,
-            dependencies: dep_objs,
+            dependencies: ext_deps + dep_objs,
             include_directories: includes,
             install_rpath: join_paths(get_option('prefix'), driver_install_path),
             install: true)