diff mbox series

[1/2] app/testpmd: remove unneeded dependency on meter

Message ID 20211105133018.13584-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [1/2] app/testpmd: remove unneeded dependency on meter |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

David Marchand Nov. 5, 2021, 1:30 p.m. UTC 
  testpmd depends on ethdev, which itself depends on meter.
No need for an explicit dependency, since no testpmd code directly calls
in the meter library.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test-pmd/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Richardson Nov. 5, 2021, 1:40 p.m. UTC | #1 
On Fri, Nov 05, 2021 at 02:30:17PM +0100, David Marchand wrote:
> testpmd depends on ethdev, which itself depends on meter.
> No need for an explicit dependency, since no testpmd code directly calls
> in the meter library.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Ferruh Yigit Nov. 5, 2021, 11:54 p.m. UTC | #2 
On 11/5/2021 1:40 PM, Bruce Richardson wrote:
> On Fri, Nov 05, 2021 at 02:30:17PM +0100, David Marchand wrote:
>> testpmd depends on ethdev, which itself depends on meter.
>> No need for an explicit dependency, since no testpmd code directly calls
>> in the meter library.
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
index b5a0f7b620..21d50e92d0 100644
--- a/app/test-pmd/meson.build
+++ b/app/test-pmd/meson.build
@@ -28,7 +28,7 @@  sources = files(
         'util.c',
 )
 
-deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'meter', 'bus_pci']
+deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci']
 if dpdk_conf.has('RTE_LIB_BITRATESTATS')
     deps += 'bitratestats'
 endif