diff mbox series

[2/2] app/testpmd: remove double dependency on bitrate

Message ID 20211105133018.13584-2-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [1/2] app/testpmd: remove unneeded dependency on meter |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

David Marchand Nov. 5, 2021, 1:30 p.m. UTC 
  No need for double dependency, once is enough.
While at it, sort alphabetically.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test-pmd/meson.build | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

Comments

Ferruh Yigit Nov. 5, 2021, 11:55 p.m. UTC | #1 
On 11/5/2021 1:30 PM, David Marchand wrote:
> No need for double dependency, once is enough.
> While at it, sort alphabetically.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

     Fixes: fac83b3ef8ac ("app: fix missing dependencies")
     Cc: stable@dpdk.org

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
index 21d50e92d0..b05c531c7f 100644
--- a/app/test-pmd/meson.build
+++ b/app/test-pmd/meson.build
@@ -29,20 +29,21 @@  sources = files(
 )
 
 deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci']
-if dpdk_conf.has('RTE_LIB_BITRATESTATS')
-    deps += 'bitratestats'
-endif
-if dpdk_conf.has('RTE_LIB_PDUMP')
-    deps += 'pdump'
+if dpdk_conf.has('RTE_CRYPTO_SCHEDULER')
+    deps += 'crypto_scheduler'
 endif
 if dpdk_conf.has('RTE_LIB_BITRATESTATS')
     deps += 'bitratestats'
 endif
+if dpdk_conf.has('RTE_LIB_BPF')
+    sources += files('bpf_cmd.c')
+    deps += 'bpf'
+endif
 if dpdk_conf.has('RTE_LIB_LATENCYSTATS')
     deps += 'latencystats'
 endif
-if dpdk_conf.has('RTE_CRYPTO_SCHEDULER')
-    deps += 'crypto_scheduler'
+if dpdk_conf.has('RTE_LIB_PDUMP')
+    deps += 'pdump'
 endif
 if dpdk_conf.has('RTE_NET_BOND')
     deps += 'net_bond'
@@ -59,10 +60,6 @@  endif
 if dpdk_conf.has('RTE_NET_DPAA')
     deps += ['bus_dpaa', 'mempool_dpaa', 'net_dpaa']
 endif
-if dpdk_conf.has('RTE_LIB_BPF')
-    sources += files('bpf_cmd.c')
-    deps += 'bpf'
-endif
 jansson_dep = dependency('jansson', required: false, method: 'pkg-config')
 if jansson_dep.found()
     dpdk_conf.set('RTE_HAS_JANSSON', 1)