diff mbox series

ethdev: fix device capability to string translation

Message ID 20211109090058.1879428-1-dkozlyuk@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series ethdev: fix device capability to string translation |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS

Commit Message

Dmitry Kozlyuk Nov. 9, 2021, 9 a.m. UTC 
  Add support for RTE_ETH_DEV_CAPA_FLOW_{RULE,SHARED_OBJECT}_KEEP
to rte_eth_dev_capability_name(), missed when adding the capabilities.

Fixes: 1d5a3d68c0f9 ("ethdev: add capability to keep flow rules on restart")
Fixes: 2c9cd45de7e6 ("ethdev: add capability to keep shared objects on restart")

Reported-by: Ali Alnubani <alialnu@nvidia.com>
Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Acked-by: Xueming Li <xuemingl@nvidia.com>
---
P.S. I don't know a good way to catch such errors in the future
     except by a unit test, but adding a new suite for ethdev
     seems worthy of its own patch (if needed at all).

 lib/ethdev/rte_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ali Alnubani Nov. 9, 2021, 11:56 a.m. UTC | #1 
> -----Original Message-----
> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Sent: Tuesday, November 9, 2021 11:01 AM
> To: dev@dpdk.org
> Cc: Ali Alnubani <alialnu@nvidia.com>; Xueming(Steven) Li
> <xuemingl@nvidia.com>; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>; Ferruh Yigit <ferruh.yigit@intel.com>; Andrew
> Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Subject: [PATCH] ethdev: fix device capability to string translation
> 
> Add support for RTE_ETH_DEV_CAPA_FLOW_{RULE,SHARED_OBJECT}_KEEP
> to rte_eth_dev_capability_name(), missed when adding the capabilities.
> 
> Fixes: 1d5a3d68c0f9 ("ethdev: add capability to keep flow rules on restart")
> Fixes: 2c9cd45de7e6 ("ethdev: add capability to keep shared objects on
> restart")
> 
> Reported-by: Ali Alnubani <alialnu@nvidia.com>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Xueming Li <xuemingl@nvidia.com>
> ---
> P.S. I don't know a good way to catch such errors in the future
>      except by a unit test, but adding a new suite for ethdev
>      seems worthy of its own patch (if needed at all).
> 

Tested-by: Ali Alnubani <alialnu@nvidia.com>

Thanks,
Ali
Ferruh Yigit Nov. 9, 2021, 6:43 p.m. UTC | #2 
On 11/9/2021 11:56 AM, Ali Alnubani wrote:
>> -----Original Message-----
>> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
>> Sent: Tuesday, November 9, 2021 11:01 AM
>> To: dev@dpdk.org
>> Cc: Ali Alnubani <alialnu@nvidia.com>; Xueming(Steven) Li
>> <xuemingl@nvidia.com>; NBU-Contact-Thomas Monjalon
>> <thomas@monjalon.net>; Ferruh Yigit <ferruh.yigit@intel.com>; Andrew
>> Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> Subject: [PATCH] ethdev: fix device capability to string translation
>>
>> Add support for RTE_ETH_DEV_CAPA_FLOW_{RULE,SHARED_OBJECT}_KEEP
>> to rte_eth_dev_capability_name(), missed when adding the capabilities.
>>
>> Fixes: 1d5a3d68c0f9 ("ethdev: add capability to keep flow rules on restart")
>> Fixes: 2c9cd45de7e6 ("ethdev: add capability to keep shared objects on
>> restart")
>>
>> Reported-by: Ali Alnubani <alialnu@nvidia.com>
>> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
>> Acked-by: Xueming Li <xuemingl@nvidia.com>
> 
> Tested-by: Ali Alnubani <alialnu@nvidia.com>
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 8e679e4003..a1d475a292 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -171,6 +171,8 @@  static const struct {
 	{RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP, "RUNTIME_RX_QUEUE_SETUP"},
 	{RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP, "RUNTIME_TX_QUEUE_SETUP"},
 	{RTE_ETH_DEV_CAPA_RXQ_SHARE, "RXQ_SHARE"},
+	{RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP, "FLOW_RULE_KEEP"},
+	{RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP, "FLOW_SHARED_OBJECT_KEEP"},
 };
 
 /**