From patchwork Wed Nov 10 13:05:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Slava Ovsiienko X-Patchwork-Id: 104116 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51A18A034F; Wed, 10 Nov 2021 14:06:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EBF24068B; Wed, 10 Nov 2021 14:06:15 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2084.outbound.protection.outlook.com [40.107.93.84]) by mails.dpdk.org (Postfix) with ESMTP id AFD4240683; Wed, 10 Nov 2021 14:06:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jKD0gR5pkCz3Z/rt+XZyVKAbbcXWQ4ch0bqy9Zw9ca9bTtA2jCKN3PcK0BO6lfipXOTBuo577v4QuI+gEbBnRAZfBwqBLyrau2suoTtzXzK4PFSILZlUuVLgVPXJVT+FyjnPyerqyfwWWNpl3ocrp81Wmd7ZYp+LBKCenNtITktSSybrLgTMBjRGVre730EFL/Cm2LieFYC0voNlco3ri78iyAwXqoqolipKgKn11i5+p5ptmaNBx2gaRInZ/FQdRQg3kieLr6ftEgYbh0ZB0bR+IQU5TgLyF/TKyXOmzSgDh2Ore9er7/sx/O8k5myiyfbNY8gZCLh7a+mda3hnew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQ5i4kklsxqdBg3D4yExD/mnPoSfUVVpCzIXQqUv1cM=; b=Iz/GH+pLawBiCJiFy28oxeSM+1wEEJg2BhLI9lW057VcPlWYpDdQztbZwxrguLQOyrHj9W7f3d9YQSny1lFLUNFfrdH2HeTl2msyKEXU7GrdPbIx6XIjVx3lRP0DVgR7irQ5/XhrEKNJ6E722pF2yCh4wpPrIs3z5asgXbSgB8bc0zsToDQrVigoocDanG2/s2clMQ2HgVnhYiDa+tisBkD7z+GN1LsU58D30peCJDB8wXfPC/91UNzOJtHQk8ZvXPAjEArecrzqjxQuae4+y+JjEpO2XlV3rBzKrK6LPCa8mLYcI4inJfCUynQ1Ye8/eNLAl9sCFsEOgeALF27lyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQ5i4kklsxqdBg3D4yExD/mnPoSfUVVpCzIXQqUv1cM=; b=qO7RsWWWMROEikG9AXnSlQCb3gyMkuwIYhoABhuWmj5L6xQtu+XCkEIkce8zMTzmadMdDpc5tCvfn1zgiD8JTSPxYOv1a/HIAdjL8tQRimLj/OA8vPn7nmrlvPlvtNakhuv55uijClqZs7AyA2Y7TIJm/x6otvadl/UjUZqgpRjydIVRgAhKnT+aCtq3aka5+erwf43AgESfShU34q1xFUHN9cjqlpBuW2SEow1oUogLROvklDhrYVntJL/rgAt5jmRbGguwWrn6tRfgC8cf8DxLVw4iujr8iXoOIwEtQR4bGd+MT2Wpor00liWqL3s9hCCBbQzFVHXwHrnDOpavSg== Received: from BN6PR1201CA0015.namprd12.prod.outlook.com (2603:10b6:405:4c::25) by DM6PR12MB4466.namprd12.prod.outlook.com (2603:10b6:5:2ae::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.17; Wed, 10 Nov 2021 13:06:11 +0000 Received: from BN8NAM11FT003.eop-nam11.prod.protection.outlook.com (2603:10b6:405:4c:cafe::20) by BN6PR1201CA0015.outlook.office365.com (2603:10b6:405:4c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Wed, 10 Nov 2021 13:06:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT003.mail.protection.outlook.com (10.13.177.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 13:06:10 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 13:06:08 +0000 From: Viacheslav Ovsiienko To: CC: , , Date: Wed, 10 Nov 2021 15:05:52 +0200 Message-ID: <20211110130552.8911-1-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1c69dff9-9a48-4f89-2239-08d9a44ade26 X-MS-TrafficTypeDiagnostic: DM6PR12MB4466: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YUfxegJolSIQ/NkKD5rD9k5xp1x6Zd3idCKl/a/VAl1LcYDeaGK+G93ozyRpuCYLCRJwhlPyXNbej2IJSLCBg6fe/wvX7je4qMelL6FB95SDPWXxwRB+x1tLB0cqh1Ez3rvwg7Am0oVmi1CXrLELOMjRIo7JxqqI3TGy44S0P+ddmOwwDlq6twknD2ORtBCZv3/7PzFxQkm2I+PDv0QCblX03vr9Syw1n1MhdH+HIphn/yBQ1DoL6qkMAOOeeYlk79eiuX9W/GyARx+fV/Rmkprd7TEw9PYJYiShmbgCQLiBqMmqha0grDW7sT+uGZLiiu1a0t9TDbm9F+zC2dORMwy5BSkfiMGV8eum6phB7YyM14saaGlifYIJkBqVD6twFJFKTGz+Iu+f4IXTi0KREJq1PUKKzJNUkZ08aY7BwVMW7sggT3g8lr11eUQOzlPyS0TbjWlLIy7jvHcPRFo3ZfsqNSK1CkeCUTBGtbqaWbRZ4a8aHmrfrEh0d7iwVrVscgjgen+/tr/dUvMdcVwfVczzgc2IzLptyt4CfIf7+F/SOA74J9Jxc8C7Uz9X59efjJpfC7I/iNBtFD5dfoQKBNC/o07jyPSCgU/woW6jCAqXMkaZ/uWtVfC0tzgbMSv0Mt7nYhFWMr73VkodlUA6xdg671nLXUP4fGks04Iod/n5Uv5lYtN+dxQ/PGVjRlW/USyNoToTAUm6v5Nz/tMi2A== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(5660300002)(2906002)(7696005)(4326008)(36860700001)(6916009)(356005)(8936002)(36756003)(7636003)(54906003)(47076005)(55016002)(6666004)(450100002)(82310400003)(4744005)(1076003)(316002)(70206006)(26005)(70586007)(2616005)(36906005)(6286002)(186003)(16526019)(8676002)(336012)(83380400001)(86362001)(426003)(508600001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 13:06:10.9473 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c69dff9-9a48-4f89-2239-08d9a44ade26 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT003.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4466 Subject: [dpdk-dev] [PATCH] net/mlx5: fix add Tx scheduling check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There was the redundant check for the enabled E-Switch, this resulted in device probing failure if the Tx scheduling was requested and E-Switch was enabled. Fixes: f17e4b4ffef9 ("net/mlx5: add Tx scheduling check on queue creation") Cc: stable@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index de880ee4c9..c29fe3d92b 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -1727,8 +1727,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, priv->obj_ops = ibv_obj_ops; } if (config->tx_pp && - (priv->config.dv_esw_en || - priv->obj_ops.txq_obj_new != mlx5_txq_devx_obj_new)) { + priv->obj_ops.txq_obj_new != mlx5_txq_devx_obj_new) { /* * HAVE_MLX5DV_DEVX_UAR_OFFSET is required to support * packet pacing and already checked above.