diff mbox series

[v2] net/iavf: fix pointer of meter data

Message ID 20211111063147.1596-1-alvinx.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series [v2] net/iavf: fix pointer of meter data |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS

Commit Message

Alvin Zhang Nov. 11, 2021, 6:31 a.m. UTC 
  This patch fixes coverity issue by directly passing the address
of the meter data to lower function.

Coverity issue: 373867

Fixes: 91f27b2e39ab ("net/iavf: refactor RSS")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
 drivers/net/iavf/iavf_hash.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Qi Zhang Nov. 11, 2021, 1:12 p.m. UTC | #1 
> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Thursday, November 11, 2021 2:32 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/iavf: fix pointer of meter data

s/meter/meta

> 
> This patch fixes coverity issue by directly passing the address of the meter data
> to lower function.
> 
> Coverity issue: 373867
> 
> Fixes: 91f27b2e39ab ("net/iavf: refactor RSS")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
Ferruh Yigit Nov. 11, 2021, 5:21 p.m. UTC | #2 
On 11/11/2021 6:31 AM, Alvin Zhang wrote:
> This patch fixes coverity issue by directly passing the address
> of the meter data to lower function.
> 
> Coverity issue: 373867
> 
> Fixes: 91f27b2e39ab ("net/iavf: refactor RSS")

As far as I can see fixed commit is:
Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")

I will update in the next-net, can you please double check?

> Cc: stable@dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
>   drivers/net/iavf/iavf_hash.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
> index 55d8a11..5e0888e 100644
> --- a/drivers/net/iavf/iavf_hash.c
> +++ b/drivers/net/iavf/iavf_hash.c
> @@ -1261,10 +1261,9 @@ struct rss_attr_type {
>   static int
>   iavf_hash_parse_action(struct iavf_pattern_match_item *match_item,
>   		       const struct rte_flow_action actions[],
> -		       uint64_t pattern_hint, void **meta,
> +		       uint64_t pattern_hint, struct iavf_rss_meta *rss_meta,
>   		       struct rte_flow_error *error)
>   {
> -	struct iavf_rss_meta *rss_meta = (struct iavf_rss_meta *)*meta;
>   	struct virtchnl_proto_hdrs *proto_hdrs;
>   	enum rte_flow_action_type action_type;
>   	const struct rte_flow_action_rss *rss;
> @@ -1378,7 +1377,7 @@ struct rss_attr_type {
>   		goto error;
>   
>   	ret = iavf_hash_parse_action(pattern_match_item, actions, phint,
> -				     (void **)&rss_meta_ptr, error);
> +				     rss_meta_ptr, error);
>   
>   error:
>   	if (!ret && meta)
>
Qi Zhang Nov. 11, 2021, 11:53 p.m. UTC | #3 
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Friday, November 12, 2021 1:21 AM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [PATCH v2] net/iavf: fix pointer of meter data
> 
> On 11/11/2021 6:31 AM, Alvin Zhang wrote:
> > This patch fixes coverity issue by directly passing the address of the
> > meter data to lower function.
> >
> > Coverity issue: 373867
> >
> > Fixes: 91f27b2e39ab ("net/iavf: refactor RSS")
> 
> As far as I can see fixed commit is:
> Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")

+1，this should be the patch that bring the issue, thanks.

> 
> I will update in the next-net, can you please double check?
> 
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> > ---
> >   drivers/net/iavf/iavf_hash.c | 5 ++---
> >   1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/iavf/iavf_hash.c
> > b/drivers/net/iavf/iavf_hash.c index 55d8a11..5e0888e 100644
> > --- a/drivers/net/iavf/iavf_hash.c
> > +++ b/drivers/net/iavf/iavf_hash.c
> > @@ -1261,10 +1261,9 @@ struct rss_attr_type {
> >   static int
> >   iavf_hash_parse_action(struct iavf_pattern_match_item *match_item,
> >   		       const struct rte_flow_action actions[],
> > -		       uint64_t pattern_hint, void **meta,
> > +		       uint64_t pattern_hint, struct iavf_rss_meta *rss_meta,
> >   		       struct rte_flow_error *error)
> >   {
> > -	struct iavf_rss_meta *rss_meta = (struct iavf_rss_meta *)*meta;
> >   	struct virtchnl_proto_hdrs *proto_hdrs;
> >   	enum rte_flow_action_type action_type;
> >   	const struct rte_flow_action_rss *rss; @@ -1378,7 +1377,7 @@ struct
> > rss_attr_type {
> >   		goto error;
> >
> >   	ret = iavf_hash_parse_action(pattern_match_item, actions, phint,
> > -				     (void **)&rss_meta_ptr, error);
> > +				     rss_meta_ptr, error);
> >
> >   error:
> >   	if (!ret && meta)
> >
diff mbox series

Patch

diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
index 55d8a11..5e0888e 100644
--- a/drivers/net/iavf/iavf_hash.c
+++ b/drivers/net/iavf/iavf_hash.c
@@ -1261,10 +1261,9 @@  struct rss_attr_type {
 static int
 iavf_hash_parse_action(struct iavf_pattern_match_item *match_item,
 		       const struct rte_flow_action actions[],
-		       uint64_t pattern_hint, void **meta,
+		       uint64_t pattern_hint, struct iavf_rss_meta *rss_meta,
 		       struct rte_flow_error *error)
 {
-	struct iavf_rss_meta *rss_meta = (struct iavf_rss_meta *)*meta;
 	struct virtchnl_proto_hdrs *proto_hdrs;
 	enum rte_flow_action_type action_type;
 	const struct rte_flow_action_rss *rss;
@@ -1378,7 +1377,7 @@  struct rss_attr_type {
 		goto error;
 
 	ret = iavf_hash_parse_action(pattern_match_item, actions, phint,
-				     (void **)&rss_meta_ptr, error);
+				     rss_meta_ptr, error);
 
 error:
 	if (!ret && meta)