From patchwork Fri Nov 12 14:01:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Walsh X-Patchwork-Id: 104246 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97C2CA034F; Fri, 12 Nov 2021 15:02:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87CF141142; Fri, 12 Nov 2021 15:02:26 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 2F61A410EA for ; Fri, 12 Nov 2021 15:02:25 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10165"; a="232978982" X-IronPort-AV: E=Sophos;i="5.87,229,1631602800"; d="scan'208";a="232978982" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2021 06:02:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,229,1631602800"; d="scan'208";a="493013539" Received: from silpixa00401160.ir.intel.com ([10.55.129.96]) by orsmga007.jf.intel.com with ESMTP; 12 Nov 2021 06:02:14 -0800 From: Conor Walsh To: ferruh.yigit@intel.com, david.marchand@redhat.com, longfengx.liang@intel.com, dev@dpdk.org Cc: david.hunt@intel.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, vladimir.medvedkin@intel.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, fiona.trahe@intel.com, john.griffin@intel.com, deepak.k.jain@intel.com, harry.van.haaren@intel.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, sthotton@marvell.com, srinivasan@marvell.com, heinrich.kuhn@corigine.com, hkalra@marvell.com, rmody@marvell.com, dsinghrawat@marvell.com, jiawenwu@trustnetic.com, yongwang@vmware.com, john.mcnamara@intel.com, shreyansh.jain@nxp.com, santosh.shukla@caviumnetworks.com, gakhil@marvell.com, roy.fan.zhang@intel.com, arkadiuszx.kusztal@intel.com, michael.baucom@broadcom.com, venkatkumar.duvvuru@broadcom.com, lance.richardson@broadcom.com, kishore.padmanabha@broadcom.com, jerin.jacob@caviumnetworks.com, derek.chickles@caviumnetworks.com, ssrinivasan@caviumnetworks.com, mjatharakonda@oneconvergence.com, simon.horman@corigine.com, david.george@sophos.com, sony.chacko@qlogic.com, harish.patil@qlogic.com, stephen@networkplumber.org, tomaszx.kulasek@intel.com, ian.betts@intel.com, liang.j.ma@intel.com, lei.a.yao@intel.com, Conor Walsh Subject: [PATCH 6/7] examples/performance-thread: fix unused but set variables Date: Fri, 12 Nov 2021 14:01:10 +0000 Message-Id: <20211112140111.922171-7-conor.walsh@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211112140111.922171-1-conor.walsh@intel.com> References: <20211112140111.922171-1-conor.walsh@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch removes the hits variable from the cpu_load_collector function within the performance thread example app as it is an unused but set variable. Bugzilla ID: 881 Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app") Signed-off-by: Conor Walsh Reported-by: Liang Longfeng --- examples/performance-thread/l3fwd-thread/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index 3a6a33bda3..8a35040597 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -1885,7 +1885,6 @@ process_burst(struct rte_mbuf *pkts_burst[MAX_PKT_BURST], int nb_rx, static int __rte_noreturn cpu_load_collector(__rte_unused void *arg) { unsigned i, j, k; - uint64_t hits; uint64_t prev_tsc, diff_tsc, cur_tsc; uint64_t total[MAX_CPU] = { 0 }; unsigned min_cpu = MAX_CPU; @@ -1972,12 +1971,10 @@ cpu_load_collector(__rte_unused void *arg) { printf("cpu# proc%% poll%% overhead%%\n\n"); for (i = min_cpu; i <= max_cpu; i++) { - hits = 0; printf("CPU %d:", i); for (j = 0; j < MAX_CPU_COUNTER; j++) { printf("%7" PRIu64 "", cpu_load.hits[j][i] * 100 / cpu_load.counter); - hits += cpu_load.hits[j][i]; cpu_load.hits[j][i] = 0; } printf("%7" PRIu64 "\n",