event/dlb2: fix delayed_pop test in dlb2_selftest
Checks
Commit Message
Number of events scheduled and available for dequeue
after token pop was set to dequeue_depth-1 instead of
dequeue_depth in test_delayed_pop. The expectation is
that all dequeue_depth number of events can be dequeued
once the last event is released.
Signed-off-by: Rashmi Shetty <rashmi.shetty@intel.com>
---
drivers/event/dlb2/dlb2_selftest.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
Comments
> -----Original Message-----
> From: Shetty, Rashmi <rashmi.shetty@intel.com>
> Sent: Friday, November 12, 2021 2:49 PM
> To: dev@dpdk.org
> Cc: jerinj@marvell.com; Van Haaren, Harry <harry.van.haaren@intel.com>; Pathak, Pravin
> <pravin.pathak@intel.com>; Chen, Mike Ximing <mike.ximing.chen@intel.com>; McDaniel, Timothy
> <timothy.mcdaniel@intel.com>; Shetty, Rashmi <rashmi.shetty@intel.com>
> Subject: [PATCH] event/dlb2: fix delayed_pop test in dlb2_selftest
>
> Number of events scheduled and available for dequeue after token pop was set to dequeue_depth-1
> instead of dequeue_depth in test_delayed_pop. The expectation is that all dequeue_depth number of
> events can be dequeued once the last event is released.
>
> Signed-off-by: Rashmi Shetty <rashmi.shetty@intel.com>
> ---
> drivers/event/dlb2/dlb2_selftest.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/event/dlb2/dlb2_selftest.c b/drivers/event/dlb2/dlb2_selftest.c
> index 5cf66c552c..2113bc2c99 100644
> --- a/drivers/event/dlb2/dlb2_selftest.c
> +++ b/drivers/event/dlb2/dlb2_selftest.c
> @@ -1354,7 +1354,7 @@ test_delayed_pop(void)
> }
>
> /* Release one more event. This will trigger the token pop, and
> - * dequeue_depth - 1 more events will be scheduled to the device.
> + * dequeue_depth more events will be scheduled to the device.
> */
> ev.op = RTE_EVENT_OP_RELEASE;
>
> @@ -1366,7 +1366,7 @@ test_delayed_pop(void)
>
> timeout = 0xFFFFFFFFF;
>
> - for (i = 0; i < port_conf.dequeue_depth - 1; i++) {
> + for (i = 0; i < port_conf.dequeue_depth; i++) {
> if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) != 1) {
> printf("%d: event dequeue expected to succeed\n",
> __LINE__);
> @@ -1374,14 +1374,6 @@ test_delayed_pop(void)
> }
> }
>
> - timeout = 0x10000;
> -
> - if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) != 0) {
> - printf("%d: event dequeue expected to fail\n",
> - __LINE__);
> - goto err;
> - }
> -
> cleanup();
> return 0;
>
> --
> 2.25.1
Looks good.
Reviewed-by: Mike Ximing Chen <mike.ximing.chen@intel.con>
On Sat, Nov 13, 2021 at 2:33 AM Chen, Mike Ximing
<mike.ximing.chen@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Shetty, Rashmi <rashmi.shetty@intel.com>
> > Sent: Friday, November 12, 2021 2:49 PM
> > To: dev@dpdk.org
> > Cc: jerinj@marvell.com; Van Haaren, Harry <harry.van.haaren@intel.com>; Pathak, Pravin
> > <pravin.pathak@intel.com>; Chen, Mike Ximing <mike.ximing.chen@intel.com>; McDaniel, Timothy
> > <timothy.mcdaniel@intel.com>; Shetty, Rashmi <rashmi.shetty@intel.com>
> > Subject: [PATCH] event/dlb2: fix delayed_pop test in dlb2_selftest
> >
> > Number of events scheduled and available for dequeue after token pop was set to dequeue_depth-1
> > instead of dequeue_depth in test_delayed_pop. The expectation is that all dequeue_depth number of
> > events can be dequeued once the last event is released.
> >
> > Signed-off-by: Rashmi Shetty <rashmi.shetty@intel.com>
> > ---
> > drivers/event/dlb2/dlb2_selftest.c | 12 ++----------
> > 1 file changed, 2 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/event/dlb2/dlb2_selftest.c b/drivers/event/dlb2/dlb2_selftest.c
> > index 5cf66c552c..2113bc2c99 100644
> > --- a/drivers/event/dlb2/dlb2_selftest.c
> > +++ b/drivers/event/dlb2/dlb2_selftest.c
> > @@ -1354,7 +1354,7 @@ test_delayed_pop(void)
> > }
> >
> > /* Release one more event. This will trigger the token pop, and
> > - * dequeue_depth - 1 more events will be scheduled to the device.
> > + * dequeue_depth more events will be scheduled to the device.
> > */
> > ev.op = RTE_EVENT_OP_RELEASE;
> >
> > @@ -1366,7 +1366,7 @@ test_delayed_pop(void)
> >
> > timeout = 0xFFFFFFFFF;
> >
> > - for (i = 0; i < port_conf.dequeue_depth - 1; i++) {
> > + for (i = 0; i < port_conf.dequeue_depth; i++) {
> > if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) != 1) {
> > printf("%d: event dequeue expected to succeed\n",
> > __LINE__);
> > @@ -1374,14 +1374,6 @@ test_delayed_pop(void)
> > }
> > }
> >
> > - timeout = 0x10000;
> > -
> > - if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) != 0) {
> > - printf("%d: event dequeue expected to fail\n",
> > - __LINE__);
> > - goto err;
> > - }
> > -
> > cleanup();
> > return 0;
> >
> > --
> > 2.25.1
>
> Looks good.
> Reviewed-by: Mike Ximing Chen <mike.ximing.chen@intel.con>
Please fix
[for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
Wrong headline format:
event/dlb2: fix delayed_pop test in dlb2_selftest
Missing 'Fixes' tag:
event/dlb2: fix delayed_pop test in dlb2_selftest
@@ -1354,7 +1354,7 @@ test_delayed_pop(void)
}
/* Release one more event. This will trigger the token pop, and
- * dequeue_depth - 1 more events will be scheduled to the device.
+ * dequeue_depth more events will be scheduled to the device.
*/
ev.op = RTE_EVENT_OP_RELEASE;
@@ -1366,7 +1366,7 @@ test_delayed_pop(void)
timeout = 0xFFFFFFFFF;
- for (i = 0; i < port_conf.dequeue_depth - 1; i++) {
+ for (i = 0; i < port_conf.dequeue_depth; i++) {
if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) != 1) {
printf("%d: event dequeue expected to succeed\n",
__LINE__);
@@ -1374,14 +1374,6 @@ test_delayed_pop(void)
}
}
- timeout = 0x10000;
-
- if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) != 0) {
- printf("%d: event dequeue expected to fail\n",
- __LINE__);
- goto err;
- }
-
cleanup();
return 0;