| Message ID | 20211116094205.750359-13-joyce.kong@arm.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Marchand |
| Headers | show |
| Series | use compiler atomic builtins for app modules | expand |
| Context | Check | Description |
|---|---|---|
| ci/iol-aarch64-compile-testing | success | Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-aarch64-unit-testing | success | Testing PASS |
| ci/iol-x86_64-unit-testing | success | Testing PASS |
| ci/iol-x86_64-compile-testing | success | Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/github-robot: build | success | github build: passed |
| ci/intel-Testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/checkpatch | success | coding style OK |
On Tue, Nov 16, 2021 at 10:44 AM Joyce Kong <joyce.kong@arm.com> wrote: > > Remove the unnecessary rte_atomic.h included in app modules. > > Signed-off-by: Joyce Kong <joyce.kong@arm.com> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> After patch, I still see: $ git grep rte_atomic.h app/ app/test/commands.c:#include <rte_atomic.h> app/test/test_atomic.c:#include <rte_atomic.h> app/test/test_event_timer_adapter.c:#include <rte_atomic.h> I can undertand why the test_atomic would depend on rte_atomic.h :-) but not the rest. Is there a reason? or is it just a miss?
<snip> > Subject: Re: [PATCH v2 12/12] app: remove unnecessary include of atomic > header file > > On Tue, Nov 16, 2021 at 10:44 AM Joyce Kong <joyce.kong@arm.com> wrote: > > > > Remove the unnecessary rte_atomic.h included in app modules. > > > > Signed-off-by: Joyce Kong <joyce.kong@arm.com> > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > > After patch, I still see: > > $ git grep rte_atomic.h app/ > app/test/commands.c:#include <rte_atomic.h> > app/test/test_atomic.c:#include <rte_atomic.h> > app/test/test_event_timer_adapter.c:#include <rte_atomic.h> > > I can undertand why the test_atomic would depend on rte_atomic.h :-) but > not the rest. > Is there a reason? or is it just a miss? > > -- > David Marchand Hi David, I checked the rest and it was a miss. Thanks for the remind, would update in v3. Joyce
diff --git a/app/proc-info/main.c b/app/proc-info/main.c index a4271047e6..ebe2d77264 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -27,7 +27,6 @@ #include <rte_per_lcore.h> #include <rte_lcore.h> #include <rte_log.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_string_fns.h> #include <rte_metrics.h> diff --git a/app/test-pipeline/config.c b/app/test-pipeline/config.c index 33f3f1c827..daf838948b 100644 --- a/app/test-pipeline/config.c +++ b/app/test-pipeline/config.c @@ -21,7 +21,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_launch.h> -#include <rte_atomic.h> #include <rte_cycles.h> #include <rte_prefetch.h> #include <rte_lcore.h> diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c index c738019041..eee0719b67 100644 --- a/app/test-pipeline/init.c +++ b/app/test-pipeline/init.c @@ -21,7 +21,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_launch.h> -#include <rte_atomic.h> #include <rte_cycles.h> #include <rte_prefetch.h> #include <rte_lcore.h> diff --git a/app/test-pipeline/main.c b/app/test-pipeline/main.c index 72e4797ff2..1e16794183 100644 --- a/app/test-pipeline/main.c +++ b/app/test-pipeline/main.c @@ -22,7 +22,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_launch.h> -#include <rte_atomic.h> #include <rte_cycles.h> #include <rte_prefetch.h> #include <rte_lcore.h> diff --git a/app/test-pipeline/runtime.c b/app/test-pipeline/runtime.c index 159192bcd8..d939a85d7e 100644 --- a/app/test-pipeline/runtime.c +++ b/app/test-pipeline/runtime.c @@ -21,7 +21,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_launch.h> -#include <rte_atomic.h> #include <rte_cycles.h> #include <rte_prefetch.h> #include <rte_branch_prediction.h> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 4f51b259fe..4e93f535ff 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -24,7 +24,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_ring.h> #include <rte_mempool.h> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 26cadf39f7..d8b5032b58 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -27,7 +27,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_mempool.h> #include <rte_mbuf.h> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 8526d9158a..e0b00abe8c 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -24,7 +24,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_mempool.h> #include <rte_mbuf.h> diff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c index 5737eaa105..9ceef3b54a 100644 --- a/app/test-pmd/flowgen.c +++ b/app/test-pmd/flowgen.c @@ -24,7 +24,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_mempool.h> #include <rte_mbuf.h> diff --git a/app/test-pmd/icmpecho.c b/app/test-pmd/icmpecho.c index 8f1d68a83a..3a85ec3dd1 100644 --- a/app/test-pmd/icmpecho.c +++ b/app/test-pmd/icmpecho.c @@ -20,7 +20,6 @@ #include <rte_cycles.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_memory.h> #include <rte_mempool.h> diff --git a/app/test-pmd/iofwd.c b/app/test-pmd/iofwd.c index 83d098adcb..19cd920f70 100644 --- a/app/test-pmd/iofwd.c +++ b/app/test-pmd/iofwd.c @@ -23,7 +23,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_memcpy.h> #include <rte_mempool.h> diff --git a/app/test-pmd/macfwd.c b/app/test-pmd/macfwd.c index ac50d0b9f8..812a0c721f 100644 --- a/app/test-pmd/macfwd.c +++ b/app/test-pmd/macfwd.c @@ -24,7 +24,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_mempool.h> #include <rte_mbuf.h> diff --git a/app/test-pmd/macswap.c b/app/test-pmd/macswap.c index 310bca06af..4627ff83e9 100644 --- a/app/test-pmd/macswap.c +++ b/app/test-pmd/macswap.c @@ -24,7 +24,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_mempool.h> #include <rte_mbuf.h> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 0974b0a38f..2f4f944efa 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -30,7 +30,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_mempool.h> #include <rte_interrupts.h> diff --git a/app/test-pmd/rxonly.c b/app/test-pmd/rxonly.c index c78fc4609a..d1a579d8d8 100644 --- a/app/test-pmd/rxonly.c +++ b/app/test-pmd/rxonly.c @@ -24,7 +24,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_mempool.h> #include <rte_mbuf.h> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index 34bb538379..b8497e733d 100644 --- a/app/test-pmd/txonly.c +++ b/app/test-pmd/txonly.c @@ -24,7 +24,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_mempool.h> #include <rte_mbuf.h> diff --git a/app/test/test_barrier.c b/app/test/test_barrier.c index c27f8a0742..898c2516ed 100644 --- a/app/test/test_barrier.c +++ b/app/test/test_barrier.c @@ -24,7 +24,6 @@ #include <rte_memory.h> #include <rte_per_lcore.h> #include <rte_launch.h> -#include <rte_atomic.h> #include <rte_eal.h> #include <rte_lcore.h> #include <rte_pause.h> diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index f93bcef8a9..d53126710f 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -21,7 +21,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_ring.h> #include <rte_mempool.h> diff --git a/app/test/test_mp_secondary.c b/app/test/test_mp_secondary.c index 5b6f05dbb1..021ca0547f 100644 --- a/app/test/test_mp_secondary.c +++ b/app/test/test_mp_secondary.c @@ -28,7 +28,6 @@ #include <rte_lcore.h> #include <rte_errno.h> #include <rte_branch_prediction.h> -#include <rte_atomic.h> #include <rte_ring.h> #include <rte_debug.h> #include <rte_log.h> diff --git a/app/test/test_ring.c b/app/test/test_ring.c index fb8532a409..bde33ab4a1 100644 --- a/app/test/test_ring.c +++ b/app/test/test_ring.c @@ -20,7 +20,6 @@ #include <rte_eal.h> #include <rte_per_lcore.h> #include <rte_lcore.h> -#include <rte_atomic.h> #include <rte_branch_prediction.h> #include <rte_malloc.h> #include <rte_ring.h>