diff mbox series

bus/auxiliary: fix device iteration

Message ID 20211122092543.29731-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series bus/auxiliary: fix device iteration |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Performance fail Performance Testing issues
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS

Commit Message

David Marchand Nov. 22, 2021, 9:25 a.m. UTC 
  rte_kvargs_parse() expects a NULL terminated keys array.

Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/bus/auxiliary/auxiliary_params.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Xueming Li Nov. 22, 2021, 9:43 a.m. UTC | #1 
On Mon, 2021-11-22 at 10:25 +0100, David Marchand wrote:
> rte_kvargs_parse() expects a NULL terminated keys array.
> 
> Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/bus/auxiliary/auxiliary_params.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/auxiliary/auxiliary_params.c b/drivers/bus/auxiliary/auxiliary_params.c
> index a9c7853ed1..d115e11d32 100644
> --- a/drivers/bus/auxiliary/auxiliary_params.c
> +++ b/drivers/bus/auxiliary/auxiliary_params.c
> @@ -18,6 +18,7 @@ enum auxiliary_params {
>  
>  static const char * const auxiliary_params_keys[] = {
>  	[RTE_AUXILIARY_PARAM_NAME] = "name",
> +	NULL,
>  };
>  
>  static int

Nice catch, thanks!

Acked by: Xueming Li <xuemingl@nvidia.com>
David Marchand Nov. 24, 2021, 1:19 p.m. UTC | #2 
On Mon, Nov 22, 2021 at 10:43 AM Xueming(Steven) Li <xuemingl@nvidia.com> wrote:
> On Mon, 2021-11-22 at 10:25 +0100, David Marchand wrote:
> > rte_kvargs_parse() expects a NULL terminated keys array.
> >
> > Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked by: Xueming Li <xuemingl@nvidia.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/bus/auxiliary/auxiliary_params.c b/drivers/bus/auxiliary/auxiliary_params.c
index a9c7853ed1..d115e11d32 100644
--- a/drivers/bus/auxiliary/auxiliary_params.c
+++ b/drivers/bus/auxiliary/auxiliary_params.c
@@ -18,6 +18,7 @@  enum auxiliary_params {
 
 static const char * const auxiliary_params_keys[] = {
 	[RTE_AUXILIARY_PARAM_NAME] = "name",
+	NULL,
 };
 
 static int