Message ID | 20211124010928.227875-1-qi.z.zhang@intel.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Qi Zhang |
Headers | show |
Series | net/ice: fix Tx checksum offload capability | expand |
Context | Check | Description |
---|---|---|
ci/intel-Testing | success | Testing PASS |
ci/Intel-compilation | success | Compilation OK |
ci/iol-aarch64-unit-testing | success | Testing PASS |
ci/iol-x86_64-compile-testing | success | Testing PASS |
ci/iol-x86_64-unit-testing | success | Testing PASS |
ci/iol-intel-Performance | success | Performance Testing PASS |
ci/iol-intel-Functional | success | Functional Testing PASS |
ci/iol-broadcom-Functional | success | Functional Testing PASS |
ci/iol-aarch64-compile-testing | success | Testing PASS |
ci/iol-mellanox-Performance | success | Performance Testing PASS |
ci/iol-broadcom-Performance | success | Performance Testing PASS |
ci/github-robot: build | success | github build: passed |
ci/checkpatch | success | coding style OK |
> -----Original Message----- > From: Zhang, Qi Z <qi.z.zhang@intel.com> > Sent: Wednesday, November 24, 2021 09:09 > To: Yang, Qiming <qiming.yang@intel.com> > Cc: dev@dpdk.org; Xu, Wei1 <wei1.xu@intel.com>; Zhang, Qi Z > <qi.z.zhang@intel.com>; stable@dpdk.org > Subject: [PATCH] net/ice: fix Tx checksum offload capability > > Add missing capability for outer UDP Tx checksum. > Also fixed the feature list in ice_dcf.ini > > Fixes: bf89db4409bb ("net/ice: complete device info get in DCF") > Cc: stable@dpdk.org > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > --- > doc/guides/nics/features/ice_dcf.ini | 5 +++++ > drivers/net/ice/ice_dcf_ethdev.c | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/doc/guides/nics/features/ice_dcf.ini > b/doc/guides/nics/features/ice_dcf.ini > index 4d6fb6d849..54073f0b88 100644 > --- a/doc/guides/nics/features/ice_dcf.ini > +++ b/doc/guides/nics/features/ice_dcf.ini > @@ -3,6 +3,9 @@ > ; > ; Refer to default.ini for the full list of available PMD features. > ; > +; A feature with "P" indicates only be supported when non-vector path ; > +is selected. > +; > [Features] > Queue start/stop = Y > Scattered Rx = Y > @@ -10,6 +13,8 @@ RSS hash = P > CRC offload = Y > L3 checksum offload = P > L4 checksum offload = P > +Inner L3 checksum = P > +Inner L4 checksum = P > Basic stats = Y > Linux = Y > x86-32 = Y > diff --git a/drivers/net/ice/ice_dcf_ethdev.c > b/drivers/net/ice/ice_dcf_ethdev.c > index 28f7f7fb72..fb0d13e5ec 100644 > --- a/drivers/net/ice/ice_dcf_ethdev.c > +++ b/drivers/net/ice/ice_dcf_ethdev.c > @@ -681,6 +681,7 @@ ice_dcf_dev_info_get(struct rte_eth_dev *dev, > RTE_ETH_TX_OFFLOAD_TCP_CKSUM | > RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | > RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | > + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM | > RTE_ETH_TX_OFFLOAD_TCP_TSO | > RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | > RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | > -- > 2.26.2 Acked-by: Qiming Yang <qiming.yang@intel.com>
> -----Original Message----- > From: Yang, Qiming <qiming.yang@intel.com> > Sent: Tuesday, December 7, 2021 11:17 AM > To: Zhang, Qi Z <qi.z.zhang@intel.com> > Cc: dev@dpdk.org; Xu, Wei1 <wei1.xu@intel.com>; stable@dpdk.org > Subject: RE: [PATCH] net/ice: fix Tx checksum offload capability > > > > -----Original Message----- > > From: Zhang, Qi Z <qi.z.zhang@intel.com> > > Sent: Wednesday, November 24, 2021 09:09 > > To: Yang, Qiming <qiming.yang@intel.com> > > Cc: dev@dpdk.org; Xu, Wei1 <wei1.xu@intel.com>; Zhang, Qi Z > > <qi.z.zhang@intel.com>; stable@dpdk.org > > Subject: [PATCH] net/ice: fix Tx checksum offload capability > > > > Add missing capability for outer UDP Tx checksum. > > Also fixed the feature list in ice_dcf.ini > > > > Fixes: bf89db4409bb ("net/ice: complete device info get in DCF") > > Cc: stable@dpdk.org > > > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > > --- > > doc/guides/nics/features/ice_dcf.ini | 5 +++++ > > drivers/net/ice/ice_dcf_ethdev.c | 1 + > > 2 files changed, 6 insertions(+) > > > > diff --git a/doc/guides/nics/features/ice_dcf.ini > > b/doc/guides/nics/features/ice_dcf.ini > > index 4d6fb6d849..54073f0b88 100644 > > --- a/doc/guides/nics/features/ice_dcf.ini > > +++ b/doc/guides/nics/features/ice_dcf.ini > > @@ -3,6 +3,9 @@ > > ; > > ; Refer to default.ini for the full list of available PMD features. > > ; > > +; A feature with "P" indicates only be supported when non-vector path > > +; is selected. > > +; > > [Features] > > Queue start/stop = Y > > Scattered Rx = Y > > @@ -10,6 +13,8 @@ RSS hash = P > > CRC offload = Y > > L3 checksum offload = P > > L4 checksum offload = P > > +Inner L3 checksum = P > > +Inner L4 checksum = P > > Basic stats = Y > > Linux = Y > > x86-32 = Y > > diff --git a/drivers/net/ice/ice_dcf_ethdev.c > > b/drivers/net/ice/ice_dcf_ethdev.c > > index 28f7f7fb72..fb0d13e5ec 100644 > > --- a/drivers/net/ice/ice_dcf_ethdev.c > > +++ b/drivers/net/ice/ice_dcf_ethdev.c > > @@ -681,6 +681,7 @@ ice_dcf_dev_info_get(struct rte_eth_dev *dev, > > RTE_ETH_TX_OFFLOAD_TCP_CKSUM | > > RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | > > RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | > > + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM | > > RTE_ETH_TX_OFFLOAD_TCP_TSO | > > RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | > > RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | > > -- > > 2.26.2 > > Acked-by: Qiming Yang <qiming.yang@intel.com> Applied to dpdk-next-net-intel. Thanks Qi
diff --git a/doc/guides/nics/features/ice_dcf.ini b/doc/guides/nics/features/ice_dcf.ini index 4d6fb6d849..54073f0b88 100644 --- a/doc/guides/nics/features/ice_dcf.ini +++ b/doc/guides/nics/features/ice_dcf.ini @@ -3,6 +3,9 @@ ; ; Refer to default.ini for the full list of available PMD features. ; +; A feature with "P" indicates only be supported when non-vector path +; is selected. +; [Features] Queue start/stop = Y Scattered Rx = Y @@ -10,6 +13,8 @@ RSS hash = P CRC offload = Y L3 checksum offload = P L4 checksum offload = P +Inner L3 checksum = P +Inner L4 checksum = P Basic stats = Y Linux = Y x86-32 = Y diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index 28f7f7fb72..fb0d13e5ec 100644 --- a/drivers/net/ice/ice_dcf_ethdev.c +++ b/drivers/net/ice/ice_dcf_ethdev.c @@ -681,6 +681,7 @@ ice_dcf_dev_info_get(struct rte_eth_dev *dev, RTE_ETH_TX_OFFLOAD_TCP_CKSUM | RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
Add missing capability for outer UDP Tx checksum. Also fixed the feature list in ice_dcf.ini Fixes: bf89db4409bb ("net/ice: complete device info get in DCF") Cc: stable@dpdk.org Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> --- doc/guides/nics/features/ice_dcf.ini | 5 +++++ drivers/net/ice/ice_dcf_ethdev.c | 1 + 2 files changed, 6 insertions(+)