From patchwork Mon Nov 29 09:51:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramkumar Balu X-Patchwork-Id: 104742 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB2D3A0C5A; Mon, 29 Nov 2021 11:41:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19AB74117D; Mon, 29 Nov 2021 11:41:12 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id EFFE440689; Mon, 29 Nov 2021 10:53:32 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AT7ZQb6009078; Mon, 29 Nov 2021 01:53:32 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=aM7L54Q0UxlEYe1FN3RYsSbSbKOvA0VFdU6xDg11Ero=; b=A1YMCKlvkCTHxa7tlROmKV8dS3QMvts43v8dey6Ebd6a5b6BAGwVo6fO8gbz9usa/JUr hZdEO7QgSS8u7GyBAdSZjnZ+NX6hEL0UzXPx+AUCT/UGviTZfDoO5YNZXK0RKUkYyTr2 mTrhQcYTxYfiwbngeWAVmrlLNgOfg8ioZZtWX2PJL0Qfe6ILdC66FwgZY8wHrSeUWHq9 2UNYWzBT3vnmgA18nReQKrwEoGNGaBepJhO4d7Lz4bsCy87l41XGe66+PWwG/tsGQQmv L+RqHXcGmfSLCg+0YqoVC2KdRu1r24d7KbHhmZSr04gQLDvO8rMZ2jkGiogLF2xGk0oZ IA== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3cmtkpgdb8-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 29 Nov 2021 01:53:32 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 29 Nov 2021 01:53:30 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 29 Nov 2021 01:53:30 -0800 Received: from rbalu.marvell.com (unknown [10.29.53.29]) by maili.marvell.com (Postfix) with ESMTP id 176263F7079; Mon, 29 Nov 2021 01:53:24 -0800 (PST) From: Ramkumar Balu To: Akhil Goyal , Anoob Joseph , Declan Doherty , Fan Zhang , Ankur Dwivedi , "Tejasree Kondoj" CC: , , Ramkumar Subject: [PATCH 3/5] crypto/octeontx: fix output field for RSA verify Date: Mon, 29 Nov 2021 09:51:57 +0000 Message-ID: <20211129095159.16376-4-rbalu@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211129095159.16376-1-rbalu@marvell.com> References: <20211129095159.16376-1-rbalu@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: opOL3KN6cOIvL_a4rVeMTPk3XMQPeiNu X-Proofpoint-ORIG-GUID: opOL3KN6cOIvL_a4rVeMTPk3XMQPeiNu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-29_07,2021-11-28_01,2020-04-07_01 X-Mailman-Approved-At: Mon, 29 Nov 2021 11:41:08 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Ramkumar During RSA sign verification, the OCTEONTX PMD returns the decrypted plaintext in 'sign' field of rte_crypto_rsa_op_param. The 'sign' field is actually used to pass input to the operation. This PMD overwrites the 'sign' field buffer. This is non-compliance to lib cryptodev. This patch fixes the PMD to use 'cipher' field to return the decrypted plaintext during RSA verify operation. Fixes: e9a356e2fc71 ("crypto/octeontx: add asymmetric enqueue/dequeue ops") Cc: stable@dpdk.org Signed-off-by: Ramkumar --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c index 9e8fd495cf..07ce079d87 100644 --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c +++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c @@ -788,18 +788,20 @@ otx_cpt_asym_rsa_op(struct rte_crypto_op *cop, struct cpt_request_info *req, break; case RTE_CRYPTO_ASYM_OP_VERIFY: if (rsa->pad == RTE_CRYPTO_RSA_PADDING_NONE) - rsa->sign.length = rsa_ctx->n.length; + rsa->cipher.length = rsa_ctx->n.length; else { /* Get length of decrypted output */ - rsa->sign.length = rte_cpu_to_be_16 + rsa->cipher.length = rte_cpu_to_be_16 (*((uint16_t *)req->rptr)); /* Offset data pointer by length fields */ req->rptr += 2; } - memcpy(rsa->sign.data, req->rptr, rsa->sign.length); - if (memcmp(rsa->sign.data, rsa->message.data, + if (rsa->cipher.data != NULL) + memcpy(rsa->cipher.data, req->rptr, rsa->cipher.length); + + if (memcmp(req->rptr, rsa->message.data, rsa->message.length)) { CPT_LOG_DP_ERR("RSA verification failed"); cop->status = RTE_CRYPTO_OP_STATUS_ERROR;