From patchwork Mon Nov 29 09:51:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramkumar Balu X-Patchwork-Id: 104744 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D570A0C5A; Mon, 29 Nov 2021 11:41:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1885A4276F; Mon, 29 Nov 2021 11:41:14 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id EAF7E40689; Mon, 29 Nov 2021 10:53:54 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1ASNMELR003048; Mon, 29 Nov 2021 01:53:54 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=StPUS0yw/3b3gzBjvTh64tEZYrUs4sHF+7m0mhXxD68=; b=X+EJAtFPE0B8U+AAExMcS9fPCb0NmdYr4eJn1pTX2p3eOSMZ6+J1xKLvowkuXdeXcLQG t0T/ge60c/2F4/hPU46sVbpxlGpCPAn4cP6WK3mTxrsmqFvrw827cfiqvoBCYhwRa4oX jRiePlwxoItd+hQ+TyUWbD369qTGhgONeA4as+uJQKLBQ0HPLBgT8LIRiiLA0LjbvUEo SizZ/DGV1T3/CktSHtnOAAxq3FXP5aTfrxWC2ghxwnH3XU9uAkNoQM598Fp/n6Zigc+H X6BV+2hOnq/7D5DA8ask3vyZt4DKqmFeeE3xm8MeALw0Mi20YLr4EaGcRfHzPObl5Q7r bw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3cmgkpsukv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 29 Nov 2021 01:53:53 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 29 Nov 2021 01:53:52 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Mon, 29 Nov 2021 01:53:52 -0800 Received: from rbalu.marvell.com (unknown [10.29.53.29]) by maili.marvell.com (Postfix) with ESMTP id D41E63F7079; Mon, 29 Nov 2021 01:53:46 -0800 (PST) From: Ramkumar Balu To: Akhil Goyal , Anoob Joseph , Declan Doherty , Fan Zhang , Ankur Dwivedi , "Tejasree Kondoj" CC: , , Ramkumar Subject: [PATCH 5/5] crypto/cnxk: fix output field for RSA verify Date: Mon, 29 Nov 2021 09:51:59 +0000 Message-ID: <20211129095159.16376-6-rbalu@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211129095159.16376-1-rbalu@marvell.com> References: <20211129095159.16376-1-rbalu@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: Vmx8QBnoUD8gMCzJVuGaAE-p6JO6e0o4 X-Proofpoint-GUID: Vmx8QBnoUD8gMCzJVuGaAE-p6JO6e0o4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-29_07,2021-11-28_01,2020-04-07_01 X-Mailman-Approved-At: Mon, 29 Nov 2021 11:41:08 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Ramkumar During RSA sign verification, this PMD returns the decrypted plaintext in 'sign' field of rte_crypto_rsa_op_param. The 'sign' field is actually used to pass input to the operation. This PMD overwrites the 'sign' field buffer. This is non-compliance to lib cryptodev. This patch fixes the PMD to use 'cipher' field to return the decrypted plaintext during RSA verify operation. Fixes: 6661bedf1605 ("crypto/cnxk: add asymmetric datapath") Cc: stable@dpdk.org Signed-off-by: Ramkumar --- drivers/crypto/cnxk/cnxk_ae.h | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_ae.h b/drivers/crypto/cnxk/cnxk_ae.h index 6222171fe6..f4c6c92880 100644 --- a/drivers/crypto/cnxk/cnxk_ae.h +++ b/drivers/crypto/cnxk/cnxk_ae.h @@ -696,19 +696,22 @@ cnxk_ae_dequeue_rsa_op(struct rte_crypto_op *cop, uint8_t *rptr, break; case RTE_CRYPTO_ASYM_OP_VERIFY: if (rsa->pad == RTE_CRYPTO_RSA_PADDING_NONE) { - rsa->sign.length = rsa_ctx->n.length; - memcpy(rsa->sign.data, rptr, rsa->sign.length); + rsa->cipher.length = rsa_ctx->n.length; } else { /* Get length of signed output */ - rsa->sign.length = + rsa->cipher.length = rte_cpu_to_be_16(*((uint16_t *)rptr)); /* * Offset output data pointer by length field - * (2 bytes) and copy signed data. + * (2 bytes). */ - memcpy(rsa->sign.data, rptr + 2, rsa->sign.length); + rptr += 2; } - if (memcmp(rsa->sign.data, rsa->message.data, + + if (rsa->cipher.data != NULL) + memcpy(rsa->cipher.data, rptr, rsa->cipher.length); + + if (memcmp(rptr, rsa->message.data, rsa->message.length)) { cop->status = RTE_CRYPTO_OP_STATUS_ERROR; }