diff mbox series

[v2,1/2] devtools: don't include headline "fix" in backports

Message ID 20211203075415.4083502-1-christian.ehrhardt@canonical.com (mailing list archive)
State New
Delegated to: Thomas Monjalon
Headers show
Series [v2,1/2] devtools: don't include headline "fix" in backports | expand

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

Christian Ehrhardt Dec. 3, 2021, 7:54 a.m. UTC
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>

It was important in the past to select anything with "fix" in the
headline, but recently more often created false positives and work
to sort tihngs out than identifying many helpful patches.

The community and processes aroudn DPDK matured enough that developers
(rightfully) expect to rely on "Fixes:" and "stable@" marking for
backprots.

Therefore do no more include patches that just include the word fix
in the backport candidate list.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 devtools/git-log-fixes.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Luca Boccassi Dec. 3, 2021, 12:24 p.m. UTC | #1
On Fri, 2021-12-03 at 08:54 +0100, christian.ehrhardt@canonical.com
wrote:
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> It was important in the past to select anything with "fix" in the
> headline, but recently more often created false positives and work
> to sort tihngs out than identifying many helpful patches.
> 
> The community and processes aroudn DPDK matured enough that developers
> (rightfully) expect to rely on "Fixes:" and "stable@" marking for
> backprots.
> 
> Therefore do no more include patches that just include the word fix
> in the backport candidate list.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>  devtools/git-log-fixes.sh | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
> index 210c8dcf25..27ec9088d4 100755
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> @@ -13,7 +13,7 @@ print_help ()
>  	cat <<- END_OF_HELP
>  
> 
>  	Find fixes to backport on previous versions.
> -	It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts".
> +	It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org.
>  	The oldest bug origin is printed as well as partially fixed versions.
>  	END_OF_HELP
>  }
> @@ -109,8 +109,7 @@ while read id headline ; do
>  	origins=$(origin_filter $id)
>  	stable=$(stable_tag $id)
>  	fixes=$(fixes_tag $id)
> -	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \
> -		echo "$headline" | grep -q fix || continue
> +	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue
>  	version=$(commit_version $id)
>  	if [ -n "$origins" ] ; then
>  		origver="$(origin_version $origins)"

Acked-by: Luca Boccassi <bluca@debian.org>
Kevin Traynor Dec. 3, 2021, 2:04 p.m. UTC | #2
On 03/12/2021 07:54, christian.ehrhardt@canonical.com wrote:
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> It was important in the past to select anything with "fix" in the
> headline, but recently more often created false positives and work
> to sort tihngs out than identifying many helpful patches.
> 
> The community and processes aroudn DPDK matured enough that developers
> (rightfully) expect to rely on "Fixes:" and "stable@" marking for
> backprots.

nit: several typos here and i think it should say "or" stable@

> 
> Therefore do no more include patches that just include the word fix
> in the backport candidate list.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>   devtools/git-log-fixes.sh | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
> index 210c8dcf25..27ec9088d4 100755
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> @@ -13,7 +13,7 @@ print_help ()
>   	cat <<- END_OF_HELP
>   
>   	Find fixes to backport on previous versions.
> -	It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts".
> +	It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org.

"..or for recipient stable@dpdk.org."

Good idea, thanks. With minor fixes,

Acked-by: Kevin Traynor <ktraynor@redhat.com>

>   	The oldest bug origin is printed as well as partially fixed versions.
>   	END_OF_HELP
>   }
> @@ -109,8 +109,7 @@ while read id headline ; do
>   	origins=$(origin_filter $id)
>   	stable=$(stable_tag $id)
>   	fixes=$(fixes_tag $id)
> -	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \
> -		echo "$headline" | grep -q fix || continue
> +	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue
>   	version=$(commit_version $id)
>   	if [ -n "$origins" ] ; then
>   		origver="$(origin_version $origins)"
>
Xueming(Steven) Li Dec. 5, 2021, 11:38 a.m. UTC | #3
On Fri, 2021-12-03 at 08:54 +0100, christian.ehrhardt@canonical.com
wrote:
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> It was important in the past to select anything with "fix" in the
> headline, but recently more often created false positives and work
> to sort tihngs out than identifying many helpful patches.
> 
> The community and processes aroudn DPDK matured enough that developers
> (rightfully) expect to rely on "Fixes:" and "stable@" marking for
> backprots.
> 
> Therefore do no more include patches that just include the word fix
> in the backport candidate list.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>  devtools/git-log-fixes.sh | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
> index 210c8dcf25..27ec9088d4 100755
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> @@ -13,7 +13,7 @@ print_help ()
>  	cat <<- END_OF_HELP
>  
>  	Find fixes to backport on previous versions.
> -	It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts".
> +	It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org.
>  	The oldest bug origin is printed as well as partially fixed versions.
>  	END_OF_HELP
>  }
> @@ -109,8 +109,7 @@ while read id headline ; do
>  	origins=$(origin_filter $id)
>  	stable=$(stable_tag $id)
>  	fixes=$(fixes_tag $id)
> -	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \
> -		echo "$headline" | grep -q fix || continue
> +	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue
>  	version=$(commit_version $id)
>  	if [ -n "$origins" ] ; then
>  		origver="$(origin_version $origins)"

Yes, most of them are faked ones, thanks for fixing this.

Acked-by: Xueming Li <xuemingl@nvidia.com>
diff mbox series

Patch

diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
index 210c8dcf25..27ec9088d4 100755
--- a/devtools/git-log-fixes.sh
+++ b/devtools/git-log-fixes.sh
@@ -13,7 +13,7 @@  print_help ()
 	cat <<- END_OF_HELP
 
 	Find fixes to backport on previous versions.
-	It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts".
+	It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org.
 	The oldest bug origin is printed as well as partially fixed versions.
 	END_OF_HELP
 }
@@ -109,8 +109,7 @@  while read id headline ; do
 	origins=$(origin_filter $id)
 	stable=$(stable_tag $id)
 	fixes=$(fixes_tag $id)
-	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \
-		echo "$headline" | grep -q fix || continue
+	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue
 	version=$(commit_version $id)
 	if [ -n "$origins" ] ; then
 		origver="$(origin_version $origins)"