| Message ID | 20211210140952.2907974-2-ciara.power@intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | akhil goyal |
| Headers | show |
| Series | [1/3] crypto/ipsec_mb: fix qp setup null pointer dereference | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
> -----Original Message----- > From: Power, Ciara <ciara.power@intel.com> > Sent: Friday, December 10, 2021 2:10 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Zhang, > Roy Fan <roy.fan.zhang@intel.com>; Power, Ciara <ciara.power@intel.com>; > De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com> > Subject: [PATCH 2/3] crypto/ipsec_mb: fix qp cleanup null pointer > dereference > > The qp was being used in the cleanup without checking if it was non NULL. > A check is now added to verify qp is non NULL before use. > > Coverity issue: 374375 > Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework") > Cc: roy.fan.zhang@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Ciara Power <ciara.power@intel.com> > --- Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c index 6efa417d67..1ebd23e8f0 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c @@ -285,6 +285,8 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, return 0; qp_setup_cleanup: + if (qp == NULL) + return ret; #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM if (qp->mb_mgr) free_mb_mgr(qp->mb_mgr); @@ -294,8 +296,7 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, if (qp->mb_mgr_mz) rte_memzone_free(qp->mb_mgr_mz); #endif - if (qp) - rte_free(qp); + rte_free(qp); return ret; }
The qp was being used in the cleanup without checking if it was non NULL. A check is now added to verify qp is non NULL before use. Coverity issue: 374375 Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework") Cc: roy.fan.zhang@intel.com Cc: stable@dpdk.org Signed-off-by: Ciara Power <ciara.power@intel.com> --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)