diff mbox series

[06/18] net/bnxt: fix to cap max number of unicast MACs

Message ID	20220104083824.23001-7-kalesh-anakkur.purayil@broadcom.com (mailing list archive)
State	Accepted, archived
Delegated to:	Ajit Khaparde
Headers	From: Kalesh A P <kalesh-anakkur.purayil@broadcom.com> To: dev@dpdk.org Cc: ferruh.yigit@intel.com, ajit.khaparde@broadcom.com Subject: [dpdk-dev] [PATCH 06/18] net/bnxt: fix to cap max number of unicast MACs Date: Tue, 4 Jan 2022 14:08:12 +0530 Message-Id: <20220104083824.23001-7-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20220104083824.23001-1-kalesh-anakkur.purayil@broadcom.com> References: <20220104083824.23001-1-kalesh-anakkur.purayil@broadcom.com> Precedence: list Errors-To: dev-bounces@dpdk.org
Series	bnxt PMD fixes \| [00/18] bnxt PMD fixes [01/18] net/bnxt: fix bnxt_dev_set_mc_addr_list_op [02/18] net/bnxt: fix to restore mcast macs during reset recovery [03/18] net/bnxt: fix queue stop operation [04/18] net/bnxt: restore RSS configuration after reset recovery [05/18] net/bnxt: fix restoring VLAN filtering after recovery [06/18] net/bnxt: fix to cap max number of unicast MACs [07/18] net/bnxt: set fast-path pointers only if recovery succeeds [08/18] net/bnxt: improve recovery related log messages [09/18] net/bnxt: add null check for mark table [10/18] net/bnxt: fix flow create when RSS is disabled [11/18] net/bnxt: get max supported multicast filters count [12/18] net/bnxt: refactor bnxt_stop_rxtx() for reuse [13/18] net/bnxt: fix handling of VF configuration changes [14/18] net/bnxt: fix ring teardown [15/18] net/bnxt: fix PAM4 mask setting [16/18] net/bnxt: fix pointer access [17/18] net/bnxt: fix incorrect memset in bnxt_dev_xstats_get_op [18/18] net/bnxt: check VF rep pointer before access

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Kalesh A P Jan. 4, 2022, 8:38 a.m. UTC

  From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

The Maximum number of receive mac addr is hard coded to 128
in the ethdev library(RTE_ETH_NUM_RECEIVE_MAC_ADDR).
But the bnxt devices support more than 128 unicast MAC filters
which could result in a segfault while user tries to add more
than 128 unicast MAC addresses to the port.

Fixes: a2033fda22ab ("net/bnxt: fix number of MAC addresses for VMDq")
Cc: stable@dpdk.org

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 99a7d35..82350a5 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -954,7 +954,7 @@  static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
 		return rc;
 
 	/* MAC Specifics */
-	dev_info->max_mac_addrs = bp->max_l2_ctx;
+	dev_info->max_mac_addrs = RTE_MIN(bp->max_l2_ctx, RTE_ETH_NUM_RECEIVE_MAC_ADDR);
 	dev_info->max_hash_mac_addrs = 0;
 
 	/* PF/VF specifics */
@@ -5016,11 +5016,15 @@  static int bnxt_alloc_stats_mem(struct bnxt *bp)
 static int bnxt_setup_mac_addr(struct rte_eth_dev *eth_dev)
 {
 	struct bnxt *bp = eth_dev->data->dev_private;
+	size_t max_mac_addr = RTE_MIN(bp->max_l2_ctx, RTE_ETH_NUM_RECEIVE_MAC_ADDR);
 	int rc = 0;
 
+	if (bp->max_l2_ctx > RTE_ETH_NUM_RECEIVE_MAC_ADDR)
+		PMD_DRV_LOG(INFO, "Max number of MAC addrs supported is %d, but will be limited to %d\n",
+			    bp->max_l2_ctx, RTE_ETH_NUM_RECEIVE_MAC_ADDR);
+
 	eth_dev->data->mac_addrs = rte_zmalloc("bnxt_mac_addr_tbl",
-					       RTE_ETHER_ADDR_LEN *
-					       bp->max_l2_ctx,
+					       RTE_ETHER_ADDR_LEN * max_mac_addr,
 					       0);
 	if (eth_dev->data->mac_addrs == NULL) {
 		PMD_DRV_LOG(ERR, "Failed to alloc MAC addr tbl\n");