diff mbox series

bus/ifpga: remove useless check while browsing devices

Message ID 20220105102652.6400-1-maxime.gouin@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series bus/ifpga: remove useless check while browsing devices |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Maxime Gouin Jan. 5, 2022, 10:26 a.m. UTC 
  reported by code analysis tool C++test (version 10.4):

> /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
> 67    Condition "afu_dev" is always evaluated to true
> 81    Condition "afu_dev" is always evaluated to true

The "for" loop already checks that afu_dev is not NULL.

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")

Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
---
 drivers/bus/ifpga/ifpga_bus.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Kevin Traynor Jan. 11, 2022, 3:12 p.m. UTC | #1 
On 05/01/2022 10:26, Maxime Gouin wrote:
> reported by code analysis tool C++test (version 10.4):
> 
>> /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
>> 67    Condition "afu_dev" is always evaluated to true
>> 81    Condition "afu_dev" is always evaluated to true
> 
> The "for" loop already checks that afu_dev is not NULL.
> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> 

Cc: stable@dpdk.org

> Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Kevin Traynor <ktraynor@redhat.com>

> ---
>   drivers/bus/ifpga/ifpga_bus.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index cbc680928486..c5c8bbd57219 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -64,8 +64,7 @@ ifpga_find_afu_dev(const struct rte_rawdev *rdev,
>   	struct rte_afu_device *afu_dev = NULL;
>   
>   	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
> -		if (afu_dev &&
> -			afu_dev->rawdev == rdev &&
> +		if (afu_dev->rawdev == rdev &&
>   			!ifpga_afu_id_cmp(&afu_dev->id, afu_id))
>   			return afu_dev;
>   	}
> @@ -78,8 +77,7 @@ rte_ifpga_find_afu_by_name(const char *name)
>   	struct rte_afu_device *afu_dev = NULL;
>   
>   	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
> -		if (afu_dev &&
> -			!strcmp(afu_dev->device.name, name))
> +		if (!strcmp(afu_dev->device.name, name))
>   			return afu_dev;
>   	}
>   	return NULL;
>
Xu, Rosen Jan. 13, 2022, 2:19 p.m. UTC | #2 
Hi,

Thanks.

> -----Original Message-----
> From: Maxime Gouin <maxime.gouin@6wind.com>
> Sent: Wednesday, January 05, 2022 18:27
> To: dev@dpdk.org
> Cc: Maxime Gouin <maxime.gouin@6wind.com>; Xu, Rosen
> <rosen.xu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Olivier Matz <olivier.matz@6wind.com>
> Subject: [PATCH] bus/ifpga: remove useless check while browsing devices
> 
> reported by code analysis tool C++test (version 10.4):
> 
> > /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
> > 67    Condition "afu_dev" is always evaluated to true
> > 81    Condition "afu_dev" is always evaluated to true
> 
> The "for" loop already checks that afu_dev is not NULL.
> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> 
> Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  drivers/bus/ifpga/ifpga_bus.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index cbc680928486..c5c8bbd57219 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -64,8 +64,7 @@ ifpga_find_afu_dev(const struct rte_rawdev *rdev,
>  	struct rte_afu_device *afu_dev = NULL;
> 
>  	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
> -		if (afu_dev &&
> -			afu_dev->rawdev == rdev &&
> +		if (afu_dev->rawdev == rdev &&
>  			!ifpga_afu_id_cmp(&afu_dev->id, afu_id))
>  			return afu_dev;
>  	}
> @@ -78,8 +77,7 @@ rte_ifpga_find_afu_by_name(const char *name)
>  	struct rte_afu_device *afu_dev = NULL;
> 
>  	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
> -		if (afu_dev &&
> -			!strcmp(afu_dev->device.name, name))
> +		if (!strcmp(afu_dev->device.name, name))
>  			return afu_dev;
>  	}
>  	return NULL;
> --
> 2.30.2

Acked-by: Rosen Xu <rosen.xu@intel.com>
Thomas Monjalon Jan. 19, 2022, 4:53 p.m. UTC | #3 
> > reported by code analysis tool C++test (version 10.4):
> > 
> > > /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
> > > 67    Condition "afu_dev" is always evaluated to true
> > > 81    Condition "afu_dev" is always evaluated to true
> > 
> > The "for" loop already checks that afu_dev is not NULL.
> > 
> > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> > 
> > Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
> > Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Rosen Xu <rosen.xu@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index cbc680928486..c5c8bbd57219 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -64,8 +64,7 @@  ifpga_find_afu_dev(const struct rte_rawdev *rdev,
 	struct rte_afu_device *afu_dev = NULL;
 
 	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
-		if (afu_dev &&
-			afu_dev->rawdev == rdev &&
+		if (afu_dev->rawdev == rdev &&
 			!ifpga_afu_id_cmp(&afu_dev->id, afu_id))
 			return afu_dev;
 	}
@@ -78,8 +77,7 @@  rte_ifpga_find_afu_by_name(const char *name)
 	struct rte_afu_device *afu_dev = NULL;
 
 	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
-		if (afu_dev &&
-			!strcmp(afu_dev->device.name, name))
+		if (!strcmp(afu_dev->device.name, name))
 			return afu_dev;
 	}
 	return NULL;