examples/l3fwd: fix Rx burst size for event mode

Message ID 20220111050546.13003-1-nipun.gupta@nxp.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series examples/l3fwd: fix Rx burst size for event mode |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Nipun Gupta Jan. 11, 2022, 5:05 a.m. UTC
  From: Nipun Gupta <nipun.gupta@nxp.com>

While dequeing the packets from the event device, burst size
is provided in the API. This was not getting properly
conigured in the application. This patch correctly configures
the burst size.

Fixes: aaf58cb85b62 ("examples/l3fwd: add event port and queue setup")
Cc: stable@dpdk.org

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
 examples/l3fwd/l3fwd_event_internal_port.c | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Sunil Kumar Kori Jan. 18, 2022, 10:38 a.m. UTC | #1
Regards
Sunil Kumar Kori

>-----Original Message-----
>From: nipun.gupta@nxp.com <nipun.gupta@nxp.com>
>Sent: Tuesday, January 11, 2022 10:36 AM
>To: dev@dpdk.org
>Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Sunil Kumar Kori
><skori@marvell.com>; thomas@monjalon.net; hemant.agrawal@nxp.com;
>stable@dpdk.org; Nipun Gupta <nipun.gupta@nxp.com>
>Subject: [EXT] [PATCH] examples/l3fwd: fix Rx burst size for event mode
>
>External Email
>
>----------------------------------------------------------------------
>From: Nipun Gupta <nipun.gupta@nxp.com>
>
>While dequeing the packets from the event device, burst size is provided in
>the API. This was not getting properly conigured in the application. This patch
>correctly configures the burst size.
>
>Fixes: aaf58cb85b62 ("examples/l3fwd: add event port and queue setup")
>Cc: stable@dpdk.org
>
>Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
>---
> examples/l3fwd/l3fwd_event_internal_port.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/examples/l3fwd/l3fwd_event_internal_port.c
>b/examples/l3fwd/l3fwd_event_internal_port.c
>index 1e8f46bc11..32cf657148 100644
>--- a/examples/l3fwd/l3fwd_event_internal_port.c
>+++ b/examples/l3fwd/l3fwd_event_internal_port.c
>@@ -118,6 +118,8 @@ l3fwd_event_port_setup_internal_port(void)
> 		event_p_conf.event_port_cfg |=
> 			RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL;
>
>+	evt_rsrc->deq_depth = def_p_conf.dequeue_depth;
>+
> 	for (event_p_id = 0; event_p_id < evt_rsrc->evp.nb_ports;
> 								event_p_id++)
>{
> 		ret = rte_event_port_setup(event_d_id, event_p_id,
>--
>2.17.1

Acked-by: Sunil Kumar Kori <skori@mavell.com>
  
Jerin Jacob Jan. 21, 2022, 11:58 a.m. UTC | #2
On Tue, Jan 18, 2022 at 4:08 PM Sunil Kumar Kori <skori@marvell.com> wrote:
>
>
>
> Regards
> Sunil Kumar Kori
>
> >-----Original Message-----
> >From: nipun.gupta@nxp.com <nipun.gupta@nxp.com>
> >Sent: Tuesday, January 11, 2022 10:36 AM
> >To: dev@dpdk.org
> >Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Sunil Kumar Kori
> ><skori@marvell.com>; thomas@monjalon.net; hemant.agrawal@nxp.com;
> >stable@dpdk.org; Nipun Gupta <nipun.gupta@nxp.com>
> >Subject: [EXT] [PATCH] examples/l3fwd: fix Rx burst size for event mode
> >
> >External Email
> >
> >----------------------------------------------------------------------
> >From: Nipun Gupta <nipun.gupta@nxp.com>
> >
> >While dequeing the packets from the event device, burst size is provided in

dequeuing

> >the API. This was not getting properly conigured in the application. This patch

configured

> >correctly configures the burst size.
> >
> >Fixes: aaf58cb85b62 ("examples/l3fwd: add event port and queue setup")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> >---

>
> Acked-by: Sunil Kumar Kori <skori@mavell.com>
>

Fixed above typo
Applied to dpdk-next-net-eventdev/for-main. Thanks
  

Patch

diff --git a/examples/l3fwd/l3fwd_event_internal_port.c b/examples/l3fwd/l3fwd_event_internal_port.c
index 1e8f46bc11..32cf657148 100644
--- a/examples/l3fwd/l3fwd_event_internal_port.c
+++ b/examples/l3fwd/l3fwd_event_internal_port.c
@@ -118,6 +118,8 @@  l3fwd_event_port_setup_internal_port(void)
 		event_p_conf.event_port_cfg |=
 			RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL;
 
+	evt_rsrc->deq_depth = def_p_conf.dequeue_depth;
+
 	for (event_p_id = 0; event_p_id < evt_rsrc->evp.nb_ports;
 								event_p_id++) {
 		ret = rte_event_port_setup(event_d_id, event_p_id,