| Message ID | 20220113143609.3531344-1-akozyrev@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Raslan Darawsheh |
| Headers | show |
| Series | net/mlx5: fix wrong MPRQ WQE size assertion | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/iol-testing | warning | apply patch failure |
| ci/Intel-compilation | success | Compilation OK |
| ci/intel-Testing | success | Testing PASS |
Hi, > -----Original Message----- > From: Alexander Kozyrev <akozyrev@nvidia.com> > Sent: Thursday, January 13, 2022 4:36 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko > <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Michael > Baum <michaelba@nvidia.com> > Subject: [PATCH] net/mlx5: fix wrong MPRQ WQE size assertion > > Preparation of the stride size and the number of strides for > Multi-Packet RQ was updated recently to accommodate the hardware > limitation about minimum WQE size. The wrong assertion was > introduced to ensure this limitation is met. Assert that the > configured WQE size is not less than the minimum supported size. > > Fixes: 219f08a ("net/mlx5: fix missing adjustment MPRQ stride devargs") > > Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index ed21fbba1e..105e094fdf 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -1619,7 +1619,7 @@ mlx5_mprq_prepare(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc, RTE_BIT32(log_def_stride_size)); log_stride_wqe_size = log_def_stride_num + log_def_stride_size; } - MLX5_ASSERT(log_stride_wqe_size < config->mprq.log_min_stride_wqe_size); + MLX5_ASSERT(log_stride_wqe_size >= config->mprq.log_min_stride_wqe_size); if (desc <= RTE_BIT32(*actual_log_stride_num)) goto unsupport; if (min_mbuf_size > RTE_BIT32(log_stride_wqe_size)) {
Preparation of the stride size and the number of strides for Multi-Packet RQ was updated recently to accommodate the hardware limitation about minimum WQE size. The wrong assertion was introduced to ensure this limitation is met. Assert that the configured WQE size is not less than the minimum supported size. Fixes: 219f08a ("net/mlx5: fix missing adjustment MPRQ stride devargs") Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)