| Message ID | 20220117071533.1221315-1-ruifeng.wang@arm.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series | [v2] build: add missing arch define for Arm | expand |
| Context | Check | Description |
|---|---|---|
| ci/iol-abi-testing | success | Testing PASS |
| ci/iol-aarch64-compile-testing | success | Testing PASS |
| ci/iol-x86_64-compile-testing | success | Testing PASS |
| ci/iol-aarch64-unit-testing | success | Testing PASS |
| ci/iol-x86_64-unit-testing | success | Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/intel-Testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/github-robot: build | success | github build: passed |
| ci/checkpatch | success | coding style OK |
17/01/2022 08:15, Ruifeng Wang: > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -49,6 +49,7 @@ implementer_generic = { > ['RTE_ARCH_ARM_NEON_MEMCPY', false], > ['RTE_ARCH_STRICT_ALIGN', true], > ['RTE_ARCH_ARMv8_AARCH32', true], > + ['RTE_ARCH', 'armv8_aarch32'], > ['RTE_CACHE_LINE_SIZE', 64] > ] > } > @@ -432,11 +433,13 @@ if dpdk_conf.get('RTE_ARCH_32') > else > # armv7 build > dpdk_conf.set('RTE_ARCH_ARMv7', true) > + dpdk_conf.set('RTE_ARCH', 'armv7') > # the minimum architecture supported, armv7-a, needs the following, > machine_args += '-mfpu=neon' > endif > else > # armv8 build > + dpdk_conf.set('RTE_ARCH', 'arm64') Juraj commented on v1 that it should be armv8.
> -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Wednesday, January 19, 2022 5:01 PM > To: Ruifeng Wang <Ruifeng.Wang@arm.com> > Cc: dev@dpdk.org; stable@dpdk.org; viktorin@rehivetech.com; > bruce.richardson@intel.com; stephen@networkplumber.org; > juraj.linkes@pantheon.tech; Honnappa Nagarahalli > <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>; stable@dpdk.org > Subject: Re: [PATCH v2] build: add missing arch define for Arm > > 17/01/2022 08:15, Ruifeng Wang: > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > @@ -49,6 +49,7 @@ implementer_generic = { > > ['RTE_ARCH_ARM_NEON_MEMCPY', false], > > ['RTE_ARCH_STRICT_ALIGN', true], > > ['RTE_ARCH_ARMv8_AARCH32', true], > > + ['RTE_ARCH', 'armv8_aarch32'], > > ['RTE_CACHE_LINE_SIZE', 64] > > ] > > } > > @@ -432,11 +433,13 @@ if dpdk_conf.get('RTE_ARCH_32') > > else > > # armv7 build > > dpdk_conf.set('RTE_ARCH_ARMv7', true) > > + dpdk_conf.set('RTE_ARCH', 'armv7') > > # the minimum architecture supported, armv7-a, needs the following, > > machine_args += '-mfpu=neon' > > endif > > else > > # armv8 build > > + dpdk_conf.set('RTE_ARCH', 'arm64') > > Juraj commented on v1 that it should be armv8. > Thanks, I will send out v3.
diff --git a/config/arm/meson.build b/config/arm/meson.build index 16e808cdd5..0066ab5f18 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -49,6 +49,7 @@ implementer_generic = { ['RTE_ARCH_ARM_NEON_MEMCPY', false], ['RTE_ARCH_STRICT_ALIGN', true], ['RTE_ARCH_ARMv8_AARCH32', true], + ['RTE_ARCH', 'armv8_aarch32'], ['RTE_CACHE_LINE_SIZE', 64] ] } @@ -432,11 +433,13 @@ if dpdk_conf.get('RTE_ARCH_32') else # armv7 build dpdk_conf.set('RTE_ARCH_ARMv7', true) + dpdk_conf.set('RTE_ARCH', 'armv7') # the minimum architecture supported, armv7-a, needs the following, machine_args += '-mfpu=neon' endif else # armv8 build + dpdk_conf.set('RTE_ARCH', 'arm64') update_flags = true soc_config = {} if not meson.is_cross_build()
As per design document, RTE_ARCH is the name of the architecture. However, the definition was missing on Arm with meson build. It impacts applications that refers to this string. Added for Arm builds. Fixes: b1d48c41189a ("build: support ARM with meson") Cc: stable@dpdk.org Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com> --- v2: Renamed string for aarch32 to keep consistency with RTE_ARCH_xx defines. (Thomas) config/arm/meson.build | 3 +++ 1 file changed, 3 insertions(+)