diff mbox series

[3/4] net/ark: publish include file for external access

Message ID 20220119191255.273988-3-john.miller@atomicrules.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers show
Series [1/4] net/ark: add device capabilities record | expand

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

John Miller Jan. 19, 2022, 7:12 p.m. UTC
publish rte_pmd_ark.h for external access to extension

Signed-off-by: John Miller <john.miller@atomicrules.com>
---
 doc/guides/nics/ark.rst                      | 4 ++--
 drivers/net/ark/meson.build                  | 2 ++
 drivers/net/ark/{ark_ext.h => rte_pmd_ark.h} | 8 ++++++--
 3 files changed, 10 insertions(+), 4 deletions(-)
 rename drivers/net/ark/{ark_ext.h => rte_pmd_ark.h} (97%)

Comments

Ferruh Yigit Jan. 26, 2022, 4:48 p.m. UTC | #1
On 1/19/2022 7:12 PM, John Miller wrote:
> publish rte_pmd_ark.h for external access to extension
> 

I have rejected same patch 2 or 3 times since PMD first upstreamed,
it is frustrating that it keeps coming :(

Please find the reasoning of why it is rejected from archives.

> Signed-off-by: John Miller <john.miller@atomicrules.com>
Ferruh Yigit Jan. 26, 2022, 4:49 p.m. UTC | #2
On 1/26/2022 4:48 PM, Ferruh Yigit wrote:
> On 1/19/2022 7:12 PM, John Miller wrote:
>> publish rte_pmd_ark.h for external access to extension
>>
> 
> I have rejected same patch 2 or 3 times since PMD first upstreamed,
> it is frustrating that it keeps coming :(
> 

cc'ed Shepard & Ed.

> Please find the reasoning of why it is rejected from archives.
> 
>> Signed-off-by: John Miller <john.miller@atomicrules.com>
>
diff mbox series

Patch

diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
index da61814b5d..bcc3babd53 100644
--- a/doc/guides/nics/ark.rst
+++ b/doc/guides/nics/ark.rst
@@ -143,7 +143,7 @@  object file contains extension (or hook) functions that are registered
 and then called during PMD operations.
 
 The allowable set of extension functions are defined and documented in
-``ark_ext.h``, only the initialization function,
+``rte_pmd_ark.h``, only the initialization function,
 ``rte_pmd_ark_dev_init()``, is required; all others are optional. The
 following sections give a small extension example along with
 instructions for compiling and using the extension.
@@ -157,7 +157,7 @@  during RX from user meta data coming from FPGA hardware.
 
 .. code-block:: c
 
-   #include <ark_ext.h>
+   #include <rte_pmd_ark.h>
    #include <rte_mbuf.h>
    #include <rte_ethdev.h>
    #include <rte_malloc.h>
diff --git a/drivers/net/ark/meson.build b/drivers/net/ark/meson.build
index 8d87744c22..83488d87a8 100644
--- a/drivers/net/ark/meson.build
+++ b/drivers/net/ark/meson.build
@@ -7,6 +7,8 @@  if is_windows
     subdir_done()
 endif
 
+headers = files('rte_pmd_ark.h')
+
 sources = files(
         'ark_ddm.c',
         'ark_ethdev.c',
diff --git a/drivers/net/ark/ark_ext.h b/drivers/net/ark/rte_pmd_ark.h
similarity index 97%
rename from drivers/net/ark/ark_ext.h
rename to drivers/net/ark/rte_pmd_ark.h
index d235d0ff85..f77c36eb2d 100644
--- a/drivers/net/ark/ark_ext.h
+++ b/drivers/net/ark/rte_pmd_ark.h
@@ -5,7 +5,11 @@ 
 #ifndef _ARK_EXT_H_
 #define _ARK_EXT_H_
 
-#include <ethdev_driver.h>
+#include <stdint.h>
+struct rte_eth_dev;
+struct rte_mbuf;
+struct rte_ether_addr;
+struct rte_eth_stats;
 
 /* The following section lists function prototypes for Arkville's
  * dynamic PMD extension. User's who create an extension
@@ -55,7 +59,7 @@  void rte_pmd_ark_dev_uninit(struct rte_eth_dev *dev, void *user_data);
  *   user argument from dev_init() call.
  * @return (0) if successful.
  */
-uint8_t dev_get_port_count(struct rte_eth_dev *dev, void *user_data);
+uint8_t rte_pmd_ark_dev_get_port_count(struct rte_eth_dev *dev, void *user_data);
 
 /**
  * Extension prototype, optional implementation.