From patchwork Mon Jan 24 17:46:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106398 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E62F8A04AD; Mon, 24 Jan 2022 18:51:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69ABB428DD; Mon, 24 Jan 2022 18:48:10 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 7224B428C4 for ; Mon, 24 Jan 2022 18:48:06 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id 128so16678998pfe.12 for ; Mon, 24 Jan 2022 09:48:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BLI65pAkl2Uesd7NXA66nH3tfFeFOpHNaRIG+fzMF3I=; b=ijjtXNJlMBQdC4pfoqSGgIWaLr7h9mGOhBK+YcJybXVDB10jOKEG9icIU1HuVm/ird 5A34hnljz0isUhVXwi32hA6llnTwIfUt3GCoVSJUFFIh15IEtXPD0AfbJq0qxKRo10Wu 6mSxJxVseCmVT3BcoshYRo3Z1GItJz8AMVKcHGfCVSOoRhRDzQqRE+IascuPCRmui60t V10pwZ93LIfWyl1PVOuAXMaQDtY8qudRrlJXg7061PJxw12yfIyeqO9kiDdjHLHzj7FL btXEXsLJLeYVdInKSyT9dZLE9SEqgyLT+dpz3dzDjDNby+z+47NVkRw6rTpLNARuMpll hUEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BLI65pAkl2Uesd7NXA66nH3tfFeFOpHNaRIG+fzMF3I=; b=SxGblEqajaxKBHHhZYjckYq5PosObhvgpeC6i8kF353QIhoigFao0Q/H7mop2tWKWH vL9pcbNdpyovgsNcd2IH8VP7Hr61qzHtHAygVj3cDxvnQwT2Gu2hEPt5pDsJzzfR6zjK Khvx8xp0IvJ0oXCJHxdF38P6nmIkuacT8LEbxabQ3SGY2B2J1tTnyVZhuHF9kAsrBvUg qX1N86iEaI3U81+J1D1ktxaA+1o5vrBnxeerjZEW+zkC+xv6xFlmRlm2rpUGu/1EpxAH q0zH3GD6Q9+ZG6aUMOEmUv+fQrKvv4ZmKWynYCha3Y5F38hzYi2qnUezW8pS4zKtjR+Z w6UA== X-Gm-Message-State: AOAM530FK5iqYf+SDo490F8mz6FBsBzNJN2MBqThHe/lNDOxGAdPKq4P LvFGkiFToRixgiXOv4yEubGicYTnQZ78Ug== X-Google-Smtp-Source: ABdhPJzLSSi40uAps3I6U0j8yIy4CCLZvuGG+wSDWnz9Lz1y7BRneDykgKf89x40tIhnKraBXfG6Kw== X-Received: by 2002:a05:6a00:1413:b0:4bf:a0d7:1f55 with SMTP id l19-20020a056a00141300b004bfa0d71f55mr15008624pfu.13.1643046485448; Mon, 24 Jan 2022 09:48:05 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:04 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chandubabu Namburu Subject: [PATCH v2 40/83] net/axgbe: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:36 -0800 Message-Id: <20220124174719.14417-41-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/axgbe/axgbe_rxtx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c index 6bd41d3002bf..f38bb64fab6b 100644 --- a/drivers/net/axgbe/axgbe_rxtx.c +++ b/drivers/net/axgbe/axgbe_rxtx.c @@ -22,8 +22,7 @@ axgbe_rx_queue_release(struct axgbe_rx_queue *rx_queue) sw_ring = rx_queue->sw_ring; if (sw_ring) { for (i = 0; i < rx_queue->nb_desc; i++) { - if (sw_ring[i]) - rte_pktmbuf_free(sw_ring[i]); + rte_pktmbuf_free(sw_ring[i]); } rte_free(sw_ring); } @@ -507,8 +506,7 @@ static void axgbe_tx_queue_release(struct axgbe_tx_queue *tx_queue) sw_ring = tx_queue->sw_ring; if (sw_ring) { for (i = 0; i < tx_queue->nb_desc; i++) { - if (sw_ring[i]) - rte_pktmbuf_free(sw_ring[i]); + rte_pktmbuf_free(sw_ring[i]); } rte_free(sw_ring); }