diff mbox series

common/cnxk: fix base rule merging only for ingress

Message ID 20220125041759.905955-1-psatheesh@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series common/cnxk: fix base rule merging only for ingress |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing warning apply patch failure
ci/Intel-compilation fail Compilation issues
ci/intel-Testing success Testing PASS

Commit Message

Satheesh Paul Antonysamy Jan. 25, 2022, 4:17 a.m. UTC 
  From: Satheesh Paul <psatheesh@marvell.com>

When creating flow rule, merge base steering rule only
for ingress rules.

Fixes: f9af9080746 ("common/cnxk: add mcam utility API")
Cc: stable@dpdk.org

Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
---
 drivers/common/cnxk/roc_npc_mcam.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jerin Jacob Feb. 17, 2022, 8:12 a.m. UTC | #1 
On Tue, Jan 25, 2022 at 9:48 AM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> When creating flow rule, merge base steering rule only
> for ingress rules.
>
> Fixes: f9af9080746 ("common/cnxk: add mcam utility API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>

Updated the commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks

    common/cnxk: fix base rule merge

    Egress rules do not have a base steering rule and the
    current base steering rule is applicable only for ingress
    rules. Hence, when creating a flow rule, merge base steering
    rule only for ingress rules.

    Fixes: f9af9080746 ("common/cnxk: add mcam utility API")
    Cc: stable@dpdk.org

    Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
    Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>

> ---
>  drivers/common/cnxk/roc_npc_mcam.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c
> index b251f643bc..7a3a8944f5 100644
> --- a/drivers/common/cnxk/roc_npc_mcam.c
> +++ b/drivers/common/cnxk/roc_npc_mcam.c
> @@ -752,7 +752,7 @@ npc_program_mcam(struct npc *npc, struct npc_parse_state *pst, bool mcam_alloc)
>         if (pst->set_ipv6ext_ltype_mask)
>                 npc_set_ipv6ext_ltype_mask(pst);
>
> -       if (pst->is_vf) {
> +       if (pst->is_vf && pst->flow->nix_intf == NIX_INTF_RX) {
>                 (void)mbox_alloc_msg_npc_read_base_steer_rule(npc->mbox);
>                 rc = mbox_process_msg(npc->mbox, (void *)&base_rule_rsp);
>                 if (rc) {
> --
> 2.25.4
>
diff mbox series

Patch

diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c
index b251f643bc..7a3a8944f5 100644
--- a/drivers/common/cnxk/roc_npc_mcam.c
+++ b/drivers/common/cnxk/roc_npc_mcam.c
@@ -752,7 +752,7 @@  npc_program_mcam(struct npc *npc, struct npc_parse_state *pst, bool mcam_alloc)
 	if (pst->set_ipv6ext_ltype_mask)
 		npc_set_ipv6ext_ltype_mask(pst);
 
-	if (pst->is_vf) {
+	if (pst->is_vf && pst->flow->nix_intf == NIX_INTF_RX) {
 		(void)mbox_alloc_msg_npc_read_base_steer_rule(npc->mbox);
 		rc = mbox_process_msg(npc->mbox, (void *)&base_rule_rsp);
 		if (rc) {