From patchwork Thu Feb 3 08:46:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Slava Ovsiienko X-Patchwork-Id: 106831 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22DF0A00C2; Thu, 3 Feb 2022 09:47:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAE7740143; Thu, 3 Feb 2022 09:47:20 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2079.outbound.protection.outlook.com [40.107.220.79]) by mails.dpdk.org (Postfix) with ESMTP id 47A8340140; Thu, 3 Feb 2022 09:47:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bKIzo44vEdT+rOWVpWAMu92OW38N4LOxdqys3FpBYMtLr8ieNBuOqNqZYeICD7Rc56xqegQRK+cbbjVxDdpK1EP9OBmSZ2HL08EDHUyj9WvHkP76Qo19IZKGIqh/wrJNDToSFKADFQpxOcfsXll1yoIQcyksACGckVKjSA6nTco+TPXiXCbgP77PclmBMUWOdWL/Pva4QFzNXV3oLYYf5pbEoyNBIxmmQBFSqelzPCGo56hgfrWTONufaSxPilcaMlGmUzidjN2rO21R1wLnwf6RGfo8DFMWTd9pR2X2SLoYA4z9y0aMw8r4N3hG41osVA6KfHgHpyGSrKZWlr/Gkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=99l62lKpyUCta2hOX1HXRUIXlnvNrmlPXaxt+2VRxlg=; b=SN5qQdjYjoJLWRc1Gar2dXOCnhmaijMePkkkRIS71A/jRnhrVj6vN6+LrCdvUudzN9jC4ownfboXEoeY08x9v8ryKjte6Hg5rA2vv5AxTrlLL0WCXSGLdcJ9e2uULMiQiVfX7ZAdAMgsrVwobGibG9yaa4t6HQ2Yc2Wx1m/+IOok9JUa66Gn89wiVaZZx5Rk4hqAKBxhP49XrGla8SxLcTKoB+QkB9Ub4Dz43EUk4FUFGCI3RrBXOkZWo+RWi6HLYdWIcO/DoW1bmQlSc3gpU0hi/chqElcd8debTIORLNQelzLmhJ+1qUxQ32AH6lldnZud99sPjNXkwe8RDnEZ8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=99l62lKpyUCta2hOX1HXRUIXlnvNrmlPXaxt+2VRxlg=; b=KwbD/89FbYyNxpHydcH2KkLoVXAEcXNQqfyQdCMQFpCOC9JkvyOL5ZceWunYq3adx6Gybdfw6NaZVNnpRQxh7/YbGQM3u6hFJ++UlaMbXq4FRhnimz/qIef8lbCPSELpy5QTerO3qFORu+IQLyDJmknKIpD46aS96eshhevOurKFoOrEa3cRFvJpgUDONHutxlBKkKZv0ci+8dqfOiwpwEYFex7AAS759T9YDzw0x6+0z3t80lUoggHG+ueGicwmt5EPtc3sCqh17ZrFYxUBeoyepFDrznNP4IW0oXC4r6u7b48Qy9fPE0VbB5WCxc7m/dsS18Tv7iXx2AXLbvrFQQ== Received: from MW4PR04CA0037.namprd04.prod.outlook.com (2603:10b6:303:6a::12) by CY4PR12MB1608.namprd12.prod.outlook.com (2603:10b6:910:d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.20; Thu, 3 Feb 2022 08:47:17 +0000 Received: from CO1NAM11FT051.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6a:cafe::80) by MW4PR04CA0037.outlook.office365.com (2603:10b6:303:6a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend Transport; Thu, 3 Feb 2022 08:47:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.238) by CO1NAM11FT051.mail.protection.outlook.com (10.13.174.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4951.12 via Frontend Transport; Thu, 3 Feb 2022 08:47:16 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 3 Feb 2022 08:47:16 +0000 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Thu, 3 Feb 2022 00:47:14 -0800 From: Viacheslav Ovsiienko To: CC: , , , Subject: [PATCH v2 1/2] net/mlx5: fix metadata endianness in modify field action Date: Thu, 3 Feb 2022 10:46:51 +0200 Message-ID: <20220203084652.19167-1-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <49fa76c7-30fe-3128-81ac-38779f557f33@intel.com> References: <49fa76c7-30fe-3128-81ac-38779f557f33@intel.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6721de73-6f3d-4969-3c66-08d9e6f1c80b X-MS-TrafficTypeDiagnostic: CY4PR12MB1608:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9fy7i4hdG+4zwUOLOgrRi3xZOGQWOVqMCSvkLxk4gYXBqIjMPDjWPhRJp+6kZOMAvR2yiEvzC08VJFYIF4z14qH51oKYCHAjPGRKUbwxddfJqRMesd3HEX4eUEy2xXNu1/JPXUnUPQB6Ck5sLMOH6UQvigLGS+S7tuG5Mg3DwJzF+ZDg1zC6I9UDNMsGE7eRhSvd44ZEHrIJMM4AaJVL3xJKW+e4HxqFqiFpRJGuqB/9nrjx3RUiVoDLLqjIX+5FEwam8p1US83dDAThosyGyVZfs4s5cxC/dLwzWvwTX+WSaEDNGlViOlQfznJ+R/vj3Ot1+zcE6VuT0e7zb5DFTDJhlQwsPe0CYn+L5gCiSuJ+WH7chi+tXAu5HksQCW3OY+96I1lpoIN5VbzBK3I+WBdgf7O9pJ+8fktYvybpoiZXSzviQCEjgrzvEONxeEVUNMwOUiJKTzRLlpRuHAko7t2Pczia4k3+YLUdjRJ+eF2uRQP+N8y/EI1y/8VJhVpch1aMKwfEI73stiAxY3F30vO8E9QvTvjTa6PSNvdIAMDJgZcaQ4vFY5mUibNQxREKikJATfDndPlVemdFTwqXKB/o5G6/8dxfBd78BCGQDExDA/Bc2/mnBdaC1NoJK+tEpKHRo0SWKewoIyBHYHb8wmhKA+iW8ukT1U0rbV8Ka4aem9E3iPZe79F4rFNeEFc7qA/1ILQc58k2Dz+g5fkQ0w== X-Forefront-Antispam-Report: CIP:12.22.5.238; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(6666004)(336012)(6286002)(36756003)(70586007)(16526019)(7696005)(2906002)(508600001)(82310400004)(81166007)(426003)(1076003)(2616005)(8676002)(54906003)(70206006)(55016003)(8936002)(26005)(6916009)(356005)(36860700001)(4326008)(186003)(316002)(47076005)(86362001)(5660300002)(83380400001)(40460700003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 08:47:16.6228 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6721de73-6f3d-4969-3c66-08d9e6f1c80b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.238]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT051.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1608 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org As modify field action immediate source parameter the metadata should follow the CPU endianness (according to SET_META action structure format), and mlx5 PMD wrongly handled the immediate parameter metadata buffer as big-endian, resulting in wrong metadata set action with incorrect endianness. Fixes: 40c8fb1fd3b3 ("net/mlx5: update modify field action") Cc: stable@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index af90a7fd0a..10ef2af06a 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -1867,7 +1867,7 @@ flow_dv_convert_action_modify_field struct field_modify_info dcopy[MLX5_ACT_MAX_MOD_FIELDS] = { {0, 0, 0} }; uint32_t mask[MLX5_ACT_MAX_MOD_FIELDS] = {0, 0, 0, 0, 0}; - uint32_t type; + uint32_t type, meta = 0; uint32_t shift = 0; if (conf->src.field == RTE_FLOW_FIELD_POINTER || @@ -1880,6 +1880,11 @@ flow_dv_convert_action_modify_field item.spec = conf->src.field == RTE_FLOW_FIELD_POINTER ? (void *)(uintptr_t)conf->src.pvalue : (void *)(uintptr_t)&conf->src.value; + if (conf->dst.field == RTE_FLOW_FIELD_META) { + meta = *(const unaligned_uint32_t *)item.spec; + meta = rte_cpu_to_be_32(meta); + item.spec = &meta; + } } else { type = MLX5_MODIFICATION_TYPE_COPY; /** For COPY fill the destination field (dcopy) without mask. */