diff mbox series

[v2,10/12] net/txgbe: fix debug log

Message ID	20220209104213.602728-11-jiawenwu@trustnetic.com (mailing list archive)
State	Rejected, archived
Delegated to:	Ferruh Yigit
Headers	From: Jiawen Wu <jiawenwu@trustnetic.com> To: dev@dpdk.org Cc: Jiawen Wu <jiawenwu@trustnetic.com>, stable@dpdk.org Subject: [PATCH v2 10/12] net/txgbe: fix debug log Date: Wed, 9 Feb 2022 18:42:11 +0800 Message-Id: <20220209104213.602728-11-jiawenwu@trustnetic.com> In-Reply-To: <20220209104213.602728-1-jiawenwu@trustnetic.com> References: <20220209104213.602728-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign2 Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Wangxun fixes and supports \| [v2,00/12] Wangxun fixes and supports [v2,01/12] net/ngbe: fix failed to receive packets [v2,02/12] net/ngbe: fix link interrupt sometimes lost [v2,03/12] net/ngbe: fix Tx pending [v2,04/12] net/ngbe: fix RxTx packet statistics [v2,05/12] net/ngbe: optimize the PHY initialization process [v2,06/12] net/ngbe: add support to custom PHY interfaces [v2,07/12] net/ngbe: add LED OEM support [v2,08/12] net/ngbe: fix debug log [v2,09/12] net/txgbe: add LED OEM support [v2,10/12] net/txgbe: fix debug log [v2,11/12] net/txgbe: fix to set link up and down [v2,12/12] net/txgbe: fix KR auto-negotiation

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Jiawen Wu Feb. 9, 2022, 10:42 a.m. UTC

  Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix
that double line was added by using 'DEBUGOUT'.

Fixes: 7dc117068a7c ("net/txgbe: support probe and remove")
Cc: stable@dpdk.org

Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
 drivers/net/txgbe/txgbe_logs.h | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Ferruh Yigit Feb. 9, 2022, 7:07 p.m. UTC | #1

On 2/9/2022 10:42 AM, Jiawen Wu wrote:
> Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix
> that double line was added by using 'DEBUGOUT'.
> 
> Fixes: 7dc117068a7c ("net/txgbe: support probe and remove")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

Comments to ngbe patch (8/12) applies here too.

> ---
>   drivers/net/txgbe/txgbe_logs.h | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/txgbe/txgbe_logs.h b/drivers/net/txgbe/txgbe_logs.h
> index 67e9bfb3af..8fa80a69b2 100644
> --- a/drivers/net/txgbe/txgbe_logs.h
> +++ b/drivers/net/txgbe/txgbe_logs.h
> @@ -17,10 +17,13 @@ extern int txgbe_logtype_init;
>   		"%s(): " fmt "\n", __func__, ##args)
>   
>   extern int txgbe_logtype_driver;
> -#define PMD_DRV_LOG(level, fmt, args...) \
> +#define PMD_TLOG_DRIVER(level, fmt, args...) \
>   	rte_log(RTE_LOG_ ## level, txgbe_logtype_driver, \
>   		"%s(): " fmt "\n", __func__, ##args)
>   
> +#define PMD_DRV_LOG(level, fmt, args...) \
> +	PMD_TLOG_DRIVER(level, fmt "\n", ## args)
> +
>   #ifdef RTE_LIBRTE_TXGBE_DEBUG_RX
>   extern int txgbe_logtype_rx;
>   #define PMD_RX_LOG(level, fmt, args...) \
> @@ -48,11 +51,11 @@ extern int txgbe_logtype_tx_free;
>   #define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)
>   #endif
>   
> -#define TLOG_DEBUG(fmt, args...)  PMD_DRV_LOG(DEBUG, fmt, ##args)
> +#define TLOG_DEBUG(fmt, args...)  PMD_TLOG_DRIVER(DEBUG, fmt, ##args)
>   
>   #define DEBUGOUT(fmt, args...)    TLOG_DEBUG(fmt, ##args)
>   #define PMD_INIT_FUNC_TRACE()     TLOG_DEBUG(" >>")
> -#define DEBUGFUNC(fmt)            TLOG_DEBUG(fmt)
> +#define DEBUGFUNC(fmt)            do { } while (0)
>   
>   extern int txgbe_logtype_bp;
>   #define BP_LOG(fmt, args...) \

diff mbox series

Patch

diff --git a/drivers/net/txgbe/txgbe_logs.h b/drivers/net/txgbe/txgbe_logs.h
index 67e9bfb3af..8fa80a69b2 100644
--- a/drivers/net/txgbe/txgbe_logs.h
+++ b/drivers/net/txgbe/txgbe_logs.h
@@ -17,10 +17,13 @@  extern int txgbe_logtype_init;
 		"%s(): " fmt "\n", __func__, ##args)
 
 extern int txgbe_logtype_driver;
-#define PMD_DRV_LOG(level, fmt, args...) \
+#define PMD_TLOG_DRIVER(level, fmt, args...) \
 	rte_log(RTE_LOG_ ## level, txgbe_logtype_driver, \
 		"%s(): " fmt "\n", __func__, ##args)
 
+#define PMD_DRV_LOG(level, fmt, args...) \
+	PMD_TLOG_DRIVER(level, fmt "\n", ## args)
+
 #ifdef RTE_LIBRTE_TXGBE_DEBUG_RX
 extern int txgbe_logtype_rx;
 #define PMD_RX_LOG(level, fmt, args...) \
@@ -48,11 +51,11 @@  extern int txgbe_logtype_tx_free;
 #define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)
 #endif
 
-#define TLOG_DEBUG(fmt, args...)  PMD_DRV_LOG(DEBUG, fmt, ##args)
+#define TLOG_DEBUG(fmt, args...)  PMD_TLOG_DRIVER(DEBUG, fmt, ##args)
 
 #define DEBUGOUT(fmt, args...)    TLOG_DEBUG(fmt, ##args)
 #define PMD_INIT_FUNC_TRACE()     TLOG_DEBUG(" >>")
-#define DEBUGFUNC(fmt)            TLOG_DEBUG(fmt)
+#define DEBUGFUNC(fmt)            do { } while (0)
 
 extern int txgbe_logtype_bp;
 #define BP_LOG(fmt, args...) \