diff mbox series

[v1] maintainers: update for testpmd

Message ID 20220209150105.1005313-1-yuying.zhang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] maintainers: update for testpmd |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Zhang, Yuying Feb. 9, 2022, 3:01 p.m. UTC 
  Add Cristian as maintainer of test-pmd/cmdline_tm.* files.

Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Cristian Dumitrescu Feb. 9, 2022, 9:23 a.m. UTC | #1 
> -----Original Message-----
> From: Zhang, Yuying <yuying.zhang@intel.com>
> Sent: Wednesday, February 9, 2022 3:01 PM
> To: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun
> <xiaoyun.li@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; thomas@monjalon.net
> Cc: Zhang, Yuying <yuying.zhang@intel.com>
> Subject: [PATCH v1] maintainers: update for testpmd
> 
> Add Cristian as maintainer of test-pmd/cmdline_tm.* files.
> 
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c65b753c6b..cab1821b11 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -406,6 +406,7 @@ F: lib/ethdev/rte_flow*
>  Traffic Management API - EXPERIMENTAL
>  M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>  T: git://dpdk.org/next/dpdk-next-net
> +F: app/test-pmd/cmdline_tm.*
>  F: lib/ethdev/rte_tm*
> 
>  Traffic Metering and Policing API - EXPERIMENTAL
> --
> 2.25.1

Hi Yoying,

I did not author these testpmd files myself, can you please remove my name from here and add the author instead?

Thanks,
Cristian
Ferruh Yigit Feb. 9, 2022, 2:12 p.m. UTC | #2 
On 2/9/2022 9:23 AM, Dumitrescu, Cristian wrote:
> 
> 
>> -----Original Message-----
>> From: Zhang, Yuying <yuying.zhang@intel.com>
>> Sent: Wednesday, February 9, 2022 3:01 PM
>> To: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun
>> <xiaoyun.li@intel.com>; Dumitrescu, Cristian
>> <cristian.dumitrescu@intel.com>; thomas@monjalon.net
>> Cc: Zhang, Yuying <yuying.zhang@intel.com>
>> Subject: [PATCH v1] maintainers: update for testpmd
>>
>> Add Cristian as maintainer of test-pmd/cmdline_tm.* files.
>>
>> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index c65b753c6b..cab1821b11 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -406,6 +406,7 @@ F: lib/ethdev/rte_flow*
>>   Traffic Management API - EXPERIMENTAL
>>   M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>   T: git://dpdk.org/next/dpdk-next-net
>> +F: app/test-pmd/cmdline_tm.*
>>   F: lib/ethdev/rte_tm*
>>
>>   Traffic Metering and Policing API - EXPERIMENTAL
>> --
>> 2.25.1
> 
> Hi Yoying,
> 
> I did not author these testpmd files myself, can you please remove my name from here and add the author instead?
> 

Hi Cristian,

Sorry, I didn't get the request.

Those testpmd files are directly related to the TM, they are added to test
the TM APIs.

 From maintenance point of view, you can comment better to changes to these
files than testpmd maintainers because they are related to the TM functionality,
and this is what happens in practice, waiting for your or Jasvinder's ack.

Is your request not to add these files under TM?
Or are you asking adding Jasvinder as additional maintainer to " Traffic Management"?


And indeed we should do the same for the 'app/test-pmd/cmdline_mtr.*' files and
add them under "Traffic Metering and Policing" component, if there will be a new
version I suggest adding this change.

  
Thanks,
ferruh
Ferruh Yigit Feb. 9, 2022, 2:27 p.m. UTC | #3 
On 2/9/2022 3:01 PM, Yuying Zhang wrote:
> Add Cristian as maintainer of test-pmd/cmdline_tm.* files.
> 

Hi Yuying,

Can you please update above wording slightly, instead of referring to
maintainer name, can you please say something like:

Move ' test-pmd/cmdline_tm.' under "Traffic Management API" component.

> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c65b753c6b..cab1821b11 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -406,6 +406,7 @@ F: lib/ethdev/rte_flow*
>   Traffic Management API - EXPERIMENTAL
>   M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>   T: git://dpdk.org/next/dpdk-next-net
> +F: app/test-pmd/cmdline_tm.*
>   F: lib/ethdev/rte_tm*
>   
>   Traffic Metering and Policing API - EXPERIMENTAL
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index c65b753c6b..cab1821b11 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -406,6 +406,7 @@  F: lib/ethdev/rte_flow*
 Traffic Management API - EXPERIMENTAL
 M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
+F: app/test-pmd/cmdline_tm.*
 F: lib/ethdev/rte_tm*
 
 Traffic Metering and Policing API - EXPERIMENTAL