compress/mlx5: support out-of-space status
Checks
Commit Message
When trying to dequeue, an OP may fail due to insufficient space for the
OP output, the compressdev API defines out-of-space for OP status.
The driver can detect out-of-space errors and report them to the user.
Check if hw_error_syndrome specifies out-of-space and set the OP
status accordingly.
Also added an error message for a case of missing B-final flag.
Fixes: f8c97babc9f4 ("compress/mlx5: add data-path functions")
Cc: stable@dpdk.org
Signed-off-by: Raja Zidane <rzidane@nvidia.com>
---
Acked-by: Matan Azrad matan@nvidia.com
drivers/common/mlx5/mlx5_prm.h | 5 +++++
drivers/compress/mlx5/mlx5_compress.c | 12 +++++++++++-
2 files changed, 16 insertions(+), 1 deletion(-)
@@ -249,6 +249,9 @@
/* Maximum number of DS in WQE. Limited by 6-bit field. */
#define MLX5_DSEG_MAX 63
+/* The 32 bit syndrome offset in struct mlx5_err_cqe. */
+#define MLX5_ERROR_CQE_SYNDROME_OFFSET 52
+
/* The completion mode offset in the WQE control segment line 2. */
#define MLX5_COMP_MODE_OFFSET 2
@@ -559,6 +562,8 @@ struct mlx5_rdma_write_wqe {
#define MLX5_GGA_COMP_LOG_BLOCK_SIZE_MAX 15u
#define MLX5_GGA_COMP_LOG_DYNAMIC_SIZE_MAX 15u
#define MLX5_GGA_COMP_LOG_DYNAMIC_SIZE_MIN 0u
+#define MLX5_GGA_COMP_OUT_OF_SPACE_SYNDROME_BE 0x29D0084
+#define MLX5_GGA_COMP_MISSING_BFINAL_SYNDROME_BE 0x29D0011
struct mlx5_wqe_metadata_seg {
uint32_t mmo_control_31_0; /* mmo_control_63_32 is in ctrl_seg.imm */
@@ -562,7 +562,17 @@ mlx5_compress_cqe_err_handle(struct mlx5_compress_qp *qp,
qp->qp.wqes;
volatile struct mlx5_gga_compress_opaque *opaq = qp->opaque_mr.addr;
- op->status = RTE_COMP_OP_STATUS_ERROR;
+ volatile uint32_t *synd_word = RTE_PTR_ADD(cqe, MLX5_ERROR_CQE_SYNDROME_OFFSET);
+ switch (*synd_word) {
+ case MLX5_GGA_COMP_OUT_OF_SPACE_SYNDROME_BE:
+ op->status = RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED;
+ DRV_LOG(DEBUG, "OUT OF SPACE error, output is bigger than dst buffer.");
+ break;
+ case MLX5_GGA_COMP_MISSING_BFINAL_SYNDROME_BE:
+ DRV_LOG(DEBUG, "The last compressed block missed the B-final flag; maybe the compressed data is not complete or garbaged?");
+ default:
+ op->status = RTE_COMP_OP_STATUS_ERROR;
+ }
op->consumed = 0;
op->produced = 0;
op->output_chksum = 0;