diff mbox series

[1/6] net/hns3: remove duplicate macro definition

Message ID	20220228032146.37407-2-humin29@huawei.com (mailing list archive)
State	Accepted, archived
Delegated to:	Ferruh Yigit
Headers	From: "Min Hu (Connor)" <humin29@huawei.com> To: <dev@dpdk.org> CC: <ferruh.yigit@intel.com>, <thomas@monjalon.net> Subject: [PATCH 1/6] net/hns3: remove duplicate macro definition Date: Mon, 28 Feb 2022 11:21:41 +0800 Message-ID: <20220228032146.37407-2-humin29@huawei.com> In-Reply-To: <20220228032146.37407-1-humin29@huawei.com> References: <20220228032146.37407-1-humin29@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	bugfixes for hns3 PMD \| [0/6] bugfixes for hns3 PMD [1/6] net/hns3: remove duplicate macro definition [2/6] net/hns3: fix inconsistent enabled RSS behavior [3/6] net/hns3: remove unnecessary RSS switch [4/6] net/hns3: fix the time waiting for PF reset completion [5/6] net/hns3: fix RSS TC mode entry [6/6] net/hns3: fix VF RSS TC mode entry

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

humin (Q) Feb. 28, 2022, 3:21 a.m. UTC

  From: Jie Hai <haijie1@huawei.com>

This patch fixes duplicate macro definition of HNS3_RSS_CFG_TBL_SIZE.

Fixes: 737f30e1c3ab ("net/hns3: support command interface with firmware")
Cc: stable@dpdk.org

Signed-off-by: Jie Hai <haijie1@huawei.com>
---
 drivers/net/hns3/hns3_cmd.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Ferruh Yigit Feb. 28, 2022, 5:46 p.m. UTC | #1

On 2/28/2022 3:21 AM, Min Hu (Connor) wrote:
> From: Jie Hai <haijie1@huawei.com>
> 
> This patch fixes duplicate macro definition of HNS3_RSS_CFG_TBL_SIZE.
> 
> Fixes: 737f30e1c3ab ("net/hns3: support command interface with firmware")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jie Hai <haijie1@huawei.com>

Except from 2/6, 3/6, 4/6
Series applied to dpdk-next-net/main, thanks.

For 2/6, 3/6 can be good to wait for more comment on
RSS configuration.

For 4/6 can you please send a new version.

Ferruh Yigit March 2, 2022, 11:22 a.m. UTC | #2

On 2/28/2022 5:46 PM, Ferruh Yigit wrote:
> On 2/28/2022 3:21 AM, Min Hu (Connor) wrote:
>> From: Jie Hai <haijie1@huawei.com>
>>
>> This patch fixes duplicate macro definition of HNS3_RSS_CFG_TBL_SIZE.
>>
>> Fixes: 737f30e1c3ab ("net/hns3: support command interface with firmware")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jie Hai <haijie1@huawei.com>
> 
> Except from 2/6, 3/6, 4/6
> Series applied to dpdk-next-net/main, thanks.
> 

Hi Connor,

I am adding your explicit ack in the next-net for merged patches,
please let me if you have an objection.

Acked-by: Min Hu (Connor) <humin29@huawei.com>

> 
> For 2/6, 3/6 can be good to wait for more comment on
> RSS configuration.
> 
> For 4/6 can you please send a new version.

diff mbox series

Patch

diff --git a/drivers/net/hns3/hns3_cmd.h b/drivers/net/hns3/hns3_cmd.h
index 81bc9e9d98..f9addc6069 100644
--- a/drivers/net/hns3/hns3_cmd.h
+++ b/drivers/net/hns3/hns3_cmd.h
@@ -603,7 +603,6 @@  struct hns3_cfg_gro_status_cmd {
 
 #define HNS3_RSS_HASH_KEY_OFFSET_B	4
 
-#define HNS3_RSS_CFG_TBL_SIZE	16
 #define HNS3_RSS_HASH_KEY_NUM	16
 /* Configure the algorithm mode and Hash Key, opcode:0x0D01 */
 struct hns3_rss_generic_config_cmd {