From patchwork Tue Mar 1 11:09:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 108429 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E24E5A034F; Tue, 1 Mar 2022 12:09:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A600C40DF6; Tue, 1 Mar 2022 12:09:48 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2040.outbound.protection.outlook.com [40.107.243.40]) by mails.dpdk.org (Postfix) with ESMTP id 977F6407FF for ; Tue, 1 Mar 2022 12:09:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hdn4bkDSi8RsKHg9vsPZB+SNFBHV3K/nl+anBzExFYFYhtixFbwcmnyozn+CrlvgIdcbM+gp8earcFE/m0u3li7gBOL9VNloLkDgy5hS27xLZkuDUoEXNNE/ASxX/v6uiibrLKvLweWusgxoTT03Cf8/l1sHtbxjRziO+MhxFstmucL5hI/QiAx6PPjCI7yBjFln925DD9Hnf16X69doc6EtKnpRTLIA/d883Bj29hxDAobxUmKqSQwhlZ+RK5qplAKBl/ocQLMtyyhWCesqxIGK5Q25enVFTtKm2WWmLwnu5KlaeaZ2vYgeB7E/TpbqyqbfaXOknLHgImKkHQx43g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V+MVoepvE23082vooWVXQR22JUMVK7qgB+hLNmH1K6Y=; b=EXxkzNV3kvz3RS+9rwtLxsOUrWKhRelTKG8ampuq1831K5VWCFDQspzvx/2XIvajJ3hOo6qO4EukEvmPspVb3VGf3NuTuI9p8p9Rl84FiKnjihZfyFq8dbuuwO/B0rheW8RmQrQBStfMW7m2pZ1/jNO+pCFZcj3tSbZe4vRQNvYZH8DMPTHi33HzC8sRfqS6v3WihTQbldcTsM0nKTQmbLQDx1514SCICuAY0NePgoZRyWsJjqpcqhABcRtv2ong/vp8JH7O9wOYwYBJm76HVJjSVA8QhaZuX5R/Vy6UP1Ra7ShIZmMD/xW6MlW5pzk5cvNPVubiO+wVwd+euCZw3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.236) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V+MVoepvE23082vooWVXQR22JUMVK7qgB+hLNmH1K6Y=; b=WzRFqfNsj97tlHZ+mA3XGOFzzMh5GfQzCE/aC/XMP2jAqVGKd3xMuH0G6ABOrvDeJRS4B6AWYHG5ovytvk/SgSwuRzAQVqjqSRxIlSqw79+6TkQeeJOnf3O3tj3Md0wsKfnuM4z2ERzJPn4hZXW/55xcdUDC3yo8in9zZ3CRUwC4k6SYBzzMd0PnmCv8mFkSMc43MvExgz2IkJWa6f56Cu7e12dXmesz4RqSHjTBh7X03dNT3uTecpfIhu2vEsNsnMDYPGQbP6ze+MHg5wBRLwZPCJF1hol3YBe2TyBGfG20UrstH8neEk7H1npmxLSskkBGopTPSv9Qwd2VDRA8lw== Received: from BN9PR03CA0374.namprd03.prod.outlook.com (2603:10b6:408:f7::19) by DM6PR12MB3257.namprd12.prod.outlook.com (2603:10b6:5:184::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Tue, 1 Mar 2022 11:09:44 +0000 Received: from BN8NAM11FT064.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f7:cafe::4e) by BN9PR03CA0374.outlook.office365.com (2603:10b6:408:f7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24 via Frontend Transport; Tue, 1 Mar 2022 11:09:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.236) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.236 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.236; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.236) by BN8NAM11FT064.mail.protection.outlook.com (10.13.176.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 11:09:44 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by DRHQMAIL109.nvidia.com (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 1 Mar 2022 11:09:43 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Tue, 1 Mar 2022 03:09:42 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9 via Frontend Transport; Tue, 1 Mar 2022 03:09:40 -0800 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko Subject: [PATCH v2] common/mlx5: fix missing default devargs initialization Date: Tue, 1 Mar 2022 13:09:35 +0200 Message-ID: <20220301110935.3958252-1-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220227075753.3466574-1-michaelba@nvidia.com> References: <20220227075753.3466574-1-michaelba@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 454a1602-d88c-4680-418b-08d9fb73fdb4 X-MS-TrafficTypeDiagnostic: DM6PR12MB3257:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TRQTOTUfypuUT0WSwpZ2+NtHMzqqf2EOdkxMY4O82bFNrAZUMfrLA1bWcn8tVY+lrNR2J/8HY51T/MdRJfIFWr63mJFIgP1JJsC9+WJORQg/JhQ6+/sD1sSq2U6wiTks7fZCf5LAiqH1MFUvPwcHfxjxnMTEgjTLgdi1n2Wnw6ZkmCoc4CSGiClkORBnvxENxyp4CbV/7rUC4zYQo2ib+QOPGSpmrbx1FSnrBaUfGBUKKVecAayzoL1SMWbRhtH1d4awLW7QEYpe24A42oOHCQ+IKntP40FpqNTW3MUTbCPgT9YgXCwxOaIDuf+n+uiYfjQEk32p99GI4CYE9gjETw4t89KqTnX8mdIZ1mBpXB/wQp9LCZkCaA20p5Obk1h5XmhUuLG+2zeU4cDVLLGcKr52sIJ5hWKmDowj3ormcJ33iBOOjv7VkXzQPhX/jWmJCAkiCN6frTVpGwDVHXf2J7mFnCfGyo/S/3bqmjEol8P2IM8je1JArlGEV2aFeWkX+swuCa2EzuXrX+aVHFfwNNk9yMXYM0FejCXXURxSX3NhufDcUrvo42uKpE6wc2tKQCyf3Oc/Yx993bhpL6186G/GB6OGlScZKxPM+aEcl/Zu3C9GUGiv4kSgIs6r/T7phdcUdciwJHzQqSe9ZoswYxUOY8Oc5I4qNYFMgHCnm5DipbaxvoOs7wAoProBi1ZjMnzU1PFM4cUCyHvL6wTY0w== X-Forefront-Antispam-Report: CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(336012)(316002)(86362001)(8676002)(426003)(82310400004)(356005)(107886003)(70586007)(70206006)(81166007)(4326008)(2616005)(8936002)(186003)(7696005)(6666004)(26005)(508600001)(54906003)(6916009)(6286002)(1076003)(40460700003)(2906002)(83380400001)(36860700001)(5660300002)(55016003)(47076005)(36756003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 11:09:44.4176 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 454a1602-d88c-4680-418b-08d9fb73fdb4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT064.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3257 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Device arguments list is provided along with its identifier as part of EAL arguments. The arguments specified in the list are taken from it, and the rest is initialized to the default values. When no list is provided at all, all arguments should have been initialized to their default values. However, they are mistakenly initialized to zero which may be a valid value for some. This patch initializes the default values before checking whether arguments have been specified. Fixes: a729d2f093e9 ("common/mlx5: refactor devargs management") Signed-off-by: Michael Baum Acked-by: Matan Azrad --- v2: updating Fixes reference hash. drivers/common/mlx5/mlx5_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c index 94c303ce81..ef1604d223 100644 --- a/drivers/common/mlx5/mlx5_common.c +++ b/drivers/common/mlx5/mlx5_common.c @@ -326,8 +326,6 @@ mlx5_common_config_get(struct mlx5_kvargs_ctrl *mkvlist, }; int ret = 0; - if (mkvlist == NULL) - return 0; /* Set defaults. */ config->mr_ext_memseg_en = 1; config->mr_mempool_reg_en = 1; @@ -335,6 +333,8 @@ mlx5_common_config_get(struct mlx5_kvargs_ctrl *mkvlist, config->dbnc = MLX5_ARG_UNSET; config->device_fd = MLX5_ARG_UNSET; config->pd_handle = MLX5_ARG_UNSET; + if (mkvlist == NULL) + return 0; /* Process common parameters. */ ret = mlx5_kvargs_process(mkvlist, params, mlx5_common_args_check_handler, config);