From patchwork Wed Mar 2 07:58:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 108476 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0F53A04A4; Wed, 2 Mar 2022 08:58:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21B5442707; Wed, 2 Mar 2022 08:58:40 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2086.outbound.protection.outlook.com [40.107.212.86]) by mails.dpdk.org (Postfix) with ESMTP id 2EC6040141 for ; Wed, 2 Mar 2022 08:58:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iKV6Xs5fplzrpuZPB7lO+R+S5K+SlwRUjPloOEYt0r+Qg8B4DeYUV83Z/EQIHsxcKrbuZmWapbFOsUayGfOlV08/PQlxrEU+bcyFgCmgQTOBmeldczfhyXBUH5BHaDjpfYzeDJ9gHaoVw0HfiB9j8mceQamthy6Kc9iMCikjZz9pWKFNvxlE4OHWfRaK46roKkm6YIjuMzCHSchn13Y12GFKFG4/WJVPOOtJTW3E+ImZe1xMWgpg3KprjjFX+OTs9bUGMh6VX5/+EmwWHxH9wfUNsAhW69Gy5PI35Mt0LdI6bD+2zksw4/PGRtBXaoD3qMl4Xn5fRsW/cKeUrzT6og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5phtzYsyqLR3NOfMc96T+89wiczwOgJXFPjIcOyZRbQ=; b=ntaNKzg29geMc300TglqrzRRT9llTbObfMnegz6qHQcpeK+Gjlgnh8j0dGubL8d3Ox0IxZwov7AtUqKiLnTGQzanMT/KD0mgVo1fA+NG/Qij1OoKum/Nkg3bOAanp65L33V0OUST1AZgMzlxkaydGaH1Ngwm36UEZhih10XW4olrEToMgud+bJg3NXRuSApWeZGHnmsTAmCIA+O/lY3XP8HZ1SNcnDZEvVAJg55ec+agEL9ENSIFHDL9ZLSEaQ/dEr33zuS8QwKyCYMJHvxC7zfGG1tIRbyq/uxno/zfQylBC7kSCFDVEoiCjOdvyf0UZZy9QqPjLOKIic21bqpZwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.235) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5phtzYsyqLR3NOfMc96T+89wiczwOgJXFPjIcOyZRbQ=; b=MEJtZJalALfxx6g6Ot2iB6C+3zC7QoHrvCrddFc9d1rD5xP9oPaFuTS/fPeOXLV63hGzsyAiKhCa0mvxsSs4bdY++JZTx616meZbl5cYKZy0cAWFGmT42/2+NJbbIHjMzu0ZFcQerLx3EGT+ipkwOx4C2/VKbcUM9nWiC7ZB5vcVjuht2d8AOFa7KnPObujuT811DJjp9t6e1U4aoIkyyY8FHwp4SH1UnPza4X8326WsMIWDV3E6/ocn7Hw+Dy4kiza0H/+ZNmrHV9pPSrJbzLI9LdGXmxtc+V2BwUrRp5OfoJiKPlAjF4Zfty6jIeyYiJtjY/VIf859tg4xKVgY2w== Received: from CO1PR15CA0102.namprd15.prod.outlook.com (2603:10b6:101:21::22) by DM4PR12MB5168.namprd12.prod.outlook.com (2603:10b6:5:397::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Wed, 2 Mar 2022 07:58:37 +0000 Received: from CO1NAM11FT044.eop-nam11.prod.protection.outlook.com (2603:10b6:101:21:cafe::df) by CO1PR15CA0102.outlook.office365.com (2603:10b6:101:21::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14 via Frontend Transport; Wed, 2 Mar 2022 07:58:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.235) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.235 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.235; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.235) by CO1NAM11FT044.mail.protection.outlook.com (10.13.175.188) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5038.14 via Frontend Transport; Wed, 2 Mar 2022 07:58:37 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 2 Mar 2022 07:58:36 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Tue, 1 Mar 2022 23:58:35 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9 via Frontend Transport; Tue, 1 Mar 2022 23:58:34 -0800 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko Subject: [PATCH v2 1/2] net/mlx5: fix external RQ dereferencing Date: Wed, 2 Mar 2022 09:58:22 +0200 Message-ID: <20220302075823.4141453-2-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220302075823.4141453-1-michaelba@nvidia.com> References: <20220302074801.4140079-1-michaelba@nvidia.com> <20220302075823.4141453-1-michaelba@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d94a817e-044c-4ca5-ecbb-08d9fc22752a X-MS-TrafficTypeDiagnostic: DM4PR12MB5168:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LEBI+I63kbvrZAnz8m1BKbl+Ahea0hbhzT1GNfzzh5FWagMzjdaz+4tWC8yOJ9UjSzBCYcbYlXSnxVR18qvTfcHGUMHRsyNJwCAI/SJ+QMcLa7LCJHyf8vTgCWPzRY7wwHT5OPz1f1NaF0pnp0KFtIYzJZP8ezsYAj5NMYzwOCh+5GmgfQn5qgD1Dv8FNc6sDckGG59r5JQuQvByCLy8W59Fxrljdgxb5JCH1vjyAw465BRopNEGoOuQq3FtD74cr7yBAWbPEG5caXxURB2dFiBed/vxC/BCib08C6W4czPGMbB6u6FhSOW9ZX65ZVFOW0LgoiBSdNWXFuaBUGMQjaTysu5nsgUVLuAfZEqSSzCCX9Yq65yGk8FStExoADjnEii0ZbuJ6UsdOFlRZKOCMzlBeuyZhJcAOzrwcenESEC5pXX7onrb4vGKVTHQ/h/g+POToDlCEm9/0AKzLzujGfi3t4NoD+drjaSFDuGH3Y++mc0+lGHPxZ3WsrtlQ438yIXlCpnXAa18MGAKHOMQ/vb9S4U9C22g4uZR9pyv8iz4ozZ31j1yStsNYpbbl+ueKz/7Ir00cIEYyu0Ksvq3dNvzPKO1FFKY3k5OT6iHGcMVw/dnfura5QXmh6gXBaVSTCA3d4MkmXFgAwi7oBXlfmExQS50ee85yBqolT6yITBFkvbXvN4Amv6xC4e8q/zNcivtwFXeNLkEtNvwYWHEIQ== X-Forefront-Antispam-Report: CIP:12.22.5.235; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(5660300002)(2616005)(4326008)(336012)(36860700001)(81166007)(2906002)(8676002)(26005)(426003)(186003)(1076003)(82310400004)(356005)(70586007)(70206006)(86362001)(107886003)(316002)(40460700003)(54906003)(6916009)(6666004)(7696005)(6286002)(36756003)(55016003)(8936002)(47076005)(83380400001)(508600001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 07:58:37.3377 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d94a817e-044c-4ca5-ecbb-08d9fc22752a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.235]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT044.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5168 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When an indirection table is destroyed, each RX queue related to it, should be dereferenced. The regular queues are indeed dereferenced. However, the external RxQs are not. This patch adds dereferencing for external RxQs too. Fixes: 311b17e669ab ("net/mlx5: support queue/RSS actions for external Rx queue") Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 41 ++++++++++++++++++++++++++----------- 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index ff293d9d56..19c75b7b32 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -2143,6 +2143,30 @@ mlx5_ext_rxq_get(struct rte_eth_dev *dev, uint16_t idx) return &priv->ext_rxqs[idx - MLX5_EXTERNAL_RX_QUEUE_ID_MIN]; } +/** + * Dereference a list of Rx queues. + * + * @param dev + * Pointer to Ethernet device. + * @param queues + * List of Rx queues to deref. + * @param queues_n + * Number of queues in the array. + */ +static void +mlx5_rxqs_deref(struct rte_eth_dev *dev, uint16_t *queues, + const uint32_t queues_n) +{ + uint32_t i; + + for (i = 0; i < queues_n; i++) { + if (mlx5_is_external_rxq(dev, queues[i])) + claim_nonzero(mlx5_ext_rxq_deref(dev, queues[i])); + else + claim_nonzero(mlx5_rxq_deref(dev, queues[i])); + } +} + /** * Release a Rx queue. * @@ -2377,7 +2401,7 @@ mlx5_ind_table_obj_release(struct rte_eth_dev *dev, bool deref_rxqs) { struct mlx5_priv *priv = dev->data->dev_private; - unsigned int i, ret; + unsigned int ret; rte_rwlock_write_lock(&priv->ind_tbls_lock); ret = __atomic_sub_fetch(&ind_tbl->refcnt, 1, __ATOMIC_RELAXED); @@ -2387,10 +2411,8 @@ mlx5_ind_table_obj_release(struct rte_eth_dev *dev, if (ret) return 1; priv->obj_ops.ind_table_destroy(ind_tbl); - if (deref_rxqs) { - for (i = 0; i != ind_tbl->queues_n; ++i) - claim_nonzero(mlx5_rxq_deref(dev, ind_tbl->queues[i])); - } + if (deref_rxqs) + mlx5_rxqs_deref(dev, ind_tbl->queues, ind_tbl->queues_n); mlx5_free(ind_tbl); return 0; } @@ -2443,7 +2465,7 @@ mlx5_ind_table_obj_setup(struct rte_eth_dev *dev, struct mlx5_priv *priv = dev->data->dev_private; uint32_t queues_n = ind_tbl->queues_n; uint16_t *queues = ind_tbl->queues; - unsigned int i = 0, j; + unsigned int i = 0; int ret = 0, err; const unsigned int n = rte_is_power_of_2(queues_n) ? log2above(queues_n) : @@ -2471,12 +2493,7 @@ mlx5_ind_table_obj_setup(struct rte_eth_dev *dev, error: if (ref_qs) { err = rte_errno; - for (j = 0; j < i; j++) { - if (mlx5_is_external_rxq(dev, queues[j])) - mlx5_ext_rxq_deref(dev, queues[j]); - else - mlx5_rxq_deref(dev, queues[j]); - } + mlx5_rxqs_deref(dev, queues, i); rte_errno = err; } DRV_LOG(DEBUG, "Port %u cannot setup indirection table.",