From patchwork Mon Mar 7 22:52:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thinh Tran X-Patchwork-Id: 108589 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5071A0093; Mon, 7 Mar 2022 23:53:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EA1441238; Mon, 7 Mar 2022 23:53:18 +0100 (CET) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mails.dpdk.org (Postfix) with ESMTP id CBF544122E for ; Mon, 7 Mar 2022 23:53:16 +0100 (CET) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 227MO2Io028572 for ; Mon, 7 Mar 2022 22:53:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=Yp+sZ6vLhMt50Qd8MiMJZSmQkqA2hJ/pcRzoyKV5fIM=; b=VmYa1jOXC3Ugp6U3IbldEoLtBKqAUvESCbO3xNyLU9eQOka95iuy89CQfcFwea10XgS4 sk7UmSL/j7LaeXRXPHJmiF2E42ZtPh+YHjneMlM0/QBuheeCzCyg/DbtUpCNwi2byfJB SMyxag5+/lruSlN/j8eSNnhL0yGSqSZjhk7G3hEGzvyji+FNIACWp6aZRl3rNoR9Dnum cUv07Z1I+s04D8MvFymQzhdpZaVmZMCq6VYAacPbvHwUaaShV8EzUX863r0pBs989vQs xHFvwRjKY89AREedKsg7xlLtQrhKx/d+1te3Nes23gKhjNlxleDde0V5krcWkzGv2YTM 7g== Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com with ESMTP id 3entt7rcf3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 07 Mar 2022 22:53:15 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 227MWtoj031124 for ; Mon, 7 Mar 2022 22:53:14 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma02dal.us.ibm.com with ESMTP id 3ekyg9w5aq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 07 Mar 2022 22:53:14 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 227MrEEm44630378 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Mar 2022 22:53:14 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E8328112065; Mon, 7 Mar 2022 22:53:13 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A0663112061; Mon, 7 Mar 2022 22:53:13 +0000 (GMT) Received: from linux.vnet.ibm.com (unknown [9.40.193.248]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 7 Mar 2022 22:53:13 +0000 (GMT) From: Thinh Tran To: dev@dpdk.org Cc: drc@linux.vnet.ibm.com, Thinh Tran Subject: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl Date: Mon, 7 Mar 2022 17:52:56 -0500 Message-Id: <20220307225256.172328-1-thinhtr@linux.vnet.ibm.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: jEwchqKMBm4hF34KlZ0S0nLuDXSOEtOd X-Proofpoint-ORIG-GUID: jEwchqKMBm4hF34KlZ0S0nLuDXSOEtOd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-07_12,2022-03-04_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 priorityscore=1501 mlxlogscore=912 bulkscore=0 adultscore=0 impostorscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203070117 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I hit a failure during ports drop queue RQ creation when my adapters are on CPU socket ID 1 instead of socket ID 0: .... EAL: Probe PCI driver: mlx5_pci (15b3:1019) device: 0020:01:00.0 (socket 1) EAL: set_mempolicy failed: Invalid argument mlx5_common: Failed to allocate memory for RQ. mlx5_net: Port 0 drop queue RQ creation failed. mlx5_net: Cannot create drop RX queue mlx5_net: probe of PCI device 0020:01:00.0 aborted after encountering an error: Success EAL: Probe PCI driver: mlx5_pci (15b3:1019) device: 0020:01:00.1 (socket 1) EAL: set_mempolicy failed: Invalid argument mlx5_common: Failed to allocate memory for RQ. mlx5_net: Port 0 drop queue RQ creation failed. mlx5_net: Cannot create drop RX queue mlx5_net: probe of PCI device 0020:01:00.1 aborted after encountering an error: Success TELEMETRY: No legacy callbacks, legacy socket not created testpmd: No probed ethernet devices ... The patch sets the correct CPU socket ID for the mlx5_rxq_ctrl before calling the mlx5_rxq_create_devx_rq_resources() which eventually calls mlx5_devx_rq_create() with correct CPU socket ID. Result with this patch: ...... EAL: Probe PCI driver: mlx5_pci (15b3:1019) device: 0020:01:00.0 (socket 1) EAL: Probe PCI driver: mlx5_pci (15b3:1019) device: 0020:01:00.1 (socket 1) TELEMETRY: No legacy callbacks, legacy socket not created Interactive-mode selected ...... Configuring Port 0 (socket 1) Port 0: 0C:42:A1:ED:C1:20 Configuring Port 1 (socket 1) Port 1: 0C:42:A1:ED:C1:21 Checking link statuses... Done Signed-off-by: Thinh Tran Reviewed-by: David Christensen Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_devx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c index af106bda50..5ab092a259 100644 --- a/drivers/net/mlx5/mlx5_devx.c +++ b/drivers/net/mlx5/mlx5_devx.c @@ -947,6 +947,8 @@ mlx5_rxq_devx_obj_drop_create(struct rte_eth_dev *dev) rte_errno = ENOMEM; goto error; } + /* set the CPU socket ID where the rxq_ctrl was allocated */ + rxq_ctrl->socket = socket_id; rxq_obj->rxq_ctrl = rxq_ctrl; rxq_ctrl->is_hairpin = false; rxq_ctrl->sh = priv->sh;