| Message ID | 20220318150331.1650-1-david.marchand@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Ajit Khaparde |
| Headers | show |
| Series | net/bnxt: fix compatibility with some old firmwares | expand |
| Context | Check | Description |
|---|---|---|
| ci/iol-broadcom-Functional | fail | Functional Testing issues |
| ci/iol-x86_64-compile-testing | success | Testing PASS |
| ci/github-robot: build | success | github build: passed |
| ci/iol-aarch64-compile-testing | success | Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-x86_64-unit-testing | success | Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-aarch64-unit-testing | success | Testing PASS |
| ci/intel-Testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/checkpatch | success | coding style OK |
On Fri, Mar 18, 2022 at 8:03 AM David Marchand <david.marchand@redhat.com> wrote: > > This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. > > Reported by Red Hat QE: with older firmware versions (at least versions > 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this > change. > Revert it for now, waiting for a more complete fix. > > Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_hwrm.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index b4aeec593e..bff73a9566 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -1244,11 +1244,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) > else > HWRM_CHECK_RESULT(); > > - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) { > - rc = -EAGAIN; > - goto error; > - } > - > PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n", > resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b, > resp->hwrm_intf_upd_8b, resp->hwrm_fw_maj_8b, > @@ -6149,10 +6144,6 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp) > rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB); > > HWRM_CHECK_RESULT_SILENT(); > - > - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) > - rc = -EAGAIN; > - > HWRM_UNLOCK(); > > return rc; > -- > 2.23.0 >
30/03/2022 01:21, Ajit Khaparde: > On Fri, Mar 18, 2022 at 8:03 AM David Marchand > <david.marchand@redhat.com> wrote: > > > > This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. > > > > Reported by Red Hat QE: with older firmware versions (at least versions > > 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this > > change. > > Revert it for now, waiting for a more complete fix. > > > > Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand <david.marchand@redhat.com> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > > Patch applied to dpdk-next-net-brcm. Thanks It seems this patch has been lost. I don't find it in dpdk-next-net-brcm.
On Tue, May 17, 2022 at 12:18 AM Thomas Monjalon <thomas@monjalon.net> wrote: > > 30/03/2022 01:21, Ajit Khaparde: > > On Fri, Mar 18, 2022 at 8:03 AM David Marchand > > <david.marchand@redhat.com> wrote: > > > > > > This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. > > > > > > Reported by Red Hat QE: with older firmware versions (at least versions > > > 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this > > > change. > > > Revert it for now, waiting for a more complete fix. > > > > > > Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: David Marchand <david.marchand@redhat.com> > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > > > > Patch applied to dpdk-next-net-brcm. Thanks > > It seems this patch has been lost. > I don't find it in dpdk-next-net-brcm. Hmm.. Yes. I pushed it again. Please check. Thanks > > >
18/05/2022 05:58, Ajit Khaparde: > On Tue, May 17, 2022 at 12:18 AM Thomas Monjalon <thomas@monjalon.net> wrote: > > > > 30/03/2022 01:21, Ajit Khaparde: > > > On Fri, Mar 18, 2022 at 8:03 AM David Marchand > > > <david.marchand@redhat.com> wrote: > > > > > > > > This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. > > > > > > > > Reported by Red Hat QE: with older firmware versions (at least versions > > > > 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this > > > > change. > > > > Revert it for now, waiting for a more complete fix. > > > > > > > > Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: David Marchand <david.marchand@redhat.com> > > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > > > > > > Patch applied to dpdk-next-net-brcm. Thanks > > > > It seems this patch has been lost. > > I don't find it in dpdk-next-net-brcm. > Hmm.. Yes. > I pushed it again. Please check. Thanks OK Same issue with "net/bnxt: fix ulp parser to ignore segment offset "
On Tue, May 17, 2022 at 11:22 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > 18/05/2022 05:58, Ajit Khaparde: > > On Tue, May 17, 2022 at 12:18 AM Thomas Monjalon <thomas@monjalon.net> wrote: > > > > > > 30/03/2022 01:21, Ajit Khaparde: > > > > On Fri, Mar 18, 2022 at 8:03 AM David Marchand > > > > <david.marchand@redhat.com> wrote: > > > > > > > > > > This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. > > > > > > > > > > Reported by Red Hat QE: with older firmware versions (at least versions > > > > > 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this > > > > > change. > > > > > Revert it for now, waiting for a more complete fix. > > > > > > > > > > Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check") > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: David Marchand <david.marchand@redhat.com> > > > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > > > > > > > > Patch applied to dpdk-next-net-brcm. Thanks > > > > > > It seems this patch has been lost. > > > I don't find it in dpdk-next-net-brcm. > > Hmm.. Yes. > > I pushed it again. Please check. Thanks > > OK > Same issue with "net/bnxt: fix ulp parser to ignore segment offset " Thanks Thomas. Pushed again to dpdk-next-net-brcm. Please apply. > >
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index b4aeec593e..bff73a9566 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1244,11 +1244,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) else HWRM_CHECK_RESULT(); - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) { - rc = -EAGAIN; - goto error; - } - PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n", resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b, resp->hwrm_intf_upd_8b, resp->hwrm_fw_maj_8b, @@ -6149,10 +6144,6 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp) rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB); HWRM_CHECK_RESULT_SILENT(); - - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) - rc = -EAGAIN; - HWRM_UNLOCK(); return rc;
This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. Reported by Red Hat QE: with older firmware versions (at least versions 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this change. Revert it for now, waiting for a more complete fix. Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- drivers/net/bnxt/bnxt_hwrm.c | 9 --------- 1 file changed, 9 deletions(-)