diff mbox series

net/dpaa2: fix dpdmux default interface

Message ID 20220329202610.10786-1-laitianli@tom.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series net/dpaa2: fix dpdmux default interface |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Tianli Lai March 29, 2022, 8:26 p.m. UTC 
  if dpdmux objects created by restool tools with
the argument "--default-if=<if-id-number>", this
function would change it to 1

Signed-off-by: Tianli Lai <laitianli@tom.com>
---
 drivers/net/dpaa2/dpaa2_mux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hemant Agrawal March 29, 2022, 1:30 p.m. UTC | #1 
Acked-by:  Hemant Agrawal <hemant.agrawal@nxp.com>


On 3/30/2022 1:56 AM, Tianli Lai wrote:
> if dpdmux objects created by restool tools with
> the argument "--default-if=<if-id-number>", this
> function would change it to 1
>
> Signed-off-by: Tianli Lai <laitianli@tom.com>
> ---
>   drivers/net/dpaa2/dpaa2_mux.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c
> index bd4596b891..e8689a7832 100644
> --- a/drivers/net/dpaa2/dpaa2_mux.c
> +++ b/drivers/net/dpaa2/dpaa2_mux.c
> @@ -296,7 +296,7 @@ dpaa2_create_dpdmux_device(int vdev_fd __rte_unused,
>   	}
>   
>   	ret = dpdmux_if_set_default(&dpdmux_dev->dpdmux, CMD_PRI_LOW,
> -				    dpdmux_dev->token, 1);
> +				    dpdmux_dev->token, attr.default_if);
>   	if (ret) {
>   		DPAA2_PMD_ERR("setting default interface failed in %s",
>   			      __func__);
Hemant Agrawal March 29, 2022, 1:45 p.m. UTC | #2 
BTW, will you please add following fix tags to your commit message

Fixes: 1def64c2d79e ("net/dpaa2: add dpdmux initialization and configuration")
Cc: nipun.gupta@nxp.com

> -----Original Message-----
> From: Hemant Agrawal (OSS) <hemant.agrawal@oss.nxp.com>
> Sent: Tuesday, March 29, 2022 7:01 PM
> To: Tianli Lai <laitianli@tom.com>; dev@dpdk.org
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena (OSS)
> <sachin.saxena@oss.nxp.com>
> Subject: Re: [PATCH] net/dpaa2: fix dpdmux default interface
> Importance: High
> 
> Acked-by:  Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> 
> On 3/30/2022 1:56 AM, Tianli Lai wrote:
> > if dpdmux objects created by restool tools with the argument
> > "--default-if=<if-id-number>", this function would change it to 1
> >
> > Signed-off-by: Tianli Lai <laitianli@tom.com>
> > ---
> >   drivers/net/dpaa2/dpaa2_mux.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/dpaa2/dpaa2_mux.c
> > b/drivers/net/dpaa2/dpaa2_mux.c index bd4596b891..e8689a7832 100644
> > --- a/drivers/net/dpaa2/dpaa2_mux.c
> > +++ b/drivers/net/dpaa2/dpaa2_mux.c
> > @@ -296,7 +296,7 @@ dpaa2_create_dpdmux_device(int vdev_fd
> __rte_unused,
> >   	}
> >
> >   	ret = dpdmux_if_set_default(&dpdmux_dev->dpdmux,
> CMD_PRI_LOW,
> > -				    dpdmux_dev->token, 1);
> > +				    dpdmux_dev->token, attr.default_if);
> >   	if (ret) {
> >   		DPAA2_PMD_ERR("setting default interface failed in %s",
> >   			      __func__);
diff mbox series

Patch

diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c
index bd4596b891..e8689a7832 100644
--- a/drivers/net/dpaa2/dpaa2_mux.c
+++ b/drivers/net/dpaa2/dpaa2_mux.c
@@ -296,7 +296,7 @@  dpaa2_create_dpdmux_device(int vdev_fd __rte_unused,
 	}
 
 	ret = dpdmux_if_set_default(&dpdmux_dev->dpdmux, CMD_PRI_LOW,
-				    dpdmux_dev->token, 1);
+				    dpdmux_dev->token, attr.default_if);
 	if (ret) {
 		DPAA2_PMD_ERR("setting default interface failed in %s",
 			      __func__);