diff mbox series

[v2] app/testpmd: change a magic number to macro

Message ID 20220331023333.1632745-1-mingxia.liu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v2] app/testpmd: change a magic number to macro |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS

Commit Message

Liu, Mingxia March 31, 2022, 2:33 a.m. UTC 
  From: mingxial <mingxia.liu@intel.com>

Add macro MIN_TOTAL_NUM_MBUFS (1024) to indicate
what the value of total-num-mbufs should bigger than.

Fixes: c87988187fdb ("app/testpmd: add --total-num-mbufs option")
Cc: stable@dpdk.org

Signed-off-by: mingxial <mingxia.liu@intel.com>
---
 app/test-pmd/parameters.c | 5 +++--
 app/test-pmd/testpmd.h    | 2 ++
 2 files changed, 5 insertions(+), 2 deletions(-)

Comments

Zhang, Yuying April 1, 2022, 8:50 a.m. UTC | #1 
Hi Mingxia,

LGTM.

> -----Original Message-----
> From: Liu, Mingxia <mingxia.liu@intel.com>
> Sent: Thursday, March 31, 2022 10:34 AM
> To: dev@dpdk.org
> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman Deep
> <aman.deep.singh@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>;
> Liu, Mingxia <mingxia.liu@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] app/testpmd: change a magic number to macro
> 
> From: mingxial <mingxia.liu@intel.com>
> 
> Add macro MIN_TOTAL_NUM_MBUFS (1024) to indicate what the value of
> total-num-mbufs should bigger than.
> 
> Fixes: c87988187fdb ("app/testpmd: add --total-num-mbufs option")
> Cc: stable@dpdk.org
> 
> Signed-off-by: mingxial <mingxia.liu@intel.com>

Acked-by: Yuying Zhang <yuying.zhang@intel.com>

> ---
>  app/test-pmd/parameters.c | 5 +++--
>  app/test-pmd/testpmd.h    | 2 ++
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
> daf6a31b2b..641c9c767e 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -940,11 +940,12 @@ launch_args_parse(int argc, char** argv)
>  			}
>  			if (!strcmp(lgopts[opt_idx].name, "total-num-mbufs"))
> {
>  				n = atoi(optarg);
> -				if (n > 1024)
> +				if (n > MIN_TOTAL_NUM_MBUFS)
>  					param_total_num_mbufs =
> (unsigned)n;
>  				else
>  					rte_exit(EXIT_FAILURE,
> -						 "total-num-mbufs should be >
> 1024\n");
> +						 "total-num-mbufs should
> be > %d\n",
> +						 MIN_TOTAL_NUM_MBUFS);
>  			}
>  			if (!strcmp(lgopts[opt_idx].name, "max-pkt-len")) {
>  				n = atoi(optarg);
> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index
> 31f766c965..a633f81b50 100644
> --- a/app/test-pmd/testpmd.h
> +++ b/app/test-pmd/testpmd.h
> @@ -72,6 +72,8 @@
>  #define NUMA_NO_CONFIG 0xFF
>  #define UMA_NO_CONFIG  0xFF
> 
> +#define MIN_TOTAL_NUM_MBUFS 1024
> +
>  typedef uint8_t  lcoreid_t;
>  typedef uint16_t portid_t;
>  typedef uint16_t queueid_t;
> --
> 2.25.1
Ferruh Yigit May 20, 2022, 10:09 p.m. UTC | #2 
On 4/1/2022 9:50 AM, Zhang, Yuying wrote:
> Hi Mingxia,
> 
> LGTM.
> 
>> -----Original Message-----
>> From: Liu, Mingxia <mingxia.liu@intel.com>
>> Sent: Thursday, March 31, 2022 10:34 AM
>> To: dev@dpdk.org
>> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman Deep
>> <aman.deep.singh@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>;
>> Liu, Mingxia <mingxia.liu@intel.com>; stable@dpdk.org
>> Subject: [PATCH v2] app/testpmd: change a magic number to macro
>>
>> From: mingxial <mingxia.liu@intel.com>
>>
>> Add macro MIN_TOTAL_NUM_MBUFS (1024) to indicate what the value of
>> total-num-mbufs should bigger than.
>>
>> Fixes: c87988187fdb ("app/testpmd: add --total-num-mbufs option")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: mingxial <mingxia.liu@intel.com>
> 
> Acked-by: Yuying Zhang <yuying.zhang@intel.com>
> 

Updated sign off as:
Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index daf6a31b2b..641c9c767e 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -940,11 +940,12 @@  launch_args_parse(int argc, char** argv)
 			}
 			if (!strcmp(lgopts[opt_idx].name, "total-num-mbufs")) {
 				n = atoi(optarg);
-				if (n > 1024)
+				if (n > MIN_TOTAL_NUM_MBUFS)
 					param_total_num_mbufs = (unsigned)n;
 				else
 					rte_exit(EXIT_FAILURE,
-						 "total-num-mbufs should be > 1024\n");
+						 "total-num-mbufs should be > %d\n",
+						 MIN_TOTAL_NUM_MBUFS);
 			}
 			if (!strcmp(lgopts[opt_idx].name, "max-pkt-len")) {
 				n = atoi(optarg);
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 31f766c965..a633f81b50 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -72,6 +72,8 @@ 
 #define NUMA_NO_CONFIG 0xFF
 #define UMA_NO_CONFIG  0xFF
 
+#define MIN_TOTAL_NUM_MBUFS 1024
+
 typedef uint8_t  lcoreid_t;
 typedef uint16_t portid_t;
 typedef uint16_t queueid_t;