diff mbox series

net/bonding: fix rss key configuration when the key length is 52

Message ID 20220407093642.44900-1-ke1x.zhang@intel.com (mailing list archive)
State Superseded, archived
Headers
Series net/bonding: fix rss key configuration when the key length is 52 |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Zhang, Ke1X April 7, 2022, 9:36 a.m. UTC 
  when creating a bonding device, if the slave device's rss key length
is 52, then bonding device will be same as slave, in function
bond_ethdev_configure(), the default_rss_key length is 40, it
is not matched, so it should calculate a new key for bonding
device if the deault key could not be used.

Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

humin (Q) April 8, 2022, 2:32 a.m. UTC | #1 
Hi,

在 2022/4/7 17:36, Ke Zhang 写道:
> when creating a bonding device, if the slave device's rss key length
> is 52, then bonding device will be same as slave, in function
> bond_ethdev_configure(), the default_rss_key length is 40, it
> is not matched, so it should calculate a new key for bonding
> device if the deault key could not be used.
wrong spelling.
> 
> Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
> ---
>   drivers/net/bonding/rte_eth_bond_pmd.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index b305b6a35b..4214b33f40 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -3617,13 +3617,13 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
>   			       internals->rss_key_len);
>   		} else {
>   			if (internals->rss_key_len > sizeof(default_rss_key)) {
> -				RTE_BOND_LOG(ERR,
> -				       "There is no suitable default hash key");
> -				return -EINVAL;
> +				/* If the rss_key_len is 52, it should calculate the hash key */
I think the comment should be more common, no need to emphysize '52'.
> +				for (i = 0; i < internals->rss_key_len; i++)
> +					internals->rss_key[i] = (uint8_t)rte_rand();
> +			} else {
> +				memcpy(internals->rss_key, default_rss_key,
> +					internals->rss_key_len);
>   			}
> -
> -			memcpy(internals->rss_key, default_rss_key,
> -			       internals->rss_key_len);
>   		}
>   
>   		for (i = 0; i < RTE_DIM(internals->reta_conf); i++) {
>
Zhang, Ke1X April 11, 2022, 3:06 a.m. UTC | #2 
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Friday, April 8, 2022 10:33 AM
> To: Zhang, Ke1X <ke1x.zhang@intel.com>; chas3@att.com; dev@dpdk.org
> Subject: Re: [PATCH] net/bonding: fix rss key configuration when the key
> length is 52
> 
> Hi,
> 
> 在 2022/4/7 17:36, Ke Zhang 写道:
> > when creating a bonding device, if the slave device's rss key length
> > is 52, then bonding device will be same as slave, in function
> > bond_ethdev_configure(), the default_rss_key length is 40, it is not
> > matched, so it should calculate a new key for bonding device if the
> > deault key could not be used.
> wrong spelling.

This is a coding waring as below:
 
 _coding style issues_
 
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#64:
when creating a bonding device, if the slave device's rss key length

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#65:
 is 52, then bonding device will be same as slave, in function

total: 0 errors, 2 warnings, 0 checks, 19 lines checked

the 'slave' is correct, for exsample, testpmd cmd:
add bonding slave 0 2

> >
> > Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
> > ---
> >   drivers/net/bonding/rte_eth_bond_pmd.c | 12 ++++++------
> >   1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> > b/drivers/net/bonding/rte_eth_bond_pmd.c
> > index b305b6a35b..4214b33f40 100644
> > --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> > @@ -3617,13 +3617,13 @@ bond_ethdev_configure(struct rte_eth_dev
> *dev)
> >   			       internals->rss_key_len);
> >   		} else {
> >   			if (internals->rss_key_len > sizeof(default_rss_key))
> {
> > -				RTE_BOND_LOG(ERR,
> > -				       "There is no suitable default hash key");
> > -				return -EINVAL;
> > +				/* If the rss_key_len is 52, it should calculate
> the hash key */
> I think the comment should be more common, no need to emphysize '52'.
> > +				for (i = 0; i < internals->rss_key_len; i++)
> > +					internals->rss_key[i] =
> (uint8_t)rte_rand();
> > +			} else {
> > +				memcpy(internals->rss_key, default_rss_key,
> > +					internals->rss_key_len);
> >   			}
> > -
> > -			memcpy(internals->rss_key, default_rss_key,
> > -			       internals->rss_key_len);
> >   		}
> >
> >   		for (i = 0; i < RTE_DIM(internals->reta_conf); i++) {
> >
Stephen Hemminger April 12, 2022, 3:19 p.m. UTC | #3 
On Mon, 11 Apr 2022 03:06:46 +0000
"Zhang, Ke1X" <ke1x.zhang@intel.com> wrote:

> This is a coding waring as below:
>  
>  _coding style issues_
>  
> WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
> #64:
> when creating a bonding device, if the slave device's rss key length
> 
> WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
> #65:
>  is 52, then bonding device will be same as slave, in function
> 
> total: 0 errors, 2 warnings, 0 checks, 19 lines checked
> 
> the 'slave' is correct, for exsample, testpmd cmd:
> add bonding slave 0 2

Just a heads up, for 22.11 I plan to replace/deprecate use of master/slave
terminology in bonding driver.  The terms master/slave are legacy and most
commercial products have switched to the terms from the 802 standard.
humin (Q) April 13, 2022, 9:03 a.m. UTC | #4 
Hi, Stephen,

在 2022/4/12 23:19, Stephen Hemminger 写道:
> On Mon, 11 Apr 2022 03:06:46 +0000
> "Zhang, Ke1X" <ke1x.zhang@intel.com> wrote:
> 
>> This is a coding waring as below:
>>   
>>   _coding style issues_
>>   
>> WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
>> #64:
>> when creating a bonding device, if the slave device's rss key length
>>
>> WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
>> #65:
>>   is 52, then bonding device will be same as slave, in function
>>
>> total: 0 errors, 2 warnings, 0 checks, 19 lines checked
>>
>> the 'slave' is correct, for exsample, testpmd cmd:
>> add bonding slave 0 2
> 
> Just a heads up, for 22.11 I plan to replace/deprecate use of master/slave
> terminology in bonding driver.  The terms master/slave are legacy and most
> commercial products have switched to the terms from the 802 standard.
What are the terms ? Could you show them for us?
> .
>
Stephen Hemminger April 13, 2022, 4:12 p.m. UTC | #5 
On Wed, 13 Apr 2022 17:03:07 +0800
"Min Hu (Connor)" <humin29@huawei.com> wrote:

> Hi, Stephen,
> 
> 在 2022/4/12 23:19, Stephen Hemminger 写道:
> > On Mon, 11 Apr 2022 03:06:46 +0000
> > "Zhang, Ke1X" <ke1x.zhang@intel.com> wrote:
> >   
> >> This is a coding waring as below:
> >>   
> >>   _coding style issues_
> >>   
> >> WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
> >> #64:
> >> when creating a bonding device, if the slave device's rss key length
> >>
> >> WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
> >> #65:
> >>   is 52, then bonding device will be same as slave, in function
> >>
> >> total: 0 errors, 2 warnings, 0 checks, 19 lines checked
> >>
> >> the 'slave' is correct, for exsample, testpmd cmd:
> >> add bonding slave 0 2  
> > 
> > Just a heads up, for 22.11 I plan to replace/deprecate use of master/slave
> > terminology in bonding driver.  The terms master/slave are legacy and most
> > commercial products have switched to the terms from the 802 standard.  
> What are the terms ? Could you show them for us?

The current IEEE std is https://standards.ieee.org/ieee/802.1AX/6768/
which is unfortunately paywalled.

The terms in standard are "Aggregator Client" for the ports used in the device
and "Aggregator Partner/Multiplexor" but they are not quite the same.

Probably going to use client and multiplexor as terms; but open for discussion.
diff mbox series

Patch

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index b305b6a35b..4214b33f40 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3617,13 +3617,13 @@  bond_ethdev_configure(struct rte_eth_dev *dev)
 			       internals->rss_key_len);
 		} else {
 			if (internals->rss_key_len > sizeof(default_rss_key)) {
-				RTE_BOND_LOG(ERR,
-				       "There is no suitable default hash key");
-				return -EINVAL;
+				/* If the rss_key_len is 52, it should calculate the hash key */
+				for (i = 0; i < internals->rss_key_len; i++)
+					internals->rss_key[i] = (uint8_t)rte_rand();
+			} else {
+				memcpy(internals->rss_key, default_rss_key,
+					internals->rss_key_len);
 			}
-
-			memcpy(internals->rss_key, default_rss_key,
-			       internals->rss_key_len);
 		}
 
 		for (i = 0; i < RTE_DIM(internals->reta_conf); i++) {