drivers/net/ixgbe: remove expired symbols

  From: zhichao zeng <zhichaox.zeng@intel.com>

Remove expired experimental symbols.

Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
---
 drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
 drivers/net/ixgbe/version.map     | 10 +++++-----
 2 files changed, 10 insertions(+), 20 deletions(-)
  

> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Tuesday, April 12, 2022 22:27
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Subject: [DPDK] drivers/net/ixgbe: remove expired symbols
> 
> From: zhichao zeng <zhichaox.zeng@intel.com>
> 
> Remove expired experimental symbols.

The git commit can be enhanced like:

Title: net/ixgbe: promote MDIO API

Promote the MDIO APIs to be stable.

> 
> Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
> ---
>  drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
>  drivers/net/ixgbe/version.map     | 10 +++++-----
>  2 files changed, 10 insertions(+), 20 deletions(-)
> 


> diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map
> index bca5cc5826..b2063df1bb 100644
> --- a/drivers/net/ixgbe/version.map
> +++ b/drivers/net/ixgbe/version.map
> @@ -31,6 +31,11 @@ DPDK_22 {
>  	rte_pmd_ixgbe_set_vf_vlan_filter;
>  	rte_pmd_ixgbe_set_vf_vlan_insert;
>  	rte_pmd_ixgbe_set_vf_vlan_stripq;
> +	rte_pmd_ixgbe_mdio_lock;
> +	rte_pmd_ixgbe_mdio_unlock;
> +	rte_pmd_ixgbe_mdio_unlocked_read;
> +	rte_pmd_ixgbe_mdio_unlocked_write;

Put the above under ' rte_pmd_ixgbe_macsec_select_txsa;'

This is in alphabet order.

> +	rte_pmd_ixgbe_upd_fctrl_sbp;
> 
>  	local: *;
>  };
> @@ -40,9 +45,4 @@ EXPERIMENTAL {
> 
>  	rte_pmd_ixgbe_get_fdir_info;
>  	rte_pmd_ixgbe_get_fdir_stats;
> -	rte_pmd_ixgbe_mdio_lock;
> -	rte_pmd_ixgbe_mdio_unlock;
> -	rte_pmd_ixgbe_mdio_unlocked_read;
> -	rte_pmd_ixgbe_mdio_unlocked_write;
> -	rte_pmd_ixgbe_upd_fctrl_sbp;
>  };
> --
> 2.25.1
  

On Tue, Apr 12, 2022 at 02:27:06PM +0000, zhichaox.zeng@intel.com wrote:
> From: zhichao zeng <zhichaox.zeng@intel.com>
> 
> Remove expired experimental symbols.
> 
> Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
> ---
>  drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
>  drivers/net/ixgbe/version.map     | 10 +++++-----
>  2 files changed, 10 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> index eef6f6661c..4f1fe6029d 100644
> --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> @@ -586,9 +586,7 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
>   *   - (-ENODEV) if *port* invalid.
>   *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
>   */
> -__rte_experimental
> -int
> -rte_pmd_ixgbe_mdio_lock(uint16_t port);
> +int rte_pmd_ixgbe_mdio_lock(uint16_t port);
>  

I don't see the value in rewriting the prototypes to be all on one line as
part of this change. Just remove the experimental tag line in this patch,
to keep the diff as small as possible.

/Bruce
  

On Tue, Apr 12, 2022 at 9:23 AM Wang, Haiyue <haiyue.wang@intel.com> wrote:
>
> > -----Original Message-----
> > From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> > Sent: Tuesday, April 12, 2022 22:27
> > To: Wang, Haiyue <haiyue.wang@intel.com>
> > Cc: dev@dpdk.org; Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> > Subject: [DPDK] drivers/net/ixgbe: remove expired symbols
> >
> > From: zhichao zeng <zhichaox.zeng@intel.com>
> >
> > Remove expired experimental symbols.
>
> The git commit can be enhanced like:
>
> Title: net/ixgbe: promote MDIO API
>
> Promote the MDIO APIs to be stable.

Please, use get-maintainer.sh when sending patches, it will
automatically Cc relevant people.
Adding Ray in the loop.
  

> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Tuesday, April 12, 2022 16:39
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org
> Subject: Re: [DPDK] drivers/net/ixgbe: remove expired symbols
> 
> On Tue, Apr 12, 2022 at 02:27:06PM +0000, zhichaox.zeng@intel.com wrote:
> > From: zhichao zeng <zhichaox.zeng@intel.com>
> >
> > Remove expired experimental symbols.
> >
> > Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
> > ---
> >  drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
> >  drivers/net/ixgbe/version.map     | 10 +++++-----
> >  2 files changed, 10 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > index eef6f6661c..4f1fe6029d 100644
> > --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > @@ -586,9 +586,7 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
> >   *   - (-ENODEV) if *port* invalid.
> >   *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
> >   */
> > -__rte_experimental
> > -int
> > -rte_pmd_ixgbe_mdio_lock(uint16_t port);
> > +int rte_pmd_ixgbe_mdio_lock(uint16_t port);
> >
> 
> I don't see the value in rewriting the prototypes to be all on one line as
> part of this change. Just remove the experimental tag line in this patch,
> to keep the diff as small as possible.

+1, yes, clean patch. ;-)

> 
> /Bruce